Fix previous text input connection interrupts enter/space #171973

Renzo-Olivares · 2025-07-10T17:26:19Z

Fixes an issue where a previously closed text input connection may cause interference with hardware keyboard on Samsung devices.

On the Samsung Galaxy S10 Tab the Samsung IME will request the operating system to show the IME when pressing enter/space on components like a radio option or a checkbox if there was a previously opened text input connection. It seems the Samsung Keyboard is caching some text input related state, and when it detects an enter/space key it acts on this previously cached state even if the text input connection has been closed. This prevents the radio option/checkbox and framework as a whole from responding to the key events. To solve this issue we should reset the input method manager when the IME has been hidden, and when the framework closes the input connection we should also reset the input method manager if the IME is hidden at the time of closing. This effectively resets any state cached by the Samsung keyboard and it no longer acts on stale state.

Fixes #168099
Fixes #51478
Fixes #70546

Related:
#136745

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

camsim99

Overall looks good! I just have one question about the test.

camsim99 · 2025-07-14T19:54:10Z

...e/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

  }

+  @Test
+  public void clearTextInputClient_restartsImmWhenIMEHidden() {


I can see how this tests the changes to the TextInputPlugin constructor, but does this actually call/test clearTextInputClient? Sorry if I'm missing it; from what I can tell, that is only called via method channel?

Good point, I added a new test that calls clearTextInputClient explicitly.

justinmc

LGTM 👍

Restarting the IME when it disappears seems like it would be a good idea. I know we have had lots of bugs related to lingering state in Samsung IMEs and have tried a lot of hacks to restart the IME. It seems to me like you always want it to restart when it disappears though, and I'm encouraged by seeing this close several different issues.

loic-sharma · 2025-07-18T23:59:48Z

...e/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

+
  @Test
  public void destroy_clearTextInputMethodHandler() {
+


This new line looks unintentional? (Feel free to skip if this is intentional!)

Suggested change

Thanks for catching that!

camsim99

LGTM!

…utter/flutter#171973)

…1973) Fixes an issue where a previously closed text input connection may cause interference with hardware keyboard on Samsung devices. On the Samsung Galaxy S10 Tab the Samsung IME will request the operating system to show the IME when pressing enter/space on components like a radio option or a checkbox if there was a previously opened text input connection. It seems the Samsung Keyboard is caching some text input related state, and when it detects an enter/space key it acts on this previously cached state even if the text input connection has been closed. This prevents the radio option/checkbox and framework as a whole from responding to the key events. To solve this issue we should reset the input method manager when the IME has been hidden, and when the framework closes the input connection we should also reset the input method manager if the IME is hidden at the time of closing. This effectively resets any state cached by the Samsung keyboard and it no longer acts on stale state. Fixes flutter#168099 Fixes flutter#51478 Fixes flutter#70546 Related: flutter#136745 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Renzo Olivares <roliv@google.com>

…utter/flutter#171973)

Roll Flutter from 20788c0 to cfbaa18 (43 revisions) flutter/flutter@20788c0...cfbaa18 2025-07-28 git@reki.re Remove shortner (flutter/flutter#172844) 2025-07-28 matanlurey@users.noreply.github.com Update `flutter pub get` to use `flutter.version.json` (instead of `version`) (flutter/flutter#172798) 2025-07-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from i7RS-4iBtdndwa3Jy... to tK_PAaLeo0pUxi8hv... (flutter/flutter#172827) 2025-07-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4IewCwqcEm7r4QsXd... to i7RS-4iBtdndwa3Jy... (flutter/flutter#172808) 2025-07-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "fix: get content hash for master on local engine branches (#172792)" (flutter/flutter#172805) 2025-07-26 codefu@google.com fix: build size_exp artifacts in post (flutter/flutter#172802) 2025-07-26 codefu@google.com fix: get content hash for master on local engine branches (flutter/flutter#172792) 2025-07-25 matanlurey@users.noreply.github.com Update `main`/`master` repoExceptions analysis set (flutter/flutter#172796) 2025-07-25 matanlurey@users.noreply.github.com Remove deprecated `--[no-]-disable-dds` (flutter/flutter#172791) 2025-07-25 matanlurey@users.noreply.github.com `last_engine_commit.ps1`: Use `$flutterRoot` instead of `$gitTopLevel` (flutter/flutter#172786) 2025-07-25 matanlurey@users.noreply.github.com Check file contents, remove tests that are now invalid (`: 'none'`) (flutter/flutter#172788) 2025-07-25 loic.peron@inetum.com windows: allow pwsh.bat wrapper (flutter/flutter#171778) 2025-07-25 bdero@google.com [Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. (flutter/flutter#172592) 2025-07-25 matanlurey@users.noreply.github.com Remove deprecated `AssetManifest.json` file (flutter/flutter#172594) 2025-07-25 matanlurey@users.noreply.github.com Refactor `verifyVersion` into typed `Version` object, use it (flutter/flutter#172780) 2025-07-25 jmccandless@google.com Bump the customer tests to pick up an update to Zulip's tests, for th… (flutter/flutter#172733) 2025-07-25 matanlurey@users.noreply.github.com Rename `AppRunLogger`, stop writing status messages that break JSON (flutter/flutter#172591) 2025-07-25 matanlurey@users.noreply.github.com Add `--dart-define`, `-D` to `assemble`, deprecate `--define`, `-d`. (flutter/flutter#172510) 2025-07-25 rmolivares@renzo-olivares.dev Fix previous text input connection interrupts enter/space (flutter/flutter#171973) 2025-07-25 1063596+reidbaker@users.noreply.github.com Update CHANGELOG.md for 3.32.8 (flutter/flutter#172779) 2025-07-25 matanlurey@users.noreply.github.com Fix an `omit-type` lint that is breaking the tree (flutter/flutter#172776) 2025-07-25 reynaldots@gmail.com feat(tool): Respect user-data-dir flag from web-browser-flag (flutter/flutter#169445) 2025-07-25 mdebbar@google.com [web] Fix empty first frame in multiview mode (flutter/flutter#172493) 2025-07-25 jssaadeh@outlook.com Migrate to null aware elements - Part 3 (flutter/flutter#172307) 2025-07-25 mdebbar@google.com Update few links in docs (flutter/flutter#172166) 2025-07-25 engine-flutter-autoroll@skia.org Roll Skia from 768ace3fd144 to 409e1c7ba09b (1 revision) (flutter/flutter#172745) 2025-07-25 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from a_55b5hqpRnigzuNC... to 4IewCwqcEm7r4QsXd... (flutter/flutter#172742) 2025-07-25 engine-flutter-autoroll@skia.org Roll Skia from 094ac350125f to 768ace3fd144 (18 revisions) (flutter/flutter#172735) 2025-07-25 matanlurey@users.noreply.github.com Remove 2023 deprecated `'platforms'` key from daemon output (flutter/flutter#172593) 2025-07-24 a-siva@users.noreply.github.com Manual roll of Dart from 26dece893751 to 5ede85aff798 (flutter/flutter#172731) 2025-07-24 ievdokdm@gmail.com 169108 ci debug (flutter/flutter#172589) 2025-07-24 31685655+SalehTZ@users.noreply.github.com Improve assertion message in `_MixedBorderRadius.resolve()` (flutter/flutter#172100) 2025-07-24 ahmedsameha1@gmail.com Make sure that a BottomAppBar doesn't crash in 0x0 environment (flutter/flutter#172097) 2025-07-24 ahmedsameha1@gmail.com Handle#6537 bottom navigation bar (flutter/flutter#172404) 2025-07-24 ahmedsameha1@gmail.com Make sure that a MaterialBanner doesn't crash in 0x0 environment (flutter/flutter#172074) 2025-07-24 matanlurey@users.noreply.github.com Remove support for `pluginClass: none` (on `master`; `> 3.35.0`) (flutter/flutter#172579) 2025-07-24 ahmedsameha1@gmail.com Make sure that a Card doesn't crash in 0x0 environment (flutter/flutter#172373) 2025-07-24 ahmedsameha1@gmail.com Make sure that an AboutDialog doesn't crash in 0x0 environment (flutter/flutter#172444) 2025-07-24 ahmedsameha1@gmail.com Make sure that an ActionChip doesn't crash in 0x0 environment (flutter/flutter#172684) 2025-07-24 matanlurey@users.noreply.github.com Delete (unused) `dev/checks_tool` directory (flutter/flutter#172715) 2025-07-24 34871572+gmackall@users.noreply.github.com [Android] Add missing ci configuration for `Linux android_java17_tool_integration_tests` (flutter/flutter#172702) 2025-07-24 srawlins@google.com Flutter-Cherrypick-Process.md - Spell cherry-pick consistently (flutter/flutter#172697) 2025-07-24 matanlurey@users.noreply.github.com Bringup `linux_web_engine_tests`; failing 4+ times in a row (flutter/flutter#172714) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

…1973) Fixes an issue where a previously closed text input connection may cause interference with hardware keyboard on Samsung devices. On the Samsung Galaxy S10 Tab the Samsung IME will request the operating system to show the IME when pressing enter/space on components like a radio option or a checkbox if there was a previously opened text input connection. It seems the Samsung Keyboard is caching some text input related state, and when it detects an enter/space key it acts on this previously cached state even if the text input connection has been closed. This prevents the radio option/checkbox and framework as a whole from responding to the key events. To solve this issue we should reset the input method manager when the IME has been hidden, and when the framework closes the input connection we should also reset the input method manager if the IME is hidden at the time of closing. This effectively resets any state cached by the Samsung keyboard and it no longer acts on stale state. Fixes flutter#168099 Fixes flutter#51478 Fixes flutter#70546 Related: flutter#136745 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Renzo Olivares <roliv@google.com>

…utter/flutter#171973)

…1973) Fixes an issue where a previously closed text input connection may cause interference with hardware keyboard on Samsung devices. On the Samsung Galaxy S10 Tab the Samsung IME will request the operating system to show the IME when pressing enter/space on components like a radio option or a checkbox if there was a previously opened text input connection. It seems the Samsung Keyboard is caching some text input related state, and when it detects an enter/space key it acts on this previously cached state even if the text input connection has been closed. This prevents the radio option/checkbox and framework as a whole from responding to the key events. To solve this issue we should reset the input method manager when the IME has been hidden, and when the framework closes the input connection we should also reset the input method manager if the IME is hidden at the time of closing. This effectively resets any state cached by the Samsung keyboard and it no longer acts on stale state. Fixes flutter#168099 Fixes flutter#51478 Fixes flutter#70546 Related: flutter#136745 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Renzo Olivares <roliv@google.com>

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Jul 10, 2025

Renzo-Olivares changed the title ~~Fix previous text input connection interrupts enter/space~~ [WIP] Fix previous text input connection interrupts enter/space Jul 10, 2025

Renzo-Olivares force-pushed the enter-fix branch 2 times, most recently from 81c80a3 to 617dbdc Compare July 10, 2025 18:43

Renzo-Olivares marked this pull request as ready for review July 10, 2025 18:44

Renzo-Olivares requested a review from a team as a code owner July 10, 2025 18:44

reidbaker requested review from camsim99 and justinmc July 10, 2025 20:24

Renzo-Olivares changed the title ~~[WIP] Fix previous text input connection interrupts enter/space~~ Fix previous text input connection interrupts enter/space Jul 10, 2025

camsim99 reviewed Jul 14, 2025

View reviewed changes

Renzo-Olivares force-pushed the enter-fix branch 2 times, most recently from aadb99a to 388498f Compare July 17, 2025 20:52

justinmc approved these changes Jul 18, 2025

View reviewed changes

loic-sharma reviewed Jul 18, 2025

View reviewed changes

Renzo-Olivares force-pushed the enter-fix branch from 50022d6 to 100856a Compare July 21, 2025 18:31

Renzo-Olivares requested review from camsim99 and loic-sharma July 21, 2025 18:31

camsim99 approved these changes Jul 24, 2025

View reviewed changes

Renzo Olivares added 10 commits July 24, 2025 17:47

Fix previous text input connection interrupts enter/space

fed56fd

remove logs

ed2e86c

et format

13c6a63

clean up

c5b739d

add test

f4179dd

update tests

21b0f8a

update test

5989a75

Update tests

f8299e1

format

e5e2818

remove new line

632c77c

Renzo-Olivares force-pushed the enter-fix branch from 100856a to 632c77c Compare July 25, 2025 00:47

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2025

auto-submit bot added this pull request to the merge queue Jul 25, 2025

Merged via the queue into flutter:master with commit 0abc2ec Jul 25, 2025
175 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2025

Piinks mentioned this pull request Jul 25, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll mentioned this pull request Jul 26, 2025

Roll Flutter from 20788c07fcb8 to a9f310a4c91a (39 revisions) flutter/packages#9680

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

0abc2ec Fix previous text input connection interrupts enter/space (fl…

a392967

…utter/flutter#171973)

engine-flutter-autoroll mentioned this pull request Jul 26, 2025

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

0abc2ec Fix previous text input connection interrupts enter/space (fl…

ef0ab92

…utter/flutter#171973)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2025

0abc2ec29 Fix previous text input connection interrupts enter/space (f…

487184a

…utter/flutter#171973)

This was referenced Jul 26, 2025

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9682

Closed

Roll Flutter from 20788c07fcb8 to b42ef815987c (40 revisions) flutter/packages#9683

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2025

0abc2ec Fix previous text input connection interrupts enter/space (fl…

1dfa5fb

…utter/flutter#171973)

engine-flutter-autoroll mentioned this pull request Jul 28, 2025

Roll Flutter from 20788c07fcb8 to 0125d95f7eb0 (42 revisions) flutter/packages#9686

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2025

0abc2ec Fix previous text input connection interrupts enter/space (fl…

db5d21b

…utter/flutter#171973)

engine-flutter-autoroll mentioned this pull request Jul 28, 2025

Roll Flutter from 20788c07fcb8 to cfbaa18bdecc (43 revisions) flutter/packages#9688

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2025

0abc2ec Fix previous text input connection interrupts enter/space (fl…

00991e8

…utter/flutter#171973)

bleroux mentioned this pull request Aug 8, 2025

HardwareKeyboard handler does not fire events when textfield is in focus. #160786

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

0abc2ec Fix previous text input connection interrupts enter/space (fl…

1b0aa91

…utter/flutter#171973)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix previous text input connection interrupts enter/space #171973

Fix previous text input connection interrupts enter/space #171973

Uh oh!

Renzo-Olivares commented Jul 10, 2025 •

edited

Loading

Uh oh!

camsim99 left a comment

Uh oh!

camsim99 Jul 14, 2025

Uh oh!

Renzo-Olivares Jul 21, 2025 •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

loic-sharma Jul 18, 2025

Uh oh!

Renzo-Olivares Jul 21, 2025

Uh oh!

camsim99 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix previous text input connection interrupts enter/space #171973

Fix previous text input connection interrupts enter/space #171973

Uh oh!

Conversation

Renzo-Olivares commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

camsim99 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

loic-sharma Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Renzo-Olivares commented Jul 10, 2025 •

edited

Loading

Renzo-Olivares Jul 21, 2025 •

edited

Loading