Add a warning on usage of `dartPluginClass: 'none'`. #172315

matanlurey · 2025-07-17T20:59:36Z

Towards #57497.

Supersedes #171922 based on @stuartmorgan-g's advice for a warning release.

I'll CP this into 3.35 (beta) so that we can clean it up on master anytime.

stuartmorgan-g

LGTM

@stuartmorgan-g

Towards flutter#57497. Supersedes flutter#171922 based on @stuartmorgan-g's advice for a warning release. I'll CP this into `3.35` (beta) so that we can clean it up on `master` anytime.

…/flutter#172315)

flutter/flutter@70cdc0c...ee0cc66 2025-07-22 30870216+gaaclarke@users.noreply.github.com Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 hirofumi0081@gmail.com fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 matanlurey@users.noreply.github.com Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 huy@nevercode.io Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 victorsanniay@gmail.com Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 engine-flutter-autoroll@skia.org Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 30870216+gaaclarke@users.noreply.github.com Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 matanlurey@users.noreply.github.com Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 matanlurey@users.noreply.github.com Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 ricardodalarme@outlook.com feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 robert.ancell@canonical.com Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 34465683+rkishan516@users.noreply.github.com Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 engine-flutter-autoroll@skia.org Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 matanlurey@users.noreply.github.com Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 p1318k@gmail.com fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 engine-flutter-autoroll@skia.org Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 stuartmorgan@google.com Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 32538273+ValentinVignal@users.noreply.github.com Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 58529443+srujzs@users.noreply.github.com Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 matanlurey@users.noreply.github.com Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 jason-simmons@users.noreply.github.com Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 matanlurey@users.noreply.github.com Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 matanlurey@users.noreply.github.com Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 matanlurey@users.noreply.github.com Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 matanlurey@users.noreply.github.com Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 matanlurey@users.noreply.github.com Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…2579) Closes #57497. Warning was added to `3.35.0`-branch here: #172315 ... so this will only apply on `master`, and then the stable/beta releases _after_ `3.35.0` ships to stable (quite some time).

@stuartmorgan-g

Towards flutter#57497. Supersedes flutter#171922 based on @stuartmorgan-g's advice for a warning release. I'll CP this into `3.35` (beta) so that we can clean it up on `master` anytime.

…tter#172579) Closes flutter#57497. Warning was added to `3.35.0`-branch here: flutter#172315 ... so this will only apply on `master`, and then the stable/beta releases _after_ `3.35.0` ships to stable (quite some time).

flutter/flutter@70cdc0c...ee0cc66 2025-07-22 30870216+gaaclarke@users.noreply.github.com Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 hirofumi0081@gmail.com fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 matanlurey@users.noreply.github.com Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 huy@nevercode.io Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 victorsanniay@gmail.com Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 engine-flutter-autoroll@skia.org Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 30870216+gaaclarke@users.noreply.github.com Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 matanlurey@users.noreply.github.com Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 matanlurey@users.noreply.github.com Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 ricardodalarme@outlook.com feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 robert.ancell@canonical.com Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 34465683+rkishan516@users.noreply.github.com Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 engine-flutter-autoroll@skia.org Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 matanlurey@users.noreply.github.com Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 p1318k@gmail.com fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 engine-flutter-autoroll@skia.org Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 stuartmorgan@google.com Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 32538273+ValentinVignal@users.noreply.github.com Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 58529443+srujzs@users.noreply.github.com Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 matanlurey@users.noreply.github.com Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 jason-simmons@users.noreply.github.com Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 matanlurey@users.noreply.github.com Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 matanlurey@users.noreply.github.com Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 matanlurey@users.noreply.github.com Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 matanlurey@users.noreply.github.com Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 matanlurey@users.noreply.github.com Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@stuartmorgan-g

Towards flutter#57497. Supersedes flutter#171922 based on @stuartmorgan-g's advice for a warning release. I'll CP this into `3.35` (beta) so that we can clean it up on `master` anytime.

…tter#172579) Closes flutter#57497. Warning was added to `3.35.0`-branch here: flutter#172315 ... so this will only apply on `master`, and then the stable/beta releases _after_ `3.35.0` ships to stable (quite some time).

@stuartmorgan-g

Towards flutter#57497. Supersedes flutter#171922 based on @stuartmorgan-g's advice for a warning release. I'll CP this into `3.35` (beta) so that we can clean it up on `master` anytime.

…tter#172579) Closes flutter#57497. Warning was added to `3.35.0`-branch here: flutter#172315 ... so this will only apply on `master`, and then the stable/beta releases _after_ `3.35.0` ships to stable (quite some time).

@stuartmorgan-g

Towards flutter#57497. Supersedes flutter#171922 based on @stuartmorgan-g's advice for a warning release. I'll CP this into `3.35` (beta) so that we can clean it up on `master` anytime.

…tter#172579) Closes flutter#57497. Warning was added to `3.35.0`-branch here: flutter#172315 ... so this will only apply on `master`, and then the stable/beta releases _after_ `3.35.0` ships to stable (quite some time).

…/flutter#172315)

@stuartmorgan-g

Towards flutter#57497. Supersedes flutter#171922 based on @stuartmorgan-g's advice for a warning release. I'll CP this into `3.35` (beta) so that we can clean it up on `master` anytime.

…tter#172579) Closes flutter#57497. Warning was added to `3.35.0`-branch here: flutter#172315 ... so this will only apply on `master`, and then the stable/beta releases _after_ `3.35.0` ships to stable (quite some time).

Add a warning on usage of dartPluginClass: none.

a721ea9

matanlurey requested review from bkonyi and stuartmorgan-g July 17, 2025 20:59

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 17, 2025

matanlurey mentioned this pull request Jul 17, 2025

Cleanup 5 year old handling of pluginClass: none #171922

Closed

stuartmorgan-g approved these changes Jul 18, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

auto-submit bot added this pull request to the merge queue Jul 21, 2025

Merged via the queue into flutter:master with commit 5ed913b Jul 21, 2025
142 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

matanlurey added the cp: beta cherry pick this pull request to beta release candidate branch label Jul 21, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

5ed913b Add a warning on usage of dartPluginClass: 'none'. (flutter…

d6fa2a0

…/flutter#172315)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to d16e5b9971e7 (26 revisions) flutter/packages#9659

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

5ed913b Add a warning on usage of dartPluginClass: 'none'. (flutter…

97540da

…/flutter#172315)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to 404fb3f14fdd (27 revisions) flutter/packages#9660

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

5ed913b Add a warning on usage of dartPluginClass: 'none'. (flutter…

4e2a255

…/flutter#172315)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to 404fb3f14fdd (27 revisions) flutter/packages#9661

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

5ed913b Add a warning on usage of dartPluginClass: 'none'. (flutter…

bcf3ee8

…/flutter#172315)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to ee0cc6652be7 (29 revisions) flutter/packages#9662

Merged

matanlurey mentioned this pull request Jul 22, 2025

Remove support for pluginClass: none (on master; > 3.35.0) #172579

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

5ed913b Add a warning on usage of dartPluginClass: 'none'. (flutter…

962aa09

…/flutter#172315)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a warning on usage of `dartPluginClass: 'none'`. #172315

Add a warning on usage of `dartPluginClass: 'none'`. #172315

Uh oh!

matanlurey commented Jul 17, 2025

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add a warning on usage of dartPluginClass: 'none'. #172315

Add a warning on usage of dartPluginClass: 'none'. #172315

Uh oh!

Conversation

matanlurey commented Jul 17, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add a warning on usage of `dartPluginClass: 'none'`. #172315

Add a warning on usage of `dartPluginClass: 'none'`. #172315