Wrap `ShutdownHook` calls to avoid crashing the tool #171917

matanlurey · 2025-07-09T21:41:06Z

bkonyi · 2025-07-10T20:29:30Z

packages/flutter_tools/lib/src/base/process.dart

+      for (final ShutdownHook shutdownHook in registeredHooks) {
+        try {
+          final Future<void> future = asyncGuard<void>(
+            () async => shutdownHook(),


Can this just be shutdownHook since ShutdownHook is just FutureOr<void> Function()?

No, because asyncGuard requires Future<T> and shutdownHook is FutureOr<>.

…-hook

auto-submit · 2025-07-17T20:42:26Z

autosubmit label was removed for flutter/flutter/171917, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-07-17T21:23:26Z

autosubmit label was removed for flutter/flutter/171917, because - The status or check suite Linux tool_integration_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-07-21T16:44:07Z

autosubmit label was removed for flutter/flutter/171917, because Pull request flutter/flutter/171917 is not in a mergeable state.

auto-submit · 2025-07-21T16:50:23Z

autosubmit label was removed for flutter/flutter/171917, because - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux_tool-tests-general has failed. Please fix the issues identified (or deflake) before re-applying this label.

…/flutter#171917)

flutter/flutter@70cdc0c...ee0cc66 2025-07-22 30870216+gaaclarke@users.noreply.github.com Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 hirofumi0081@gmail.com fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 matanlurey@users.noreply.github.com Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 huy@nevercode.io Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 victorsanniay@gmail.com Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 engine-flutter-autoroll@skia.org Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 30870216+gaaclarke@users.noreply.github.com Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 matanlurey@users.noreply.github.com Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 matanlurey@users.noreply.github.com Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 ricardodalarme@outlook.com feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 robert.ancell@canonical.com Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 34465683+rkishan516@users.noreply.github.com Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 engine-flutter-autoroll@skia.org Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 matanlurey@users.noreply.github.com Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 p1318k@gmail.com fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 engine-flutter-autoroll@skia.org Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 stuartmorgan@google.com Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 32538273+ValentinVignal@users.noreply.github.com Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 58529443+srujzs@users.noreply.github.com Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 matanlurey@users.noreply.github.com Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 jason-simmons@users.noreply.github.com Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 matanlurey@users.noreply.github.com Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 matanlurey@users.noreply.github.com Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 matanlurey@users.noreply.github.com Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 matanlurey@users.noreply.github.com Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 matanlurey@users.noreply.github.com Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closes flutter#57351.

flutter/flutter@70cdc0c...ee0cc66 2025-07-22 30870216+gaaclarke@users.noreply.github.com Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 hirofumi0081@gmail.com fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 matanlurey@users.noreply.github.com Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 huy@nevercode.io Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 victorsanniay@gmail.com Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 engine-flutter-autoroll@skia.org Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 30870216+gaaclarke@users.noreply.github.com Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 matanlurey@users.noreply.github.com Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 matanlurey@users.noreply.github.com Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 ricardodalarme@outlook.com feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 robert.ancell@canonical.com Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 34465683+rkishan516@users.noreply.github.com Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 engine-flutter-autoroll@skia.org Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 matanlurey@users.noreply.github.com Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 p1318k@gmail.com fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 engine-flutter-autoroll@skia.org Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 stuartmorgan@google.com Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 32538273+ValentinVignal@users.noreply.github.com Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 58529443+srujzs@users.noreply.github.com Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 matanlurey@users.noreply.github.com Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 jason-simmons@users.noreply.github.com Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 matanlurey@users.noreply.github.com Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 matanlurey@users.noreply.github.com Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 matanlurey@users.noreply.github.com Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 matanlurey@users.noreply.github.com Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 matanlurey@users.noreply.github.com Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closes flutter#57351.

…/flutter#171917)

Closes flutter#57351.

matanlurey and others added 6 commits July 9, 2025 11:20

Add public postmortem of 3.32.3 release.

901e1e9

++

ac7c4c2

Merge branch 'master' into add-public-postmortem

8fb07e9

Trigger Build

cab420e

++

80cb866

Wrap shutdown hook calls to not crash the tool

66bac47

matanlurey requested a review from bkonyi July 9, 2025 21:41

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. d: docs/ flutter/flutter/docs, for contributors labels Jul 9, 2025

Oops bad baseref

f615412

github-actions bot removed the d: docs/ flutter/flutter/docs, for contributors label Jul 9, 2025

bkonyi approved these changes Jul 10, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/master' into uncaught-shutdown…

3959c81

…-hook

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025

++

9708e56

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025

++

e190647

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

Merge branch 'master' into uncaught-shutdown-hook

9d869a2

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

Fix merge deets

2bc407d

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

auto-submit bot added this pull request to the merge queue Jul 21, 2025

Merged via the queue into flutter:master with commit 8527604 Jul 21, 2025
140 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

8527604 Wrap ShutdownHook calls to avoid crashing the tool (flutter…

39dbf33

…/flutter#171917)

This was referenced Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to d16e5b9971e7 (26 revisions) flutter/packages#9659

Closed

Roll Flutter from 70cdc0c933d6 to 404fb3f14fdd (27 revisions) flutter/packages#9660

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

8527604 Wrap ShutdownHook calls to avoid crashing the tool (flutter…

8fd813a

…/flutter#171917)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

8527604 Wrap ShutdownHook calls to avoid crashing the tool (flutter…

71e256d

…/flutter#171917)

This was referenced Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to 404fb3f14fdd (27 revisions) flutter/packages#9661

Closed

Roll Flutter from 70cdc0c933d6 to ee0cc6652be7 (29 revisions) flutter/packages#9662

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

8527604 Wrap ShutdownHook calls to avoid crashing the tool (flutter…

ae027fe

…/flutter#171917)

azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025

Wrap ShutdownHook calls to avoid crashing the tool (flutter#171917)

ea750e9

Closes flutter#57351.

ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025

Wrap ShutdownHook calls to avoid crashing the tool (flutter#171917)

c25afce

Closes flutter#57351.

mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025

Wrap ShutdownHook calls to avoid crashing the tool (flutter#171917)

187f914

Closes flutter#57351.

korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025

Wrap ShutdownHook calls to avoid crashing the tool (flutter#171917)

edcd895

Closes flutter#57351.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

8527604 Wrap ShutdownHook calls to avoid crashing the tool (flutter…

02eac50

…/flutter#171917)

lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025

Wrap ShutdownHook calls to avoid crashing the tool (flutter#171917)

6c3e5d8

Closes flutter#57351.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Wrap `ShutdownHook` calls to avoid crashing the tool #171917

Wrap `ShutdownHook` calls to avoid crashing the tool #171917

matanlurey commented Jul 9, 2025

Uh oh!

bkonyi Jul 10, 2025

Uh oh!

matanlurey Jul 17, 2025

Uh oh!

auto-submit bot commented Jul 17, 2025

Uh oh!

auto-submit bot commented Jul 17, 2025

Uh oh!

auto-submit bot commented Jul 21, 2025

Uh oh!

auto-submit bot commented Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Wrap ShutdownHook calls to avoid crashing the tool #171917

Wrap ShutdownHook calls to avoid crashing the tool #171917

Conversation

matanlurey commented Jul 9, 2025

Uh oh!

bkonyi Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jul 17, 2025

Uh oh!

auto-submit bot commented Jul 17, 2025

Uh oh!

auto-submit bot commented Jul 21, 2025

Uh oh!

auto-submit bot commented Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Wrap `ShutdownHook` calls to avoid crashing the tool #171917

Wrap `ShutdownHook` calls to avoid crashing the tool #171917