Skip to content

Remove IDE validation from flutter doctor #171924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jul 21, 2025
Merged

Remove IDE validation from flutter doctor #171924

auto-submit merged 2 commits into from
Jul 21, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Jul 9, 2025

Closes #61246.

I open to doing this behind a flag, but given we decided already 5 years ago to do this, I'm leaning limiting this to an announcement (flutter-announce@) and just landing this cleanup.

Open to suggestions.

@matanlurey matanlurey requested a review from bkonyi July 9, 2025 22:35
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team labels Jul 9, 2025
@matanlurey
Copy link
Contributor Author

matanlurey commented Jul 9, 2025

The google3 testing is legitimate, we'd need to do a bit of cleanup work there as well.

bkonyi
bkonyi approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, especially since it shouldn't break anyone.

@matanlurey matanlurey marked this pull request as ready for review July 17, 2025 21:03
@matanlurey matanlurey requested a review from a team as a code owner July 17, 2025 21:03
@reidbaker reidbaker requested a review from jwren July 21, 2025 14:59
reidbaker
reidbaker approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but please wait for @jwren's approval before merging.

@matanlurey
Copy link
Contributor Author

matanlurey commented Jul 21, 2025

Chatted with @jwren offline - I agree there is some value to having hints about proper installation of IDEs (perhaps the original intent of this feature), but as you can see from issues such as #70216, we are not there - and we don't have any prioritization around investing more in these approaches.

The cost of reviving this feature is cheap (git revert ___) if we change our mind/priorities.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 21, 2025
Merged via the queue into flutter:master with commit 1c1f234 Jul 21, 2025
142 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
@engine-flutter-autoroll
1c1f234 Remove IDE validation from flutter doctor (flutter/flutter#…
5a1594f 
…171924)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
@engine-flutter-autoroll
1c1f234 Remove IDE validation from flutter doctor (flutter/flutter#…
cf55cc2 
…171924)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
@engine-flutter-autoroll
1c1f234 Remove IDE validation from flutter doctor (flutter/flutter#…
79c83f8 
…171924)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
@engine-flutter-autoroll
1c1f234 Remove IDE validation from flutter doctor (flutter/flutter#…
8c7571f 
…171924)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 22, 2025
@engine-flutter-autoroll
Roll Flutter from 70cdc0c933d6 to ee0cc6652be7 (29 revisions) (#9662)
63646c6 
flutter/flutter@70cdc0c...ee0cc66

2025-07-22 30870216+gaaclarke@users.noreply.github.com Licenses cpp ignore whitespace (flutter/flutter#172512)
2025-07-22 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552)
2025-07-22 hirofumi0081@gmail.com fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206)
2025-07-22 matanlurey@users.noreply.github.com Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508)
2025-07-22 huy@nevercode.io Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970)
2025-07-22 victorsanniay@gmail.com Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485)
2025-07-22 engine-flutter-autoroll@skia.org Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515)
2025-07-22 30870216+gaaclarke@users.noreply.github.com Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486)
2025-07-22 matanlurey@users.noreply.github.com Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506)
2025-07-22 matanlurey@users.noreply.github.com Refactor checks for `--machine` (flutter/flutter#172504)
2025-07-22 ricardodalarme@outlook.com feat(IconButton): add property to specify a states controller (flutter/flutter#169821)
2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505)
2025-07-21 robert.ancell@canonical.com Render Flutter in its own EGL context (flutter/flutter#172330)
2025-07-21 34465683+rkishan516@users.noreply.github.com Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262)
2025-07-21 engine-flutter-autoroll@skia.org Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479)
2025-07-21 matanlurey@users.noreply.github.com Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917)
2025-07-21 p1318k@gmail.com fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282)
2025-07-21 engine-flutter-autoroll@skia.org Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471)
2025-07-21 stuartmorgan@google.com Add CLA note to tree hygiene (flutter/flutter#172475)
2025-07-21 32538273+ValentinVignal@users.noreply.github.com Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851)
2025-07-21 58529443+srujzs@users.noreply.github.com Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271)
2025-07-21 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927)
2025-07-21 matanlurey@users.noreply.github.com Add support for `/?` to alias to `--help` (flutter/flutter#172328)
2025-07-21 jason-simmons@users.noreply.github.com Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400)
2025-07-21 matanlurey@users.noreply.github.com Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327)
2025-07-21 matanlurey@users.noreply.github.com Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329)
2025-07-21 matanlurey@users.noreply.github.com Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315)
2025-07-21 matanlurey@users.noreply.github.com Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326)
2025-07-21 matanlurey@users.noreply.github.com Remove IDE validation from `flutter doctor` (flutter/flutter#171924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@tirth-patel-nc tirth-patel-nc mentioned this pull request Jul 25, 2025
Closed
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
@matanlurey @azatech
Remove IDE validation from flutter doctor (flutter#171924)
e82ac11 
Closes flutter#61246.

I open to doing this behind a flag, but given we decided already 5 years
ago to do this, I'm leaning limiting this to an announcement
(`flutter-announce@`) and just landing this cleanup.

Open to suggestions.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@engine-flutter-autoroll @vashworth
Roll Flutter from 70cdc0c to ee0cc66 (29 revisions) (flutter#9662)
848a02a 
flutter/flutter@70cdc0c...ee0cc66

2025-07-22 30870216+gaaclarke@users.noreply.github.com Licenses cpp ignore whitespace (flutter/flutter#172512)
2025-07-22 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552)
2025-07-22 hirofumi0081@gmail.com fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206)
2025-07-22 matanlurey@users.noreply.github.com Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508)
2025-07-22 huy@nevercode.io Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970)
2025-07-22 victorsanniay@gmail.com Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485)
2025-07-22 engine-flutter-autoroll@skia.org Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515)
2025-07-22 30870216+gaaclarke@users.noreply.github.com Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486)
2025-07-22 matanlurey@users.noreply.github.com Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506)
2025-07-22 matanlurey@users.noreply.github.com Refactor checks for `--machine` (flutter/flutter#172504)
2025-07-22 ricardodalarme@outlook.com feat(IconButton): add property to specify a states controller (flutter/flutter#169821)
2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505)
2025-07-21 robert.ancell@canonical.com Render Flutter in its own EGL context (flutter/flutter#172330)
2025-07-21 34465683+rkishan516@users.noreply.github.com Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262)
2025-07-21 engine-flutter-autoroll@skia.org Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479)
2025-07-21 matanlurey@users.noreply.github.com Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917)
2025-07-21 p1318k@gmail.com fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282)
2025-07-21 engine-flutter-autoroll@skia.org Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471)
2025-07-21 stuartmorgan@google.com Add CLA note to tree hygiene (flutter/flutter#172475)
2025-07-21 32538273+ValentinVignal@users.noreply.github.com Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851)
2025-07-21 58529443+srujzs@users.noreply.github.com Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271)
2025-07-21 codefu@google.com feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927)
2025-07-21 matanlurey@users.noreply.github.com Add support for `/?` to alias to `--help` (flutter/flutter#172328)
2025-07-21 jason-simmons@users.noreply.github.com Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400)
2025-07-21 matanlurey@users.noreply.github.com Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327)
2025-07-21 matanlurey@users.noreply.github.com Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329)
2025-07-21 matanlurey@users.noreply.github.com Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315)
2025-07-21 matanlurey@users.noreply.github.com Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326)
2025-07-21 matanlurey@users.noreply.github.com Remove IDE validation from `flutter doctor` (flutter/flutter#171924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@matanlurey matanlurey mentioned this pull request Aug 14, 2025
Open
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
@matanlurey @ksokolovskyi
Remove IDE validation from flutter doctor (flutter#171924)
5708778 
Closes flutter#61246.

I open to doing this behind a flag, but given we decided already 5 years
ago to do this, I'm leaning limiting this to an announcement
(`flutter-announce@`) and just landing this cleanup.

Open to suggestions.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@matanlurey @mboetger
Remove IDE validation from flutter doctor (flutter#171924)
6682810 
Closes flutter#61246.

I open to doing this behind a flag, but given we decided already 5 years
ago to do this, I'm leaning limiting this to an announcement
(`flutter-announce@`) and just landing this cleanup.

Open to suggestions.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
@matanlurey @korca0220
Remove IDE validation from flutter doctor (flutter#171924)
c205a4a 
Closes flutter#61246.

I open to doing this behind a flag, but given we decided already 5 years
ago to do this, I'm leaning limiting this to an announcement
(`flutter-announce@`) and just landing this cleanup.

Open to suggestions.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
@engine-flutter-autoroll
1c1f234 Remove IDE validation from flutter doctor (flutter/flutter#…
53c9dbe 
…171924)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@matanlurey @lucaantonelli
Remove IDE validation from flutter doctor (flutter#171924)
a3c581d 
Closes flutter#61246.

I open to doing this behind a flag, but given we decided already 5 years
ago to do this, I'm leaning limiting this to an announcement
(`flutter-announce@`) and just landing this cleanup.

Open to suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@jwren jwren jwren approved these changes

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter_tools] IDE plugin validators should be deprecated

4 participants

@matanlurey @reidbaker @jwren @bkonyi