Skip to content

Remove unsound artifacts, remove *Sound qualifier. #163015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Feb 12, 2025
Merged

Remove unsound artifacts, remove *Sound qualifier. #163015

auto-submit merged 5 commits into from
Feb 12, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Feb 10, 2025 •
edited
Loading

Towards #162846.

Removes all of the unsound host artifacts, and then uses their name for the sound artifacts.

That is, for something like webPlatformDDCKernelDill, this PR:

  • Changes the web GN builders to only emit the sound SDK, without the -sound suffixes
  • Deletes webPlatformDDCKernelDill and all usages of it (implicitly unsound, and unused).
  • Renames webPlatformDDCKernelSoundDill to webPlatformDDCKernelDill.

No user impact expected, as there was no way to use the unsound artifacts from the Flutter tool.

@matanlurey matanlurey requested review from bkonyi and srujzs February 10, 2025 20:21
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 10, 2025
srujzs
srujzs approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and the other PR, Matan!

packages/flutter_tools/lib/src/artifacts.dart Outdated
_getFlutterWebSdkPath(),
'kernel',
'amd',
'amd-sound',
Copy link
Contributor

@srujzs srujzs Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this may be already on your radar, but should we update the generation to exclude -sound instead?

https://github.com/flutter/flutter/blob/master/engine/src/flutter/web_sdk/BUILD.gn

Copy link
Contributor Author

@matanlurey matanlurey Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, I like that more. Let me tweak a bit.

Copy link
Contributor

@srujzs srujzs Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I suspect you'll need to change this as well: https://github.com/flutter/flutter/pull/163015/files#diff-61c1613dd65114f0da3272919ab539f69ea8c23b70826da644576b210c20c26aL272 (edited to point to the PR instead).

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Feb 10, 2025
@matanlurey
Copy link
Contributor Author

matanlurey commented Feb 10, 2025

Adding @eyebrowsoffire as this now changes the web SDK builders.

I suspect more changes might have to be made, but I'm less familiar with the web SDK so will let CI run at least once.

eyebrowsoffire
eyebrowsoffire approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for this change!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 12, 2025
Merged via the queue into flutter:master with commit b728c4c Feb 12, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
6a6e737 
…/flutter#163015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
b2161aa 
…/flutter#163015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
baba013 
…/flutter#163015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
3d70229 
…/flutter#163015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
2d35d53 
…/flutter#163015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
fa5c681 
…/flutter#163015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
b1bfec3 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
b3cccab 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
dad4b24 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
b76fd9e 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
44b8b43 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
07061fc 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
18d6e15 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
007fa5b 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
8a266b7 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
fa8fa0b 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
12b5536 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
05cd863 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
deece54 
…/flutter#163015)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) (#8614)
e9598f2 
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions)

flutter/flutter@892f9c1...e8f34a9

2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127)
2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109)
2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101)
2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100)
2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098)
2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834)
2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015)
2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547)
2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365)
2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014)
2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945)
2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103)
2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035)
2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855)
2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692)
2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060)
2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050)
2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024)
2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847)
2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944)
2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908)
2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913)
2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018)
2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021)
2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029)
2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495)
2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479)
2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004)
2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653)
2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017)
2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010)
2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917)
2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919)
2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774)
2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893)
2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998)
2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642)
2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238)
...
nshahan
nshahan reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matan! Just a drive by late review because I was curious what this change involved.

engine/src/flutter/web_sdk/BUILD.gn
":flutter_dartdevc_canvaskit_kernel_sdk_amd",
":flutter_dartdevc_canvaskit_kernel_sdk_sound_amd",
":flutter_dartdevc_canvaskit_kernel_sdk_sound_ddcLibraryBundle",
":flutter_dartdevc_canvaskit_kernel_sdk_amd",
Copy link
Contributor

@nshahan nshahan Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a duplicate.

engine/src/flutter/web_sdk/BUILD.gn
sources = get_target_outputs(":flutter_dartdevc_canvaskit_kernel_sdk_amd")
sources +=
get_target_outputs(":flutter_dartdevc_canvaskit_kernel_sdk_sound_amd")
sources += get_target_outputs(":flutter_dartdevc_canvaskit_kernel_sdk_amd")
Copy link
Contributor

@nshahan nshahan Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate here too.

@matanlurey
Copy link
Contributor Author

matanlurey commented Feb 19, 2025

Nice catch(es). I'll send you a PR.

@matanlurey matanlurey mentioned this pull request Feb 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2025
@matanlurey
Remove duplicate sources in the web_sdk. (#163636)
78d0f5f 
Post-submit feedback on #163015.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
3738fd1 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
dbcf49d 
…/flutter#163015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
b728c4c Remove unsound artifacts, remove *Sound qualifier. (flutter…
b1804aa 
…/flutter#163015)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) (flutter#8614)
7d8ee52 
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions)

flutter/flutter@892f9c1...e8f34a9

2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127)
2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109)
2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101)
2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100)
2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098)
2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834)
2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015)
2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547)
2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365)
2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014)
2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945)
2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103)
2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035)
2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855)
2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692)
2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060)
2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050)
2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024)
2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847)
2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944)
2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908)
2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913)
2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018)
2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021)
2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029)
2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495)
2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479)
2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004)
2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653)
2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017)
2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010)
2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917)
2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919)
2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774)
2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893)
2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998)
2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642)
2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) (flutter#8614)
baf9a15 
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions)

flutter/flutter@892f9c1...e8f34a9

2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127)
2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109)
2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101)
2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100)
2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098)
2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834)
2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015)
2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547)
2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365)
2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014)
2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945)
2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103)
2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035)
2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855)
2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692)
2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060)
2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050)
2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024)
2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847)
2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944)
2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908)
2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913)
2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018)
2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021)
2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029)
2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495)
2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479)
2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004)
2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653)
2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017)
2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010)
2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917)
2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919)
2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774)
2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893)
2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998)
2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642)
2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshahan nshahan nshahan left review comments

@srujzs srujzs srujzs approved these changes

@bkonyi bkonyi bkonyi approved these changes

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matanlurey @nshahan @bkonyi @eyebrowsoffire @srujzs