Skip to content

Adds dialog and alertdialog role #162692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 10 commits into from
Feb 11, 2025
Merged

Adds dialog and alertdialog role #162692

auto-submit merged 10 commits into from
Feb 11, 2025

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Feb 4, 2025

fixes #162124
fixes #157207
fixes #157204

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. platform-web Web applications specifically labels Feb 4, 2025
kevmoo
kevmoo reviewed Feb 5, 2025
View reviewed changes
@chunhtai chunhtai marked this pull request as ready for review February 6, 2025 19:16
yjbanov
yjbanov reviewed Feb 6, 2025
View reviewed changes
engine/src/flutter/lib/web_ui/lib/src/engine/semantics/dialogs.dart Outdated
/// reader better understand this section of screen.
///
/// Screen-readers takes advantage of "aria-label" to describe the visual.
class SemanticDialog extends SemanticRole with RouteLike {
Copy link
Contributor

@yjbanov yjbanov Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be simpler to maintain all route semantics in the same file, route.dart. WDYT?

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/dialogs.dart Outdated
import 'semantics.dart';
import 'route.dart';

/// Indicates the container as a pop dialog
Copy link
Contributor

@yjbanov yjbanov Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end with a period.

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/dialogs.dart Outdated
/// Setting this role will also set aria-modal to true, which helps screen
/// reader better understand this section of screen.
///
/// Screen-readers takes advantage of "aria-label" to describe the visual.
Copy link
Contributor

@yjbanov yjbanov Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/takes/take/

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/dialogs.dart Outdated
/// Setting this role will also set aria-modal to true, which helps screen
/// reader better understand this section of screen.
///
/// Screen-readers takes advantage of "aria-label" to describe the visual.
Copy link
Contributor

@yjbanov yjbanov Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The situation with labeling is a bit more complicated, what with all the namesRoute. Just mentioning aria-label alone may be a bit misleading.

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/route.dart Outdated
import '../semantics.dart';
import '../util.dart';

mixin RouteLike on SemanticRole {
Copy link
Contributor

@yjbanov yjbanov Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like all our route types are expressible using a simple class hierarchy:

class SemanticRouteBase extends SemanticRole;
class SemanticRoute extends SemanticRouteBase;
class SemanticDialog extends SemanticRouteBase;
class SemanticAlertDialog extends SemanticRouteBase;

engine/src/flutter/lib/web_ui/test/engine/semantics/semantics_test.dart Outdated
group('tabs', () {
_testTabs();
});
group('dialogs', () {
Copy link
Contributor

@yjbanov yjbanov Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd either put this into the existing 'route' group (see comment about combining all routes into the same library), or put it next to the 'route' group since the two a closely related.

engine/src/flutter/lib/web_ui/test/engine/semantics/semantics_test.dart Outdated
});
}

void _testDialogs() {
Copy link
Contributor

@yjbanov yjbanov Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving into/closer to the route tests.

packages/flutter/lib/src/material/dialog.dart Outdated
child: dialogChild,
return Semantics(
role: SemanticsRole.alertDialog,
child: Dialog(
Copy link
Contributor

@yjbanov yjbanov Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid having two roles set on the dialog that need to be resolve by merging or something, can we instead have the Dialog constructor take an optional semanticsRole argument (similar to semanticLabel that many of our widgets accept):

Dialog({
  SemanticsRole semanticRole = SemanticsRole.dialog,
  ... other args ...
});

@chunhtai chunhtai requested a review from yjbanov February 10, 2025 19:34
yjbanov
yjbanov reviewed Feb 10, 2025
View reviewed changes
engine/src/flutter/lib/web_ui/lib/src/engine/semantics/route.dart Outdated
class SemanticRoute extends SemanticRole {
SemanticRoute(SemanticsObject semanticsObject)
: super.blank(EngineSemanticsRole.route, semanticsObject) {
class SemanticRoutBase extends SemanticRole {
Copy link
Contributor

@yjbanov yjbanov Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Rout/Route/

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/route.dart Outdated

/// Denotes that all descendant nodes are inside a route.
///
/// Routes can include dialogs, pop-up menus, sub-screens, and more.
Copy link
Contributor

@yjbanov yjbanov Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This role is no longer used for dialogs, correct?

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/route.dart Outdated
SemanticRoute(SemanticsObject semanticsObject)
: super.blank(EngineSemanticsRole.route, semanticsObject) {
class SemanticRoutBase extends SemanticRole {
SemanticRoutBase(EngineSemanticsRole kind, SemanticsObject object) : super.blank(kind, object) {
Copy link
Contributor

@yjbanov yjbanov Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class seems to hard-code "dialog" ARIA. Should we use different ARIA roles for different types of routes? E.g. the SemanticAlertDialog could use https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/alertdialog_role

Copy link
Contributor Author

@chunhtai chunhtai Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like i missed this when i refactored, will fix

@chunhtai chunhtai requested a review from yjbanov February 10, 2025 22:55
yjbanov
yjbanov approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/route.dart Outdated
///
/// See also:
///
/// * [RouteName], which provides a description for this route in the absent
Copy link
Contributor

@yjbanov yjbanov Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/absent/absence/

Copy link
Contributor Author

@chunhtai chunhtai Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, for some reason my ide told me absence is wrong, but it is not. will fix

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
c2c53d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
b8962e9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
ef4a2e5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
c4063c4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
11dca31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
57f2b14
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
2ed55d8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
78744b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
7ef4b2a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
9c4e915
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
59efbfb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
f2e820b
@Piinks Piinks mentioned this pull request Feb 14, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
c640f10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
253f3e4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
94d4fe7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
48e2b5f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
8c57c64
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
3e3342b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
4472d1f
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) (#8614)
e9598f2 
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions)

flutter/flutter@892f9c1...e8f34a9

2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127)
2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109)
2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101)
2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100)
2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098)
2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834)
2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015)
2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547)
2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365)
2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014)
2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945)
2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103)
2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035)
2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855)
2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692)
2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060)
2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050)
2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024)
2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847)
2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944)
2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908)
2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913)
2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018)
2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021)
2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029)
2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495)
2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479)
2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004)
2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653)
2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017)
2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010)
2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917)
2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919)
2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774)
2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893)
2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998)
2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642)
2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
fb8a893
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
e90baad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
21471aa Adds dialog and alertdialog role (flutter/flutter#162692)
52e1469
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) (flutter#8614)
7d8ee52 
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions)

flutter/flutter@892f9c1...e8f34a9

2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127)
2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109)
2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101)
2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100)
2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098)
2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834)
2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015)
2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547)
2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365)
2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014)
2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945)
2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103)
2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035)
2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855)
2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692)
2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060)
2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050)
2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024)
2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847)
2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944)
2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908)
2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913)
2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018)
2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021)
2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029)
2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495)
2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479)
2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004)
2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653)
2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017)
2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010)
2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917)
2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919)
2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774)
2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893)
2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998)
2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642)
2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) (flutter#8614)
baf9a15 
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions)

flutter/flutter@892f9c1...e8f34a9

2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127)
2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109)
2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101)
2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066)
2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100)
2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098)
2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834)
2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015)
2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547)
2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365)
2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014)
2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945)
2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103)
2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035)
2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855)
2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549)
2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692)
2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060)
2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050)
2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054)
2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024)
2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847)
2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944)
2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908)
2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913)
2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018)
2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021)
2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029)
2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495)
2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479)
2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004)
2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653)
2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017)
2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010)
2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917)
2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919)
2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774)
2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893)
2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998)
2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642)
2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

@kevmoo kevmoo Awaiting requested review from kevmoo

@hannah-hyj hannah-hyj Awaiting requested review from hannah-hyj

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

3 participants

@chunhtai @kevmoo @yjbanov