Fix Linux keyboard support for AltGr #162495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously connected to right alt, which was confusing the keyboard handling code into generating up events for this key when it didn't match the expected values. This key is also configurable, and only defaults to right alt in Ubuntu/GNOME. Fixes flutter#154053
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
Author
|
I'm not too familiar with the keyboard code; should/can this have a test? |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
approved these changes
Feb 11, 2025
Contributor
matanlurey
left a comment
There was a problem hiding this comment.
LGTM. A test would be testing that the keycode generator tool works, which seems not particularly useful.
A useful test, if you wanted to write one (not necessarily in this PR) could be launcing the Linux embedder, and sending keystrokes to it, and observing Flutter interprets them as expected.
Contributor
|
@robert-ancell As mentioned #162715 and on Discord, please use "Autosubmit", not "Add to Merge Queue". |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 17, 2025
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) flutter/flutter@892f9c1...e8f34a9 2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127) 2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109) 2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101) 2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100) 2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098) 2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834) 2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015) 2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547) 2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365) 2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014) 2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945) 2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103) 2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035) 2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855) 2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692) 2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060) 2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050) 2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024) 2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847) 2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944) 2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908) 2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913) 2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018) 2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021) 2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029) 2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495) 2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479) 2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004) 2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653) 2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017) 2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010) 2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917) 2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919) 2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774) 2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893) 2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998) 2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642) 2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) flutter/flutter@892f9c1...e8f34a9 2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127) 2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109) 2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101) 2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100) 2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098) 2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834) 2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015) 2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547) 2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365) 2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014) 2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945) 2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103) 2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035) 2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855) 2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692) 2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060) 2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050) 2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024) 2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847) 2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944) 2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908) 2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913) 2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018) 2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021) 2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029) 2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495) 2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479) 2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004) 2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653) 2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017) 2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010) 2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917) 2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919) 2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774) 2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893) 2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998) 2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642) 2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238) ...
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) flutter/flutter@892f9c1...e8f34a9 2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127) 2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109) 2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101) 2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100) 2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098) 2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834) 2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015) 2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547) 2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365) 2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014) 2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945) 2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103) 2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035) 2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855) 2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692) 2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060) 2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050) 2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024) 2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847) 2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944) 2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908) 2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913) 2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018) 2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021) 2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029) 2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495) 2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479) 2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004) 2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653) 2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017) 2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010) 2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917) 2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919) 2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774) 2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893) 2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998) 2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642) 2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously connected to right alt, which was confusing the keyboard handling code into generating up events for this key when it didn't match the expected values. This key is also configurable, and only defaults to right alt in Ubuntu/GNOME.
Fixes #154053