Skip to content

Exclude the top-level engine directory from generate_gradle_lockfiles. #161635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matanlurey merged 2 commits into from
Jan 15, 2025
Merged

Exclude the top-level engine directory from generate_gradle_lockfiles. #161635

matanlurey merged 2 commits into from
Jan 15, 2025
+68 −1

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Jan 15, 2025

For local development workflows, this would find directories we don't want included in the script.

Added a simple test.

gmackall
gmackall approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matanlurey matanlurey added this pull request to the merge queue Jan 15, 2025
Merged via the queue into flutter:master with commit fd1c02d Jan 15, 2025
173 checks passed
@matanlurey matanlurey deleted the exclude-engine-generate_gradle_lockfiles branch January 15, 2025 03:45
maheshj01 pushed a commit to maheshj01/flutter that referenced this pull request Jan 15, 2025
@matanlurey @maheshj01
Exclude the top-level engine directory from `generate_gradle_lockfi…
9ca8845 
…les`. (flutter#161635)

For local development workflows, this would find directories we don't
want included in the script.

Added a simple test.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
48d571b 
…e_lockfiles`. (flutter/flutter#161635)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
f487490 
…e_lockfiles`. (flutter/flutter#161635)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
9fb83c4 
…e_lockfiles`. (flutter/flutter#161635)
This was referenced Jan 16, 2025
Merged
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
3e74724 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
a26a4f9 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
c8b4493 
…e_lockfiles`. (flutter/flutter#161635)
This was referenced Jan 16, 2025
Closed
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
7a173d1 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
3400274 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
18501d5 
…e_lockfiles`. (flutter/flutter#161635)
This was referenced Jan 16, 2025
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
55e1578 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
3935224 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
04bb494 
…e_lockfiles`. (flutter/flutter#161635)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (#8441)
973e8b5 
flutter/flutter@40c2b86...5517cc9

2025-01-15 37028599+EArminjon@users.noreply.github.com feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161680)
2025-01-15 jacob.simionato@gmail.com Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 stuartmorgan@google.com Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 flar@google.com [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 engine-flutter-autoroll@skia.org Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 bruno.leroux@gmail.com Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 jason-simmons@users.noreply.github.com Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 tessertaha@gmail.com Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161643)
2025-01-15 matanlurey@users.noreply.github.com Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161632)
2025-01-15 matanlurey@users.noreply.github.com Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 jonahwilliams@google.com [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 nabilamevia2003@gmail.com Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 jessiewong401@gmail.com Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 goderbauer@google.com Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 34871572+gmackall@users.noreply.github.com Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 devoncarew@google.com [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 flar@google.com [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 dkwingsmt@users.noreply.github.com [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 737941+loic-sharma@users.noreply.github.com [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 jonahwilliams@google.com [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 goderbauer@google.com Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 goderbauer@google.com Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 43054281+camsim99@users.noreply.github.com [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 bkonyi@google.com Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@matanlurey matanlurey mentioned this pull request Jan 16, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
25211e1 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
89b3efe 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
03bc534 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
a7f32d0 
…e_lockfiles`. (flutter/flutter#161635)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
fd1c02d Exclude the top-level engine directory from `generate_gradl…
c614b5c 
…e_lockfiles`. (flutter/flutter#161635)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter#8441)
14e9b88 
flutter/flutter@40c2b86...5517cc9

2025-01-15 37028599+EArminjon@users.noreply.github.com feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161680)
2025-01-15 jacob.simionato@gmail.com Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 stuartmorgan@google.com Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 flar@google.com [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 engine-flutter-autoroll@skia.org Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 bruno.leroux@gmail.com Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 jason-simmons@users.noreply.github.com Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 tessertaha@gmail.com Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161643)
2025-01-15 matanlurey@users.noreply.github.com Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161632)
2025-01-15 matanlurey@users.noreply.github.com Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 jonahwilliams@google.com [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 nabilamevia2003@gmail.com Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 jessiewong401@gmail.com Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 goderbauer@google.com Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 34871572+gmackall@users.noreply.github.com Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 devoncarew@google.com [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 flar@google.com [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 dkwingsmt@users.noreply.github.com [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 737941+loic-sharma@users.noreply.github.com [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 jonahwilliams@google.com [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 goderbauer@google.com Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 goderbauer@google.com Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 43054281+camsim99@users.noreply.github.com [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 bkonyi@google.com Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter#8441)
84ee9b4 
flutter/flutter@40c2b86...5517cc9

2025-01-15 37028599+EArminjon@users.noreply.github.com feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161680)
2025-01-15 jacob.simionato@gmail.com Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 stuartmorgan@google.com Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 flar@google.com [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 engine-flutter-autoroll@skia.org Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 bruno.leroux@gmail.com Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 jason-simmons@users.noreply.github.com Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 tessertaha@gmail.com Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161643)
2025-01-15 matanlurey@users.noreply.github.com Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161632)
2025-01-15 matanlurey@users.noreply.github.com Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 jonahwilliams@google.com [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 nabilamevia2003@gmail.com Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 jessiewong401@gmail.com Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 goderbauer@google.com Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 34871572+gmackall@users.noreply.github.com Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 devoncarew@google.com [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 flar@google.com [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 dkwingsmt@users.noreply.github.com [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 737941+loic-sharma@users.noreply.github.com [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 jonahwilliams@google.com [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 goderbauer@google.com Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 goderbauer@google.com Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 43054281+camsim99@users.noreply.github.com [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 bkonyi@google.com Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey @gmackall