Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml #161622

gmackall · 2025-01-14T22:30:09Z

The test was intentionally broken by #160947. That PR removed the CI configuration to run the test, but the autoroller (which was previously turned off) runs a gradle command in all android subdirectories, so the fact that the directory wasn't deleted is blocking turning the autoroller back on:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8725731612391969937/+/u/run_roll-packages_script/stdout

[stderr] * What went wrong:
[stderr] A problem occurred evaluating script.
[stderr] > You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is not possible anymore. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/to/flutter-gradle-plugin-apply

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…kfile_exclusion.yaml

goderbauer

LGTM

gmackall · 2025-01-14T22:32:50Z

Looks like me editing labels at the same time somehow removed one - re added

…om lockfile exclusion yaml (flutter#161622) The test was intentionally broken by flutter#160947. That PR removed the CI configuration to run the test, but the autoroller (which was previously turned off) runs a gradle command in all android subdirectories, so the fact that the directory wasn't deleted is blocking turning the autoroller back on: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8725731612391969937/+/u/run_roll-packages_script/stdout ``` [stderr] * What went wrong: [stderr] A problem occurred evaluating script. [stderr] > You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is not possible anymore. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/to/flutter-gradle-plugin-apply ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Gray Mackall <mackall@google.com>

…rence from lockfile exclusion yaml (flutter/flutter#161622)

flutter/flutter@40c2b86...5517cc9 2025-01-15 37028599+EArminjon@users.noreply.github.com feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580) 2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161680) 2025-01-15 jacob.simionato@gmail.com Revert "Autocomplete Options Width" (flutter/flutter#161666) 2025-01-15 stuartmorgan@google.com Update two_dimensional_scrollables triage routing (flutter/flutter#161667) 2025-01-15 flar@google.com [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652) 2025-01-15 engine-flutter-autoroll@skia.org Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672) 2025-01-15 bruno.leroux@gmail.com Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427) 2025-01-15 jason-simmons@users.noreply.github.com Manual roll of Skia to e7b8d078851f (flutter/flutter#161609) 2025-01-15 tessertaha@gmail.com Fix `TabBar` glitchy elastic `Tab` animation (flutter/flutter#161514) 2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161643) 2025-01-15 matanlurey@users.noreply.github.com Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635) 2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161632) 2025-01-15 matanlurey@users.noreply.github.com Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534) 2025-01-15 jonahwilliams@google.com [Impeller] null check device buffer in image encoding. (flutter/flutter#161194) 2025-01-15 nabilamevia2003@gmail.com Feature/twitter keyboard (flutter/flutter#161025) 2025-01-15 jessiewong401@gmail.com Fixed XiaoMi statusBar Bug (flutter/flutter#161271) 2025-01-15 goderbauer@google.com Clean up engine's analysis_options.yaml (flutter/flutter#161554) 2025-01-14 34871572+gmackall@users.noreply.github.com Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622) 2025-01-14 devoncarew@google.com [deps] remove no-longer-used repo deps (flutter/flutter#161605) 2025-01-14 flar@google.com [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553) 2025-01-14 dkwingsmt@users.noreply.github.com [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409) 2025-01-14 737941+loic-sharma@users.noreply.github.com [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464) 2025-01-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix GIF decode failure (flutter/flutter#161536) 2025-01-14 jonahwilliams@google.com [Impeller] fixes for AHB swapchains. (flutter/flutter#161562) 2025-01-14 goderbauer@google.com Last Engine<>Framework lint sync (flutter/flutter#161560) 2025-01-14 goderbauer@google.com Check that localization files of stocks app are up-to-date (flutter/flutter#161608) 2025-01-14 43054281+camsim99@users.noreply.github.com [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343) 2025-01-14 bkonyi@google.com Update package revisions to latest (flutter/flutter#161525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rence from lockfile exclusion yaml (flutter/flutter#161622)

flutter/flutter@40c2b86...5517cc9 2025-01-15 37028599+EArminjon@users.noreply.github.com feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580) 2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161680) 2025-01-15 jacob.simionato@gmail.com Revert "Autocomplete Options Width" (flutter/flutter#161666) 2025-01-15 stuartmorgan@google.com Update two_dimensional_scrollables triage routing (flutter/flutter#161667) 2025-01-15 flar@google.com [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652) 2025-01-15 engine-flutter-autoroll@skia.org Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672) 2025-01-15 bruno.leroux@gmail.com Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427) 2025-01-15 jason-simmons@users.noreply.github.com Manual roll of Skia to e7b8d078851f (flutter/flutter#161609) 2025-01-15 tessertaha@gmail.com Fix `TabBar` glitchy elastic `Tab` animation (flutter/flutter#161514) 2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161643) 2025-01-15 matanlurey@users.noreply.github.com Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635) 2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161632) 2025-01-15 matanlurey@users.noreply.github.com Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534) 2025-01-15 jonahwilliams@google.com [Impeller] null check device buffer in image encoding. (flutter/flutter#161194) 2025-01-15 nabilamevia2003@gmail.com Feature/twitter keyboard (flutter/flutter#161025) 2025-01-15 jessiewong401@gmail.com Fixed XiaoMi statusBar Bug (flutter/flutter#161271) 2025-01-15 goderbauer@google.com Clean up engine's analysis_options.yaml (flutter/flutter#161554) 2025-01-14 34871572+gmackall@users.noreply.github.com Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622) 2025-01-14 devoncarew@google.com [deps] remove no-longer-used repo deps (flutter/flutter#161605) 2025-01-14 flar@google.com [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553) 2025-01-14 dkwingsmt@users.noreply.github.com [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409) 2025-01-14 737941+loic-sharma@users.noreply.github.com [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464) 2025-01-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix GIF decode failure (flutter/flutter#161536) 2025-01-14 jonahwilliams@google.com [Impeller] fixes for AHB swapchains. (flutter/flutter#161562) 2025-01-14 goderbauer@google.com Last Engine<>Framework lint sync (flutter/flutter#161560) 2025-01-14 goderbauer@google.com Check that localization files of stocks app are up-to-date (flutter/flutter#161608) 2025-01-14 43054281+camsim99@users.noreply.github.com [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343) 2025-01-14 bkonyi@google.com Update package revisions to latest (flutter/flutter#161525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

remove gradle_deprecated_settings_test, and remove reference from loc…

9c87f41

…kfile_exclusion.yaml

gmackall requested review from a team, bartekpacia and goderbauer January 14, 2025 22:30

gmackall marked this pull request as ready for review January 14, 2025 22:30

gmackall changed the title ~~Remove gradle_deprecated_settings_test, and remove reference from lockfile exclusion yaml~~ Remove gradle_deprecated_settings test app, and remove reference from lockfile exclusion yaml Jan 14, 2025

goderbauer approved these changes Jan 14, 2025

View reviewed changes

goderbauer added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Jan 14, 2025

gmackall added warning: land on red to fix tree breakage and removed warning: land on red to fix tree breakage labels Jan 14, 2025

goderbauer added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Jan 14, 2025

goderbauer enabled auto-merge January 14, 2025 22:38

bartekpacia approved these changes Jan 14, 2025

View reviewed changes

goderbauer added this pull request to the merge queue Jan 14, 2025

jtmcdole mentioned this pull request Jan 14, 2025

Check that localization files of stocks app are up-to-date #161608

Merged

Merged via the queue into flutter:master with commit b318990 Jan 14, 2025
175 of 177 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 2b34d78c2331 (20 revisions) flutter/packages#8435

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

1606d86

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 44ff2f59774b (22 revisions) flutter/packages#8436

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

43bcdde

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 1580a3d3fbe7 (23 revisions) flutter/packages#8437

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

60ca390

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

5df7f69

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

1951c30

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

b88db9f

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

ad457ac

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

b3962be

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

7979dd1

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

3409157

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

a8c078b

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

11ce582

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

3db8379

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

ef6047b

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

051251f

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

c4946a3

…rence from lockfile exclusion yaml (flutter/flutter#161622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

b318990 Remove gradle_deprecated_settings test app, and remove refe…

66d9ecb

…rence from lockfile exclusion yaml (flutter/flutter#161622)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml #161622

Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml #161622

gmackall commented Jan 14, 2025 •

edited

Loading

Uh oh!

goderbauer left a comment

Uh oh!

gmackall commented Jan 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove gradle_deprecated_settings test app, and remove reference from lockfile exclusion yaml #161622

Remove gradle_deprecated_settings test app, and remove reference from lockfile exclusion yaml #161622

Conversation

gmackall commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

gmackall commented Jan 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml #161622

Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml #161622

gmackall commented Jan 14, 2025 •

edited

Loading