Skip to content

[Impeller] fixes for AHB swapchains. #161562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Jan 14, 2025
Merged

[Impeller] fixes for AHB swapchains. #161562

auto-submit merged 4 commits into from
Jan 14, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jan 13, 2025 •
edited
Loading

Fixes for a variety of speculative fixes for AHB swapchain issues. Details TBD while some tests run...

  1. Even If the SurfaceControl API is supported, there is no guarantee that we can import the AHB as there may be a mismatch in the required memory properties and what is available. Add a validity check to the texture pool and bail from the swapchain if any are invalid.

  2. Rather than submitting a dummy cmd buffer that does a layout transition, use the final command buffer signal semaphore.

  3. Import the render ready semaphore and use it to block the onscreen command buffer.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 13, 2025
@jonahwilliams jonahwilliams marked this pull request as ready for review January 14, 2025 00:08
@jonahwilliams jonahwilliams requested review from chinmaygarde and matanlurey and removed request for matanlurey January 14, 2025 00:09
matanlurey
matanlurey approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rSLGTM.

I think this could be tested but since it's not enabled yet I'm willing to call this an "experiment".

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 14, 2025
Merged via the queue into flutter:master with commit 80942d5 Jan 14, 2025
180 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025
maheshj01 pushed a commit to maheshj01/flutter that referenced this pull request Jan 15, 2025
@maheshj01
[Impeller] fixes for AHB swapchains. (flutter#161562)
d0a6c6c 
Fixes for a variety of speculative fixes for AHB swapchain issues.
Details TBD while some tests run...


1. Even If the SurfaceControl API is supported, there is no guarantee
that we can import the AHB as there may be a mismatch in the required
memory properties and what is available. Add a validity check to the
texture pool and bail from the swapchain if any are invalid.

2. Rather than submitting a dummy cmd buffer that does a layout
transition, use the final command buffer signal semaphore.

3. Import the render ready semaphore and use it to block the onscreen
command buffer.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
ea171a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
f05d03d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
f551e6e
This was referenced Jan 16, 2025
Merged
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
c25017a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
9f2ced6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
4ce3c2b
This was referenced Jan 16, 2025
Closed
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
7d776be
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
af92311
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
4f3fff1
This was referenced Jan 16, 2025
Closed
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
fe8103b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
1edb6ef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
a8c3eca
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (#8441)
973e8b5 
flutter/flutter@40c2b86...5517cc9

2025-01-15 37028599+EArminjon@users.noreply.github.com feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161680)
2025-01-15 jacob.simionato@gmail.com Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 stuartmorgan@google.com Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 flar@google.com [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 engine-flutter-autoroll@skia.org Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 bruno.leroux@gmail.com Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 jason-simmons@users.noreply.github.com Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 tessertaha@gmail.com Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161643)
2025-01-15 matanlurey@users.noreply.github.com Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161632)
2025-01-15 matanlurey@users.noreply.github.com Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 jonahwilliams@google.com [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 nabilamevia2003@gmail.com Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 jessiewong401@gmail.com Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 goderbauer@google.com Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 34871572+gmackall@users.noreply.github.com Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 devoncarew@google.com [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 flar@google.com [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 dkwingsmt@users.noreply.github.com [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 737941+loic-sharma@users.noreply.github.com [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 jonahwilliams@google.com [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 goderbauer@google.com Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 goderbauer@google.com Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 43054281+camsim99@users.noreply.github.com [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 bkonyi@google.com Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
7baafef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
77e3c0e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
b43b3b0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2db2ec5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
80942d5 [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
bbd2080
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter#8441)
14e9b88 
flutter/flutter@40c2b86...5517cc9

2025-01-15 37028599+EArminjon@users.noreply.github.com feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161680)
2025-01-15 jacob.simionato@gmail.com Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 stuartmorgan@google.com Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 flar@google.com [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 engine-flutter-autoroll@skia.org Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 bruno.leroux@gmail.com Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 jason-simmons@users.noreply.github.com Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 tessertaha@gmail.com Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161643)
2025-01-15 matanlurey@users.noreply.github.com Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161632)
2025-01-15 matanlurey@users.noreply.github.com Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 jonahwilliams@google.com [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 nabilamevia2003@gmail.com Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 jessiewong401@gmail.com Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 goderbauer@google.com Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 34871572+gmackall@users.noreply.github.com Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 devoncarew@google.com [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 flar@google.com [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 dkwingsmt@users.noreply.github.com [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 737941+loic-sharma@users.noreply.github.com [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 jonahwilliams@google.com [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 goderbauer@google.com Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 goderbauer@google.com Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 43054281+camsim99@users.noreply.github.com [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 bkonyi@google.com Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter#8441)
84ee9b4 
flutter/flutter@40c2b86...5517cc9

2025-01-15 37028599+EArminjon@users.noreply.github.com feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161680)
2025-01-15 jacob.simionato@gmail.com Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 stuartmorgan@google.com Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 flar@google.com [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 engine-flutter-autoroll@skia.org Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 bruno.leroux@gmail.com Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 jason-simmons@users.noreply.github.com Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 tessertaha@gmail.com Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161643)
2025-01-15 matanlurey@users.noreply.github.com Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161632)
2025-01-15 matanlurey@users.noreply.github.com Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 jonahwilliams@google.com [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 nabilamevia2003@gmail.com Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 jessiewong401@gmail.com Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 goderbauer@google.com Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 34871572+gmackall@users.noreply.github.com Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 devoncarew@google.com [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 flar@google.com [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 dkwingsmt@users.noreply.github.com [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 737941+loic-sharma@users.noreply.github.com [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 jonahwilliams@google.com [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 goderbauer@google.com Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 goderbauer@google.com Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 43054281+camsim99@users.noreply.github.com [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 bkonyi@google.com Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @matanlurey