Skip to content

Conversation

@flar
Copy link
Contributor

@flar flar commented Dec 21, 2023

The PR is breaking the flutter_test_performance test and making the tree red.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Dec 21, 2023
@mraleph mraleph self-requested a review December 21, 2023 11:44
@mraleph mraleph added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2023
@mraleph mraleph merged commit 8407dd2 into master Dec 21, 2023
@mraleph mraleph deleted the revert-138057-implement-4 branch December 21, 2023 11:44
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 21, 2023
flutter/flutter@da0cd69...11def8e

2023-12-21 mit@google.com Update README.md (flutter/flutter#140382)
2023-12-21 flar@google.com Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502)
2023-12-21 polinach@google.com Integrate testWidgets with leak tracking. (flutter/flutter#138057)
2023-12-21 36861262+QuncCccccc@users.noreply.github.com Fix import pattern (flutter/flutter#140425)
2023-12-20 godofredoc@google.com Update job permissions (flutter/flutter#140476)
2023-12-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#140472)
2023-12-20 goderbauer@google.com Remove outdated ignores from tool (flutter/flutter#140467)
2023-12-20 goderbauer@google.com Remove outdated ignores from framework (flutter/flutter#140465)
2023-12-20 31859944+LongCatIsLooong@users.noreply.github.com Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469)
2023-12-20 reidbaker@google.com Part 1/n migration steps for kotlin migration (flutter/flutter#140452)
2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468)
2023-12-20 1961493+harryterkelsen@users.noreply.github.com [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462)
2023-12-20 chris@bracken.jp Eliminate Cirrus build status badge (flutter/flutter#140461)
2023-12-20 zanderso@users.noreply.github.com Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438)
2023-12-20 engine-flutter-autoroll@skia.org Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450)
2023-12-20 leroux_bruno@yahoo.fr _TabBarViewState should not recreate page controller (flutter/flutter#135500)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@polina-c polina-c restored the revert-138057-implement-4 branch December 21, 2023 20:50
@polina-c polina-c deleted the revert-138057-implement-4 branch December 21, 2023 20:50
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
…lutter#140502)

The PR is breaking the `flutter_test_performance` test and making the
tree red.
auto-submit bot added a commit that referenced this pull request Jan 3, 2024
Reverts #140521
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Original PR: #138057
Revert: #140502
Issue: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_test_performance/12787/overview
Exception: flutter test rendered unexpected output (1 bad lines)
Explanation: leak tracker adds tear down even when there is no leak tracking, because at the moment of adding tear down it is unclear if leak tracking will be used for some tests.
Fix: add enabling flag for leak tracker and make creation of tear down conditional.
Prerequisites:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants