-
Notifications
You must be signed in to change notification settings - Fork 29.8k
[web] Re-enable test now that source of flakiness is fixed #140462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
harryterkelsen
merged 1 commit into
flutter:master
from
harryterkelsen:reenable-text-field-test-canvaskit
Dec 20, 2023
Merged
[web] Re-enable test now that source of flakiness is fixed #140462
harryterkelsen
merged 1 commit into
flutter:master
from
harryterkelsen:reenable-text-field-test-canvaskit
Dec 20, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Dec 20, 2023
Contributor
yjbanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 21, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 21, 2023
flutter/flutter@da0cd69...11def8e 2023-12-21 mit@google.com Update README.md (flutter/flutter#140382) 2023-12-21 flar@google.com Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502) 2023-12-21 polinach@google.com Integrate testWidgets with leak tracking. (flutter/flutter#138057) 2023-12-21 36861262+QuncCccccc@users.noreply.github.com Fix import pattern (flutter/flutter#140425) 2023-12-20 godofredoc@google.com Update job permissions (flutter/flutter#140476) 2023-12-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#140472) 2023-12-20 goderbauer@google.com Remove outdated ignores from tool (flutter/flutter#140467) 2023-12-20 goderbauer@google.com Remove outdated ignores from framework (flutter/flutter#140465) 2023-12-20 31859944+LongCatIsLooong@users.noreply.github.com Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469) 2023-12-20 reidbaker@google.com Part 1/n migration steps for kotlin migration (flutter/flutter#140452) 2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468) 2023-12-20 1961493+harryterkelsen@users.noreply.github.com [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462) 2023-12-20 chris@bracken.jp Eliminate Cirrus build status badge (flutter/flutter#140461) 2023-12-20 zanderso@users.noreply.github.com Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438) 2023-12-20 engine-flutter-autoroll@skia.org Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450) 2023-12-20 leroux_bruno@yahoo.fr _TabBarViewState should not recreate page controller (flutter/flutter#135500) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
added a commit
that referenced
this pull request
Dec 21, 2023
…140515) Reverts #140462 Initiated by: cbracken This change reverts the following previous change: Original Description: The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214 Fixes #137669 As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…40462) The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214 Fixes flutter#137669 As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140515) Reverts flutter#140462 Initiated by: cbracken This change reverts the following previous change: Original Description: The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214 Fixes flutter#137669 As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: text input
Entering text in a text field or keyboard related problems
f: cupertino
flutter/packages/flutter/cupertino repository
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214
Fixes #137669
As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.