Integrate testWidgets with leak tracking. #138057

polina-c · 2023-11-08T04:34:38Z

Contributes to: #135856

TODO:

Publish new leak tracker API
leak_tracker_flutter_testing should be refreshed in G3 (cl/590382409)
Upgrade flutter to new leak_tracker_flutter_testing
G3fix that adds leak_tracker_flutter_testing as dependency of testWidgets, should be added to this PR (cl/580728987)
Fix failing tests

This reverts commit 78fea14.

…dep-1

…param-3

auto-submit · 2023-12-20T23:09:03Z

auto label is removed for flutter/flutter/138057, due to - The status or check suite Windows build_tests_7_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux fuchsia_precache has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux firebase_android_embedding_v2_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux docs_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_3_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

polina-c · 2023-12-20T23:43:10Z

g3 passed: https://critique.corp.google.com/cl/592664397
refreshing branch and setting next g3 to skip

flar · 2023-12-21T08:14:40Z

This change is causing the flutter_test_performance task to fail due to a new unexpected line in the test output that it treats as an error.

This reverts commit d746007.

The PR is breaking the `flutter_test_performance` test and making the tree red.

…8057)

flutter/flutter@da0cd69...11def8e 2023-12-21 mit@google.com Update README.md (flutter/flutter#140382) 2023-12-21 flar@google.com Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502) 2023-12-21 polinach@google.com Integrate testWidgets with leak tracking. (flutter/flutter#138057) 2023-12-21 36861262+QuncCccccc@users.noreply.github.com Fix import pattern (flutter/flutter#140425) 2023-12-20 godofredoc@google.com Update job permissions (flutter/flutter#140476) 2023-12-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#140472) 2023-12-20 goderbauer@google.com Remove outdated ignores from tool (flutter/flutter#140467) 2023-12-20 goderbauer@google.com Remove outdated ignores from framework (flutter/flutter#140465) 2023-12-20 31859944+LongCatIsLooong@users.noreply.github.com Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469) 2023-12-20 reidbaker@google.com Part 1/n migration steps for kotlin migration (flutter/flutter#140452) 2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468) 2023-12-20 1961493+harryterkelsen@users.noreply.github.com [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462) 2023-12-20 chris@bracken.jp Eliminate Cirrus build status badge (flutter/flutter#140461) 2023-12-20 zanderso@users.noreply.github.com Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438) 2023-12-20 engine-flutter-autoroll@skia.org Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450) 2023-12-20 leroux_bruno@yahoo.fr _TabBarViewState should not recreate page controller (flutter/flutter#135500) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Contributes to: flutter#135856 TODO:

…lutter#140502) The PR is breaking the `flutter_test_performance` test and making the tree red.

Reverts #140521 Initiated by: zanderso This change reverts the following previous change: Original Description: Original PR: #138057 Revert: #140502 Issue: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_test_performance/12787/overview Exception: flutter test rendered unexpected output (1 bad lines) Explanation: leak tracker adds tear down even when there is no leak tracking, because at the moment of adding tear down it is unclear if leak tracking will be used for some tests. Fix: add enabling flag for leak tracker and make creation of tear down conditional. Prerequisites:

…8057)

polina-c added 30 commits October 23, 2023 10:04

Update pubspec.yaml

16e7edc

Update pubspec.yaml

8226a79

Merge branch 'master' of https://github.com/flutter/flutter into add-dep

cefe66b

Update allowlist.dart

068e7a1

Merge branch 'master' of https://github.com/flutter/flutter into add-dep

3d26793

-

78fea14

Merge branch 'master' of https://github.com/flutter/flutter into add-dep

2fbe48f

Revert "-"

97ddb3f

This reverts commit 78fea14.

-

2725971

Merge branch 'master' of https://github.com/flutter/flutter into add-dep

22c8f50

-

4ead687

Update update_packages_test.dart

410387b

-

7d62581

-

49333c8

Update widget_tester.dart

b2a735f

-

d4ade8d

Update widget_tester.dart

e5f77f9

Merge branch 'master' of https://github.com/flutter/flutter into add-…

0e55d23

…dep-1

Merge branch 'upgrade-lt-2' into add-dep-1

34cc5f1

Merge branch 'add-dep-1' into add-param-3

20448b3

Update widget_tester.dart

3329aa1

Update widget_tester.dart

1a373ed

Update widget_tester.dart

9968d20

-

f2432f5

-

98f71f7

Update widget_tester.dart

9a10f23

Update widget_tester.dart

f7b055d

-

d88df19

Update widget_tester_test.dart

4f1c3ec

Merge branch 'master' of https://github.com/flutter/flutter into add-…

98f2397

…param-3

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2023

Merge branch 'master' into implement-4

805b483

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2023

auto-submit bot merged commit d746007 into flutter:master Dec 21, 2023

flar added a commit that referenced this pull request Dec 21, 2023

Revert "Integrate testWidgets with leak tracking. (#138057)"

4492c1f

This reverts commit d746007.

mraleph pushed a commit that referenced this pull request Dec 21, 2023

Revert "Integrate testWidgets with leak tracking. (#138057)" (#140502)

8407dd2

The PR is breaking the `flutter_test_performance` test and making the tree red.

engine-flutter-autoroll mentioned this pull request Dec 21, 2023

Roll Flutter from da0cd69659c5 to 11def8eff455 (16 revisions) flutter/packages#5732

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2023

d746007 Integrate testWidgets with leak tracking. (flutter/flutter#13…

2229a5e

…8057)

polina-c mentioned this pull request Dec 21, 2023

Re-land integrate testWidgets with leak tracking. #140521

Merged

3 tasks

CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023

Integrate testWidgets with leak tracking. (flutter#138057)

e669724

Contributes to: flutter#135856 TODO:

CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023

Revert "Integrate testWidgets with leak tracking. (flutter#138057)" (f…

b9d0052

…lutter#140502) The PR is breaking the `flutter_test_performance` test and making the tree red.

auto-submit bot mentioned this pull request Jan 3, 2024

Reverts "Re-land integrate testWidgets with leak tracking." #140926

Merged

3 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

d746007 Integrate testWidgets with leak tracking. (flutter/flutter#13…

070d804

…8057)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Integrate testWidgets with leak tracking. #138057

Integrate testWidgets with leak tracking. #138057

Uh oh!

polina-c commented Nov 8, 2023 •

edited

Loading

Uh oh!

auto-submit bot commented Dec 20, 2023

Uh oh!

polina-c commented Dec 20, 2023

Uh oh!

flar commented Dec 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Integrate testWidgets with leak tracking. #138057

Integrate testWidgets with leak tracking. #138057

Uh oh!

Conversation

polina-c commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit bot commented Dec 20, 2023

Uh oh!

polina-c commented Dec 20, 2023

Uh oh!

flar commented Dec 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

polina-c commented Nov 8, 2023 •

edited

Loading