Introduce `AnimationStyle` #137945

TahaTesser · 2023-11-06T15:56:58Z

This PR introduces AnimationStyle, it is used to override default animation curves and durations in several widgets.

fixes Add the ability to customize MaterialApp theme animation duration
fixes Allow customization of showMenu transition animation curves and duration

Here is an example where popup menu curve and transition duration is overriden:

          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),

Set AnimationStyle.noAnimation to disable animation.

    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

TahaTesser · 2023-11-08T15:58:39Z

@hans
Updated the animation override class and provide it to PopupMenuButton and MaterialApp widgets to start.

I think just animationOverride is enough for the PopupMenuButton, instead of open and close animation override. It seems to be reverse the same animation.

I also included an example

Screen.Recording.2023-11-08.at.15.54.37.mov

I can see some widgets see have duration and some widgets with route have transitionDuration and reverseTransitionDuration (like modal bottom sheet)

Do we add transitionDuration and reverseTransitionDuration properties to the class or just duration or reverseDuration is enough to override such properties?

HansMuller · 2023-11-08T23:52:19Z

I think just having duration and reverseDuration is enough. Adding a transitionDuration parameter would make the AnimationOverrides class a little confusing.

examples/api/lib/material/app/app.0.dart

examples/api/lib/material/popup_menu/popup_menu.2.dart

packages/flutter/lib/src/animation/animation_override.dart

HansMuller · 2023-11-09T17:39:11Z

examples/api/lib/material/app/app.0.dart

A request that comes up now and then is for a way to prevent an animation from happening at all. Perhaps we should provide a constant like AnimationOverride.noAnimation that has the durations set to zero. This feature would be useful to include here, since that's sometimes what developers want to do to the theme animation.

Great idea!

packages/flutter/lib/src/material/app.dart

packages/flutter/lib/src/material/popup_menu.dart

TahaTesser · 2023-11-09T18:13:09Z

@HansMuller appreciate the review!

TahaTesser · 2023-11-10T16:01:15Z

Added the suggestions and updated PR description

flutter-dashboard · 2023-11-10T16:02:28Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137945 at sha f13e53449485c7e23b088372b763a3dff7cf2024

TahaTesser · 2023-11-10T16:06:02Z

Some unexpected and unrelated widget goldens are detected for some reason. cc: @Piinks

HansMuller · 2023-11-10T16:40:38Z

We already have TextStyle, MenuStyle, ButtonStyle, all classes that are just bundles of properties that modify the appearance of a class. Maybe we should call this class AnimationStyle instead of AnimationOverrides.

packages/flutter/test/material/app_test.dart

TahaTesser · 2023-11-10T18:15:21Z

Resolved conflict from another PR just landed today and rename class to AnimationStyle

HansMuller

This is looking good. Only significant comment is about actually eliminating the animation widgets for AnimationStyle.noAnimation

packages/flutter/lib/src/material/app.dart

packages/flutter/lib/src/material/popup_menu.dart

examples/api/lib/material/app/app.0.dart

examples/api/lib/material/popup_menu/popup_menu.2.dart

packages/flutter/lib/src/material/popup_menu.dart

packages/flutter/lib/src/material/app.dart

TahaTesser · 2023-11-13T15:50:21Z

@HansMuller

This is looking good. Only significant comment is about actually eliminating the animation widgets for AnimationStyle.noAnimation

Updated the code for AnimationStyle.noAnimation, updated examples and tests for SegmentedButton, and documentation

HansMuller

This appears to be just about complete. Just a little feedback about Theme and AnimatedTheme

HansMuller · 2023-11-15T18:41:56Z

packages/flutter/lib/src/material/app.dart

This comment needs to be updated since the AnimatedTheme is no longer "above" and because the AnimatedTheme is optional.

Do we even need the extra build if the AnimatedTheme isn't used?

Woah... good catch I thought i did remove AnimatedTheme.

HansMuller

LGTM

This reverts commit 19e284f.

HansMuller · 2023-11-17T16:59:14Z

@TahaTesser - I had to revert this (#138628) due to an internal name collision.

When we reland this, we should include copyWith, hashCode methods, and the changes from #138619

Reverts #137945 Initiated by: HansMuller This change reverts the following previous change: Original Description: This PR introduces `AnimationStyle`, it is used to override default animation curves and durations in several widgets. fixes [Add the ability to customize MaterialApp theme animation duration](#78372) fixes [Allow customization of showMenu transition animation curves and duration](#135638) Here is an example where popup menu curve and transition duration is overriden: ```dart popUpAnimationStyle: AnimationStyle( curve: Easing.emphasizedAccelerate, duration: Durations.medium4, ), ``` Set `AnimationStyle.noAnimation` to disable animation. ```dart return MaterialApp( themeAnimationStyle: AnimationStyle.noAnimation, ```

flutter/flutter@53a57ad...6cf9ab0 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53c4fde7732b to d7af5fb60b4c (2 revisions) (flutter/flutter#138668) 2023-11-18 ryjohn@google.com Update release.yml (flutter/flutter#138561) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 384f75061257 to 53c4fde7732b (2 revisions) (flutter/flutter#138660) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f40c9f49f88 to 384f75061257 (2 revisions) (flutter/flutter#138658) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66f764a16610 to 5f40c9f49f88 (1 revision) (flutter/flutter#138655) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d2ee544c5e5 to 66f764a16610 (1 revision) (flutter/flutter#138652) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c38272b5e036 to 1d2ee544c5e5 (3 revisions) (flutter/flutter#138650) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e010f17eeb10 to c38272b5e036 (4 revisions) (flutter/flutter#138647) 2023-11-17 parlough@gmail.com Update links and surrounding text for new `main-api` docs (flutter/flutter#138602) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (flutter/flutter#138643) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (flutter/flutter#138637) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (flutter/flutter#138599) 2023-11-17 linxunfeng@yeah.net Fix NoSplash not being disposed (flutter/flutter#138542) 2023-11-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `AnimationStyle`" (flutter/flutter#138628) 2023-11-17 victoreronmosele@gmail.com Enable `flutter screenshot` outside Flutter project directory (flutter/flutter#138160) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (flutter/flutter#138585) 2023-11-16 47866232+chunhtai@users.noreply.github.com Improves output file path logic in Android analyze (flutter/flutter#136981) 2023-11-16 polinach@google.com Turn off leak tracker in master to make found leaks not blocking. (flutter/flutter#138567) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (flutter/flutter#138574) 2023-11-16 jason-simmons@users.noreply.github.com Enable the silent flag for invalid string exceptions when building a TextSpan (flutter/flutter#138564) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (flutter/flutter#138568) 2023-11-16 arpitgandhi9@users.noreply.github.com #60704: Pass cert for TLS localhost connection (flutter/flutter#106635) 2023-11-16 lsaudon@gmail.com Bump cupertino_icons to 1.0.6 (flutter/flutter#136962) 2023-11-16 72284940+feduke-nukem@users.noreply.github.com Fix sliver persistent header expand animation (flutter/flutter#137913) 2023-11-16 ian@hixie.ch Reduce animations further when --no-cli-animations is set. (flutter/flutter#133598) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (flutter/flutter#138560) 2023-11-16 tessertaha@gmail.com Introduce `AnimationStyle` (flutter/flutter#137945) 2023-11-16 dnfield@google.com Just use string interpolation for ws url for tests (flutter/flutter#138235) 2023-11-16 104349824+huycozy@users.noreply.github.com Adding new packages to the first-party package issue template (flutter/flutter#138540) 2023-11-16 engine-flutter-autoroll@skia.org Roll Packages from 0cd2378 to 07b4b29 (3 revisions) (flutter/flutter#138549) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (flutter/flutter#138546) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. labels Nov 6, 2023

This comment was marked as resolved.

Sign in to view

TahaTesser changed the title ~~[WIP]: Animation Overrides~~ [WIP]: Introduce AnimationOverride Nov 8, 2023

github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 8, 2023

HansMuller mentioned this pull request Nov 9, 2023

Expose animation parameters for the [ExpansionTile] widget #138047

Closed

2 tasks

HansMuller reviewed Nov 9, 2023

View reviewed changes

TahaTesser mentioned this pull request Nov 10, 2023

Added animationDuration parameter to showMenu and PopupMenuButton. #135797

Closed

8 tasks

TahaTesser changed the title ~~[WIP]: Introduce AnimationOverride~~ Introduce AnimationOverride Nov 10, 2023

TahaTesser marked this pull request as ready for review November 10, 2023 16:00

TahaTesser requested a review from HansMuller November 10, 2023 16:00

flutter-dashboard bot added the will affect goldens Changes to golden files label Nov 10, 2023

TahaTesser commented Nov 10, 2023

View reviewed changes

packages/flutter/test/material/app_test.dart Outdated Show resolved Hide resolved

TahaTesser changed the title ~~Introduce AnimationOverride~~ Introduce AnimationStyle Nov 10, 2023

HansMuller reviewed Nov 11, 2023

View reviewed changes

HansMuller reviewed Nov 15, 2023

View reviewed changes

HansMuller approved these changes Nov 15, 2023

View reviewed changes

Introduce AnimationStyle

57bc28d

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2023

auto-submit bot merged commit 19e284f into flutter:master Nov 16, 2023

TahaTesser deleted the animation_overrides branch November 17, 2023 14:53

engine-flutter-autoroll mentioned this pull request Nov 17, 2023

Roll Flutter from 53a57adcf136 to e9de44842094 (17 revisions) flutter/packages#5417

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023

19e284f Introduce AnimationStyle (flutter/flutter#137945)

a714a61

HansMuller added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 17, 2023

auto-submit bot mentioned this pull request Nov 17, 2023

Reverts "Introduce AnimationStyle" #138628

Merged

8 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 17, 2023

auto-submit bot pushed a commit that referenced this pull request Nov 17, 2023

Revert "Introduce AnimationStyle (#137945)"

4057ffb

This reverts commit 19e284f.

engine-flutter-autoroll mentioned this pull request Nov 17, 2023

Roll Flutter from 53a57adcf136 to 0135a3310af9 (18 revisions) flutter/packages#5419

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023

19e284f Introduce AnimationStyle (flutter/flutter#137945)

d540af0

This comment was marked as resolved.

Sign in to view

engine-flutter-autoroll mentioned this pull request Nov 17, 2023

Roll Flutter from 53a57adcf136 to 3c80df50403a (19 revisions) flutter/packages#5422

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023

19e284f Introduce AnimationStyle (flutter/flutter#137945)

cb9e985

HansMuller mentioned this pull request Nov 17, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll mentioned this pull request Nov 18, 2023

Roll Flutter from 53a57adcf136 to 6cf9ab02baec (31 revisions) flutter/packages#5426

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2023

19e284f Introduce AnimationStyle (flutter/flutter#137945)

d471063

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

19e284f Introduce AnimationStyle (flutter/flutter#137945)

f540451

Introduce AnimationStyle #137945

Introduce AnimationStyle #137945

Uh oh!

Conversation

TahaTesser commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

TahaTesser commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HansMuller commented Nov 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HansMuller Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

TahaTesser Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TahaTesser commented Nov 9, 2023

Uh oh!

TahaTesser commented Nov 10, 2023

Uh oh!

flutter-dashboard bot commented Nov 10, 2023

Uh oh!

TahaTesser commented Nov 10, 2023

Uh oh!

HansMuller commented Nov 10, 2023

Uh oh!

Uh oh!

TahaTesser commented Nov 10, 2023

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TahaTesser commented Nov 13, 2023

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller Nov 15, 2023

Choose a reason for hiding this comment

Uh oh!

TahaTesser Nov 15, 2023

Choose a reason for hiding this comment

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller commented Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Introduce `AnimationStyle` #137945

Introduce `AnimationStyle` #137945

TahaTesser commented Nov 6, 2023 •

edited

Loading

TahaTesser commented Nov 8, 2023 •

edited

Loading

HansMuller commented Nov 17, 2023 •

edited

Loading