Improves output file path logic in Android analyze #136981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
There was a problem hiding this comment.
why were we not exiting here before?
Contributor
Author
There was a problem hiding this comment.
it is probably an oversight by me
Contributor
There was a problem hiding this comment.
we try to avoid importing dart:io.
Also, in the general.shard, we should not be relying on the real platform. Also note you're constructing a FakePlatform on line 890. I would recommend having two tests, one for posix-y platforms, and one for windows.
Contributor
Author
There was a problem hiding this comment.
seems like I should just mocked the fs in the test.
1b0f030 to
5d5e36a
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 18, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 18, 2023
flutter/flutter@53a57ad...6cf9ab0 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53c4fde7732b to d7af5fb60b4c (2 revisions) (flutter/flutter#138668) 2023-11-18 ryjohn@google.com Update release.yml (flutter/flutter#138561) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 384f75061257 to 53c4fde7732b (2 revisions) (flutter/flutter#138660) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f40c9f49f88 to 384f75061257 (2 revisions) (flutter/flutter#138658) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66f764a16610 to 5f40c9f49f88 (1 revision) (flutter/flutter#138655) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d2ee544c5e5 to 66f764a16610 (1 revision) (flutter/flutter#138652) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c38272b5e036 to 1d2ee544c5e5 (3 revisions) (flutter/flutter#138650) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e010f17eeb10 to c38272b5e036 (4 revisions) (flutter/flutter#138647) 2023-11-17 parlough@gmail.com Update links and surrounding text for new `main-api` docs (flutter/flutter#138602) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (flutter/flutter#138643) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (flutter/flutter#138637) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (flutter/flutter#138599) 2023-11-17 linxunfeng@yeah.net Fix NoSplash not being disposed (flutter/flutter#138542) 2023-11-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `AnimationStyle`" (flutter/flutter#138628) 2023-11-17 victoreronmosele@gmail.com Enable `flutter screenshot` outside Flutter project directory (flutter/flutter#138160) 2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (flutter/flutter#138585) 2023-11-16 47866232+chunhtai@users.noreply.github.com Improves output file path logic in Android analyze (flutter/flutter#136981) 2023-11-16 polinach@google.com Turn off leak tracker in master to make found leaks not blocking. (flutter/flutter#138567) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (flutter/flutter#138574) 2023-11-16 jason-simmons@users.noreply.github.com Enable the silent flag for invalid string exceptions when building a TextSpan (flutter/flutter#138564) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (flutter/flutter#138568) 2023-11-16 arpitgandhi9@users.noreply.github.com #60704: Pass cert for TLS localhost connection (flutter/flutter#106635) 2023-11-16 lsaudon@gmail.com Bump cupertino_icons to 1.0.6 (flutter/flutter#136962) 2023-11-16 72284940+feduke-nukem@users.noreply.github.com Fix sliver persistent header expand animation (flutter/flutter#137913) 2023-11-16 ian@hixie.ch Reduce animations further when --no-cli-animations is set. (flutter/flutter#133598) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (flutter/flutter#138560) 2023-11-16 tessertaha@gmail.com Introduce `AnimationStyle` (flutter/flutter#137945) 2023-11-16 dnfield@google.com Just use string interpolation for ws url for tests (flutter/flutter#138235) 2023-11-16 104349824+huycozy@users.noreply.github.com Adding new packages to the first-party package issue template (flutter/flutter#138540) 2023-11-16 engine-flutter-autoroll@skia.org Roll Packages from 0cd2378 to 07b4b29 (3 revisions) (flutter/flutter#138549) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (flutter/flutter#138546) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.