Skip to content

Reduce animations further when --no-cli-animations is set. #133598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Nov 16, 2023
Merged

Reduce animations further when --no-cli-animations is set. #133598

auto-submit merged 1 commit into from
Nov 16, 2023

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Aug 29, 2023

No description provided.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 29, 2023
christopherfujino
christopherfujino reviewed Aug 29, 2023
View reviewed changes
packages/flutter_tools/lib/runner.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this better than just looking up globals.featureFlags.isCliAnimationEnabledinside the AnsiTerminal class? It could be a lazily initialized late final property?

Copy link
Contributor

@christopherfujino christopherfujino Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like everything we set here or in FlutterCommandRunner.runCommand() is a gotcha easter egg.

Copy link
Contributor Author

@Hixie Hixie Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if I'm using global variables anyway I might as well do it as a late final, sure.

Copy link
Contributor Author

@Hixie Hixie Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I started doing this but I got stuck because I can't figure out what the long-term plan is here. In the PR as posted, the long-term plan would be to pass the FeatureFlags and the AnsiTerminal to the runner and have it apply one to the other, or (better) to have the code that creates the AnsiTerminal and the FeatureFlags apply one to the other before giving it to the runner, but if the AnsiTerminal doesn't get given a FeatureFlags at all then I don't understand how we replace the call to the globals in the AnsiTerminal code.

@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 7, 2023

@Hixie are you still planning to land this one?

@Hixie
Copy link
Contributor Author

Hixie commented Sep 11, 2023

Yeah I'll get to it eventually. Need to make time to apply the change you suggested.

christopherfujino
christopherfujino approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 2, 2023

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino
Copy link
Contributor

christopherfujino commented Oct 19, 2023 •
edited
Loading

@Hixie looks like you have build errors

@eliasyishak
Copy link
Contributor

eliasyishak commented Nov 2, 2023

@Hixie is this ready for the autosubmit label now?

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2023
@auto-submit auto-submit bot merged commit 4d788b1 into flutter:master Nov 16, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
4d788b1 Reduce animations further when --no-cli-animations is set. (f…
361fb0c 
…lutter/flutter#133598)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
4d788b1 Reduce animations further when --no-cli-animations is set. (f…
f926d99 
…lutter/flutter#133598)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
4d788b1 Reduce animations further when --no-cli-animations is set. (f…
decddf8 
…lutter/flutter#133598)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2023
@engine-flutter-autoroll
4d788b1 Reduce animations further when --no-cli-animations is set. (f…
9a81048 
…lutter/flutter#133598)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 18, 2023
@engine-flutter-autoroll
Roll Flutter from 53a57ad to 6cf9ab0 (31 revisions) (#5426)
2e010d8 
flutter/flutter@53a57ad...6cf9ab0

2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 53c4fde7732b to d7af5fb60b4c (2 revisions) (flutter/flutter#138668)
2023-11-18 ryjohn@google.com Update release.yml (flutter/flutter#138561)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 384f75061257 to 53c4fde7732b (2 revisions) (flutter/flutter#138660)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f40c9f49f88 to 384f75061257 (2 revisions) (flutter/flutter#138658)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66f764a16610 to 5f40c9f49f88 (1 revision) (flutter/flutter#138655)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d2ee544c5e5 to 66f764a16610 (1 revision) (flutter/flutter#138652)
2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c38272b5e036 to 1d2ee544c5e5 (3 revisions) (flutter/flutter#138650)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e010f17eeb10 to c38272b5e036 (4 revisions) (flutter/flutter#138647)
2023-11-17 parlough@gmail.com Update links and surrounding text for new `main-api` docs (flutter/flutter#138602)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (flutter/flutter#138643)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (flutter/flutter#138637)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (flutter/flutter#138599)
2023-11-17 linxunfeng@yeah.net Fix NoSplash not being disposed (flutter/flutter#138542)
2023-11-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `AnimationStyle`" (flutter/flutter#138628)
2023-11-17 victoreronmosele@gmail.com Enable `flutter screenshot` outside Flutter project directory (flutter/flutter#138160)
2023-11-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (flutter/flutter#138585)
2023-11-16 47866232+chunhtai@users.noreply.github.com Improves output file path logic in Android analyze (flutter/flutter#136981)
2023-11-16 polinach@google.com Turn off leak tracker in master to make found leaks not blocking. (flutter/flutter#138567)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (flutter/flutter#138574)
2023-11-16 jason-simmons@users.noreply.github.com Enable the silent flag for invalid string exceptions when building a TextSpan (flutter/flutter#138564)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (flutter/flutter#138568)
2023-11-16 arpitgandhi9@users.noreply.github.com #60704: Pass cert for TLS localhost connection (flutter/flutter#106635)
2023-11-16 lsaudon@gmail.com Bump cupertino_icons to 1.0.6 (flutter/flutter#136962)
2023-11-16 72284940+feduke-nukem@users.noreply.github.com Fix sliver persistent header expand animation (flutter/flutter#137913)
2023-11-16 ian@hixie.ch Reduce animations further when --no-cli-animations is set. (flutter/flutter#133598)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (flutter/flutter#138560)
2023-11-16 tessertaha@gmail.com Introduce `AnimationStyle` (flutter/flutter#137945)
2023-11-16 dnfield@google.com Just use string interpolation for ws url for tests (flutter/flutter#138235)
2023-11-16 104349824+huycozy@users.noreply.github.com Adding new packages to the first-party package issue template (flutter/flutter#138540)
2023-11-16 engine-flutter-autoroll@skia.org Roll Packages from 0cd2378 to 07b4b29 (3 revisions) (flutter/flutter#138549)
2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (flutter/flutter#138546)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bartekpacia
bartekpacia reviewed Jan 9, 2024
View reviewed changes
packages/flutter_tools/lib/src/base/context.dart
Comment on lines +10 to +12
// TODO(ianh): We should remove AppContext's mechanism and replace it with
// passing dependencies directly in constructors, methods, etc.

Copy link
Member

@bartekpacia bartekpacia Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was an issue for this created? I just noticed this todo and it seems like it'd be a huge change to the tool's codebase.

(I'm also curious to learn why you're not happy anymore with the AppContext mechanism)

Copy link
Contributor

@christopherfujino christopherfujino Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#47161

Copy link
Member

@bartekpacia bartekpacia Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bartekpacia bartekpacia mentioned this pull request Jan 15, 2024
Merged
auto-submit bot pushed a commit that referenced this pull request Jan 16, 2024
@bartekpacia
Reference GitHub issue in TODO comment (#141582)
1e5acbc 
[Source](#133598 (comment))

For future readers.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
4d788b1 Reduce animations further when --no-cli-animations is set. (f…
87ab2d2 
…lutter/flutter#133598)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartekpacia bartekpacia bartekpacia left review comments

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hixie @christopherfujino @eliasyishak @bartekpacia