Skip to content

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Apr 4, 2023

@zanderso zanderso requested review from HansMuller and thkim1011 April 4, 2023 01:57
@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Apr 4, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso requested a review from chunhtai April 4, 2023 01:58
@zanderso zanderso added warning: land on red to fix tree breakage revert Autorevert PR (with "Reason for revert:" comment) labels Apr 4, 2023
@auto-submit auto-submit bot merged commit 1058745 into master Apr 4, 2023
@auto-submit auto-submit bot deleted the revert-123575-tae/update-translations branch April 4, 2023 01:59
thkim1011 added a commit that referenced this pull request Apr 4, 2023
thkim1011 added a commit that referenced this pull request Apr 4, 2023
…124094)

Reverts #124088

This PR should properly incorporate the new Welsh translations into
Flutter (and maybe some other strings that seem to be updated in TC).

I think the other translation changes come from this issue:
#115181.

Fixes #120124.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
…ions)" (flutter#124088)

Revert "Add Welsh to Material Flutter (and update some other translations)"
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
…lutter#124094)

Reverts flutter#124088

This PR should properly incorporate the new Welsh translations into
Flutter (and maybe some other strings that seem to be updated in TC).

I think the other translation changes come from this issue:
flutter#115181.

Fixes flutter#120124.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants