Add Welsh to Material Flutter (and update some other translations) #124094
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I'm going to let all the checks run since the last PR didn't catch the failing test somehow. |
|
To give some context about what went wrong in the previous PR, not all the relevant tests seemed to have run and there was an old issue that I did not properly address: #108125 Although ICU CLDR data suggests that the strings முற்பகல் and பிற்பகல் are the translations for AM/PM for language code ta, our linguist disagreed in an internal thread b/238115277 and preferred the format |
|
Thanks, I'll give it another try. |
…lutter#124094) Reverts flutter#124088 This PR should properly incorporate the new Welsh translations into Flutter (and maybe some other strings that seem to be updated in TC). I think the other translation changes come from this issue: flutter#115181. Fixes flutter#120124.
Reverts #124088
This PR should properly incorporate the new Welsh translations into Flutter (and maybe some other strings that seem to be updated in TC).
I think the other translation changes come from this issue: #115181.
Fixes #120124.