-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add Welsh to Material Flutter (and update some other translations) #123575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
godofredoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4a79f56 to
5a26f95
Compare
|
auto label is removed for flutter/flutter, pr: 123575, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
5a26f95 to
237440b
Compare
|
Just wanted to leave an update on why the Google testing isn't passing. Turns out the Github API for fetching files only supports up to 1 MiB unless handled slightly differently. I'm working on an internal fix for this issue on the side. |
…lutter#123575) This PR should properly incorporate the new Welsh translations into Flutter (and maybe some other strings that seem to be updated in TC). I think the other translation changes come from this issue: flutter#115181. Fixes flutter#120124.
This PR should properly incorporate the new Welsh translations into Flutter (and maybe some other strings that seem to be updated in TC).
I think the other translation changes come from this issue: #115181.
Fixes #120124.