Skip to content

Conversation

@thkim1011
Copy link
Contributor

@thkim1011 thkim1011 commented Mar 28, 2023

This PR should properly incorporate the new Welsh translations into Flutter (and maybe some other strings that seem to be updated in TC).

I think the other translation changes come from this issue: #115181.

Fixes #120124.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Mar 28, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai mentioned this pull request Mar 28, 2023
8 tasks
@thkim1011 thkim1011 added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2023
@thkim1011 thkim1011 force-pushed the tae/update-translations branch from 4a79f56 to 5a26f95 Compare March 28, 2023 21:17
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 29, 2023

auto label is removed for flutter/flutter, pr: 123575, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks force-pushed the tae/update-translations branch from 5a26f95 to 237440b Compare March 29, 2023 20:53
@thkim1011
Copy link
Contributor Author

Just wanted to leave an update on why the Google testing isn't passing. Turns out the Github API for fetching files only supports up to 1 MiB unless handled slightly differently. I'm working on an internal fix for this issue on the side.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
…lutter#123575)

This PR should properly incorporate the new Welsh translations into
Flutter (and maybe some other strings that seem to be updated in TC).

I think the other translation changes come from this issue:
flutter#115181.

Fixes flutter#120124.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Welsh for Material Localizations

3 participants