This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Generate .packages for both flutter_kernel_transformers and frontend_server in the same way #5362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…server in the same way
aam
reviewed
May 24, 2018
tools/generate_package_files.py
Outdated
| [name, path] = line.split(':', 1) | ||
| packages.write('%s:../../third_party/dart/%s' % (name, path)) | ||
| packages.write('%s:./lib\n' % (package)) | ||
| for other_package in ALL_PACKAGES: |
Member
There was a problem hiding this comment.
frontend_server depends on flutter_kernel_transformers, but flutter_kernel_transformers doesn't depend on frontend_server.
Member
Author
There was a problem hiding this comment.
Fixed. Please take another look.
Member
|
Merging on @mraleph 's behalf to unblock dart roll into engine |
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
May 24, 2018
* abd74ed Add support for physical keyboards on Android (flutter/engine#5324) * bb75825 Update buildroot to pull in msvc updates. (flutter/engine#5366) * df7a02d Roll src/third_party/skia a0047bc..20027ce (19 commits) (flutter/engine#5365) * 15bb9b8 Generate .packages for both flutter_kernel_transformers and frontend_server in the same way (flutter/engine#5362) * 983f39c Don't enable LTO on Windows hosts as the toolchain does not read the value. (flutter/engine#5364) * fb709e2 [fuchsia] Plumbing for sharing between AOT snapshots. (flutter/engine#5351) * 416418f Roll src/third_party/skia 75bf216..a0047bc (5 commits) (flutter/engine#5363) * b607382 Improve licenses script (flutter/engine#5355) * c8050e8 Generate frontend server's .packages from Dart .packages file instead of using pub get. (flutter/engine#5360) * 4d89213 Roll src/third_party/skia 84a4e5c..75bf216 (5 commits) (flutter/engine#5361) * f24fdba Roll src/third_party/skia/ e9c81ee2e..84a4e5c00 (1 commit) (flutter/engine#5359) * c622c68 Roll src/third_party/skia/ 8517631bf..e9c81ee2e (1 commit) (flutter/engine#5358) * 93b3b26 Roll src/third_party/skia/ d416083ee..8517631bf (3 commits; 2 trivial rolls) (flutter/engine#5357) * 9b51b89 Roll src/third_party/skia/ 13235d896..d416083ee (3 commits) (flutter/engine#5356)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.