Generate frontend server's .packages from Dart .packages file instead of using pub get. #5360
Conversation
tools/frontend_server_packages.py
Outdated
| SRC_DIR = os.path.dirname(os.path.dirname(FRONTEND_SERVER_DIR)) | ||
| DART_PACKAGES_FILE = os.path.join(SRC_DIR, 'third_party', 'dart', '.packages') | ||
|
|
||
| with open('.package', 'w') as packages: |
There was a problem hiding this comment.
I can't name a variable .packages.
There was a problem hiding this comment.
I meant '.packages' rather than '.package'
There was a problem hiding this comment.
Ooops! Thanks for catching this.
| 'dart_stack_trace_tag': '1.9.2', | ||
| 'dart_stream_channel_tag': '1.6.4', | ||
| 'dart_string_scanner_tag': '1.0.2', | ||
| 'dart_term_glyph_tag': '1.0.0', |
There was a problem hiding this comment.
Was this change intentional? It seems to be unrelated to the generation of .packages file.
There was a problem hiding this comment.
Yes. This is a package needed to run the test. (I think test package depends on it).
It used to be pulled by pub get.
|
@aam I have fixed the python script :) previously things were passing because I had a stale |
|
Sounds good! Thanks for fixing this! |
|
I think the |
|
cc @jacob314 then |
Yes, this needs to be done now to unblock dart->flutter engine roll. |
* abd74ed Add support for physical keyboards on Android (flutter/engine#5324) * bb75825 Update buildroot to pull in msvc updates. (flutter/engine#5366) * df7a02d Roll src/third_party/skia a0047bc..20027ce (19 commits) (flutter/engine#5365) * 15bb9b8 Generate .packages for both flutter_kernel_transformers and frontend_server in the same way (flutter/engine#5362) * 983f39c Don't enable LTO on Windows hosts as the toolchain does not read the value. (flutter/engine#5364) * fb709e2 [fuchsia] Plumbing for sharing between AOT snapshots. (flutter/engine#5351) * 416418f Roll src/third_party/skia 75bf216..a0047bc (5 commits) (flutter/engine#5363) * b607382 Improve licenses script (flutter/engine#5355) * c8050e8 Generate frontend server's .packages from Dart .packages file instead of using pub get. (flutter/engine#5360) * 4d89213 Roll src/third_party/skia 84a4e5c..75bf216 (5 commits) (flutter/engine#5361) * f24fdba Roll src/third_party/skia/ e9c81ee2e..84a4e5c00 (1 commit) (flutter/engine#5359) * c622c68 Roll src/third_party/skia/ 8517631bf..e9c81ee2e (1 commit) (flutter/engine#5358) * 93b3b26 Roll src/third_party/skia/ d416083ee..8517631bf (3 commits; 2 trivial rolls) (flutter/engine#5357) * 9b51b89 Roll src/third_party/skia/ 13235d896..d416083ee (3 commits) (flutter/engine#5356)
Dart SDK itself does not use pub which forced us to manually maintain dependecy
overrides in the frontend server's pubspec.yaml. This is rather fragile and
easily breaks when dependencies in one of the "internal" packages change, but
the package is not published yet.
This change switches us to the same model of dependcies management that Dart SDK
itself is using.
Down side of this is that we can no longer do
pub run testin thefrontend_server and have to run tests manually.