Fixed support for physical keyboards on Android. flutter/flutter#11177 #5324
Conversation
|
@xster ping!. the original bug was not assigned, not sure who can review this PR. |
|
@cbracken or @jason-simmons would be more familiar with the text editing interactions. |
| if (selEnd > selStart) { | ||
| // Delete the selection. | ||
| Selection.setSelection(mEditable, selStart); | ||
| deleteSurroundingText(0, selEnd - selStart); |
There was a problem hiding this comment.
Looks like you can delete deleteSurroundingText now. I don't see any other uses.
There was a problem hiding this comment.
Apologies - ignore that; it's part of the public interface; leave it for now and we can take a look at cleaning up separately.
There was a problem hiding this comment.
sounds good, anything else on the review?
Fixes:
```
flutter/shell/platform/android/io/flutter/view/FlutterView.java:204: error: cannot find symbol
mImm = (InputMethodManager) view.getContext().getSystemService(Context.INPUT_METHOD_SERVICE);
^
symbol: variable view
location: class FlutterView
1 error
```
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
@slightfoot verified to have signed CLA. @cbracken is a Googler. |
Actual fix to be applied momentarily.
Fixes:
```
../../flutter/shell/platform/android/io/flutter/view/FlutterView.java:204: error: cannot find symbol
mImm = (InputMethodManager) view.getContext().getSystemService(Context.INPUT_METHOD_SERVICE);
^
symbol: variable view
location: class FlutterView
1 error
```
|
LGTM post-fix! Manually verified for both English and Japanese input on a Nexus 6P. Thanks for sending!
|
|
@cbracken thanks! great news! |
* abd74ed Add support for physical keyboards on Android (flutter/engine#5324) * bb75825 Update buildroot to pull in msvc updates. (flutter/engine#5366) * df7a02d Roll src/third_party/skia a0047bc..20027ce (19 commits) (flutter/engine#5365) * 15bb9b8 Generate .packages for both flutter_kernel_transformers and frontend_server in the same way (flutter/engine#5362) * 983f39c Don't enable LTO on Windows hosts as the toolchain does not read the value. (flutter/engine#5364) * fb709e2 [fuchsia] Plumbing for sharing between AOT snapshots. (flutter/engine#5351) * 416418f Roll src/third_party/skia 75bf216..a0047bc (5 commits) (flutter/engine#5363) * b607382 Improve licenses script (flutter/engine#5355) * c8050e8 Generate frontend server's .packages from Dart .packages file instead of using pub get. (flutter/engine#5360) * 4d89213 Roll src/third_party/skia 84a4e5c..75bf216 (5 commits) (flutter/engine#5361) * f24fdba Roll src/third_party/skia/ e9c81ee2e..84a4e5c00 (1 commit) (flutter/engine#5359) * c622c68 Roll src/third_party/skia/ 8517631bf..e9c81ee2e (1 commit) (flutter/engine#5358) * 93b3b26 Roll src/third_party/skia/ d416083ee..8517631bf (3 commits; 2 trivial rolls) (flutter/engine#5357) * 9b51b89 Roll src/third_party/skia/ 13235d896..d416083ee (3 commits) (flutter/engine#5356)
Fixes flutter/flutter#11177
Also fixes flutter/flutter#7943 and fixes flutter/flutter#9347