Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Contributor

The current count is determined from std::thread::hardware_concurrency which can
return zero. Even in such cases, the implementation may not return a loop with
no workers. There are numerous components that depend on having non-zero workers
in the queue.

@chinmaygarde chinmaygarde changed the title Add test to ensure that concurrent message loops have at least one workers. Add test to ensure that concurrent message loops have at least one worker. Jan 28, 2020
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 28, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Cirrus CI has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 28, 2020
…rkers.

The current count is determined from std::thread::hardware_concurrency which can
return zero. Even in such cases, the implementation may not return a loop with
no workers. There are numerous components that depend on having non-zero workers
in the queue.
@chinmaygarde chinmaygarde merged commit 532fdc4 into flutter:master Jan 28, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 29, 2020
flutter/engine@c4229bf...ec32966

git log c4229bf..ec32966 --first-parent --oneline
2020-01-28 ychris@google.com Revert "Always make gpu thread different from platform thread regardless of platform view (#16068)" (flutter/engine#16161)
2020-01-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from gNitp... to 5fMtM... (flutter/engine#16153)
2020-01-28 chinmaygarde@google.com Revert "Disable setting a library tag handler." (flutter/engine#16157)
2020-01-28 ychris@google.com Always make gpu thread different from platform thread regardless of platform view (flutter/engine#16068)
2020-01-28 chinmaygarde@google.com Add test to ensure that concurrent message loops have at least one workers. (flutter/engine#16074)
2020-01-28 dnfield@google.com Revert breaking PRs (flutter/engine#16148)
2020-01-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 8Ns10... to 2rLoq... (flutter/engine#15971)
2020-01-28 franciscojma86@gmail.com Gets the DPI for all awareness mode and older Windows versions (flutter/engine#15951)
2020-01-28 chinmaygarde@google.com Hold a mutex when updating all CanPostTaskToAllNativeThreads::Captures members. (flutter/engine#16085)
2020-01-28 chinmaygarde@google.com Disable setting a library tag handler. (flutter/engine#16086)
2020-01-28 garyq@google.com Web PargraphStyle TextHeightBehavior integration (flutter/engine#16075)
2020-01-28 chinmaygarde@google.com Fix flake by making thread ID tracking in CanPostTaskToAllNativeThreads thread safe. (flutter/engine#16081)
2020-01-28 chinmaygarde@google.com Remove buggy assertion in EmbedderTest::CanPostTaskToAllNativeThreads. (flutter/engine#16071)
2020-01-27 chinmaygarde@google.com Remove tonic/platform. (flutter/engine#16062)
2020-01-27 chinmaygarde@gmail.com Allow embedders to schedule a callback on all engine managed threads. (flutter/engine#15980)
2020-01-27 garyq@google.com Engine/LibTxt/dart:ui impl of TextHeightBehavior (flutter/engine#15087)
2020-01-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia f1b2b42613cb..9c1d30dd163e (8 commits) (flutter/engine#16060)
2020-01-27 chinmaygarde@google.com Remove stale recipe changelog. (flutter/engine#15985)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
…rkers. (flutter#16074)

The current count is determined from std::thread::hardware_concurrency which can
return zero. Even in such cases, the implementation may not return a loop with
no workers. There are numerous components that depend on having non-zero workers
in the queue.
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@chinmaygarde chinmaygarde deleted the fix_concurrency_test branch March 20, 2020 03:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants