Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c4229bfbbae4
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ec32966e030a
Choose a head ref
  • 18 commits
  • 27 files changed
  • 7 contributors

Commits on Jan 27, 2020

  1. Remove stale recipe changelog. (#15985)

    We tried updating this for a while but we seem to have given up. This is now
    stale. Removing the same.
    chinmaygarde authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    0d6bc82 View commit details
    Browse the repository at this point in the history
  2. Roll src/third_party/skia f1b2b42..9c1d30d (8 commits) (#16060)

    https://skia.googlesource.com/skia.git/+log/f1b2b42613cb..9c1d30dd163e
    
    git log f1b2b42..9c1d30d --date=short --first-parent --format='%ad %ae %s'
    2020-01-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
    2020-01-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
    2020-01-27 mtklein@google.com draw whole grid
    2020-01-27 fmalita@chromium.org [skottie] Cleanup: convert transform adapters to new pattern
    2020-01-27 mtklein@google.com rm mtklein@chromium
    2020-01-27 bsalomon@google.com Revert "Switch runtime SkSL to always sample at explicit coords"
    2020-01-27 jvanverth@google.com Revert "Wrap page index packing in helper methods."
    2020-01-27 brianosman@google.com Switch runtime SkSL to always sample at explicit coords
    
    Created with:
      gclient setdep -r src/third_party/skia@9c1d30dd163e
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC reed@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    Bug: None
    Tbr: reed@google.com
    skia-flutter-autoroll authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    222770c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbf4536 View commit details
    Browse the repository at this point in the history
  4. Allow embedders to schedule a callback on all engine managed threads. (

    …#15980)
    
    `FlutterEnginePostCallbackOnAllNativeThreads` schedule a callback to be run on
    all engine managed threads. The engine will attempt to service this callback the
    next time the message loops for each managed thread is idle. Since the engine
    manages the entire lifecycle of multiple threads, there is no opportunity for
    the embedders to finely tune the priorities of threads directly, or, perform
    other thread specific configuration (for example, setting thread names for
    tracing). This callback gives embedders a chance to affect such tuning.
    
    Fixes flutter/flutter#49551
    Fixes b/143774406
    Fixes b/148278215
    Fixes b/148278931
    chinmaygarde authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    c5329ef View commit details
    Browse the repository at this point in the history
  5. Remove tonic/platform. (#16062)

    This is unused.
    chinmaygarde authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    da1a5d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. Remove buggy assertion in EmbedderTest::CanPostTaskToAllNativeThreads. (

    #16071)
    
    This was introduced in
    c5329ef.
    
    The assertion was originally written to check that more than 4 threads were
    managed by the engine (UI, Platform, GPU, IO + ConcurrentWQWorkers). However,
    the assertion actually only checked the count of workers in the ConcurrentWQ. As
    written, this assertion would fail on all hosts with a hardware concurrency of
    less than 4. Remove the assertion. The engine threads count and its assertions
    already check callbacks on workers. So this check was incorrect and redundant.
    chinmaygarde authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    aab316c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    26fd7d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    86682a2 View commit details
    Browse the repository at this point in the history
  4. Disable setting a library tag handler. (#16086)

    This is only used in the command line VM. The only conceivable use of this would
    be with IsolateMirror.loadURI which is not supported in Flutter or used in known
    embedder API implementations (even ones that use mirrors).
    chinmaygarde authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    ef3aa01 View commit details
    Browse the repository at this point in the history
  5. Hold a mutex when updating all CanPostTaskToAllNativeThreads::Capture…

    …s members. (#16085)
    
    This is in the same vein as #16081 but
    includes holding the mutex when updating all members in the Captures struct
    instead of just when tracking thread IDs.
    chinmaygarde authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    db96c1c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0de80f4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b4fc4b5 View commit details
    Browse the repository at this point in the history
  8. Revert breaking PRs (#16148)

    * Revert "Web PargraphStyle TextHeightBehavior integration (#16075)"
    
    This reverts commit 86682a2.
    
    * Revert "Engine/LibTxt/dart:ui impl of TextHeightBehavior (#15087)"
    
    This reverts commit cbf4536.
    dnfield authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    53baa7a View commit details
    Browse the repository at this point in the history
  9. Add test to ensure that concurrent message loops have at least one wo…

    …rkers. (#16074)
    
    The current count is determined from std::thread::hardware_concurrency which can
    return zero. Even in such cases, the implementation may not return a loop with
    no workers. There are numerous components that depend on having non-zero workers
    in the queue.
    chinmaygarde authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    532fdc4 View commit details
    Browse the repository at this point in the history
  10. Always make gpu thread different from platform thread regardless of p…

    …latform view (#16068)
    Chris Yang authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    0889e97 View commit details
    Browse the repository at this point in the history
  11. Revert "Disable setting a library tag handler." (#16157)

    This reverts commit ef3aa01. This address the use case of an internal customer. In a subsequent patch, I will add a test for this functionality. Instead of removing support for the same from tonic (along with the stuff surrounding filesystem access and package map handling), I’ll rework the same to use FML to avoid code duplication and maintainability.
    chinmaygarde authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    5a1439c View commit details
    Browse the repository at this point in the history
  12. Roll fuchsia/sdk/core/mac-amd64 from gNitp... to 5fMtM... (#16153)

    Roll fuchsia/sdk/core/mac-amd64 from gNitp... to 5fMtM...
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
    Please CC  on the revert to ensure that a human
    is aware of the problem.
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    skia-flutter-autoroll authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    a851d1e View commit details
    Browse the repository at this point in the history
  13. Revert "Always make gpu thread different from platform thread regardl…

    …ess of platform view (#16068)" (#16161)
    
    This reverts commit 0889e97.
    Chris Yang authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    ec32966 View commit details
    Browse the repository at this point in the history
Loading