-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: c4229bfbbae4
head repository: flutter/engine
compare: ec32966e030a
- 18 commits
- 27 files changed
- 7 contributors
Commits on Jan 27, 2020
-
Remove stale recipe changelog. (#15985)
We tried updating this for a while but we seem to have given up. This is now stale. Removing the same.
Configuration menu - View commit details
-
Copy full SHA for 0d6bc82 - Browse repository at this point
Copy the full SHA 0d6bc82View commit details -
Roll src/third_party/skia f1b2b42..9c1d30d (8 commits) (#16060)
https://skia.googlesource.com/skia.git/+log/f1b2b42613cb..9c1d30dd163e git log f1b2b42..9c1d30d --date=short --first-parent --format='%ad %ae %s' 2020-01-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-27 mtklein@google.com draw whole grid 2020-01-27 fmalita@chromium.org [skottie] Cleanup: convert transform adapters to new pattern 2020-01-27 mtklein@google.com rm mtklein@chromium 2020-01-27 bsalomon@google.com Revert "Switch runtime SkSL to always sample at explicit coords" 2020-01-27 jvanverth@google.com Revert "Wrap page index packing in helper methods." 2020-01-27 brianosman@google.com Switch runtime SkSL to always sample at explicit coords Created with: gclient setdep -r src/third_party/skia@9c1d30dd163e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: reed@google.com
Configuration menu - View commit details
-
Copy full SHA for 222770c - Browse repository at this point
Copy the full SHA 222770cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbf4536 - Browse repository at this point
Copy the full SHA cbf4536View commit details -
Allow embedders to schedule a callback on all engine managed threads. (…
…#15980) `FlutterEnginePostCallbackOnAllNativeThreads` schedule a callback to be run on all engine managed threads. The engine will attempt to service this callback the next time the message loops for each managed thread is idle. Since the engine manages the entire lifecycle of multiple threads, there is no opportunity for the embedders to finely tune the priorities of threads directly, or, perform other thread specific configuration (for example, setting thread names for tracing). This callback gives embedders a chance to affect such tuning. Fixes flutter/flutter#49551 Fixes b/143774406 Fixes b/148278215 Fixes b/148278931
Configuration menu - View commit details
-
Copy full SHA for c5329ef - Browse repository at this point
Copy the full SHA c5329efView commit details -
Configuration menu - View commit details
-
Copy full SHA for da1a5d5 - Browse repository at this point
Copy the full SHA da1a5d5View commit details
Commits on Jan 28, 2020
-
Remove buggy assertion in EmbedderTest::CanPostTaskToAllNativeThreads. (
#16071) This was introduced in c5329ef. The assertion was originally written to check that more than 4 threads were managed by the engine (UI, Platform, GPU, IO + ConcurrentWQWorkers). However, the assertion actually only checked the count of workers in the ConcurrentWQ. As written, this assertion would fail on all hosts with a hardware concurrency of less than 4. Remove the assertion. The engine threads count and its assertions already check callbacks on workers. So this check was incorrect and redundant.
Configuration menu - View commit details
-
Copy full SHA for aab316c - Browse repository at this point
Copy the full SHA aab316cView commit details -
Fix flake by making thread ID tracking in CanPostTaskToAllNativeThrea…
…ds thread safe. (#16081)
Configuration menu - View commit details
-
Copy full SHA for 26fd7d0 - Browse repository at this point
Copy the full SHA 26fd7d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86682a2 - Browse repository at this point
Copy the full SHA 86682a2View commit details -
Disable setting a library tag handler. (#16086)
This is only used in the command line VM. The only conceivable use of this would be with IsolateMirror.loadURI which is not supported in Flutter or used in known embedder API implementations (even ones that use mirrors).
Configuration menu - View commit details
-
Copy full SHA for ef3aa01 - Browse repository at this point
Copy the full SHA ef3aa01View commit details -
Hold a mutex when updating all CanPostTaskToAllNativeThreads::Capture…
Configuration menu - View commit details
-
Copy full SHA for db96c1c - Browse repository at this point
Copy the full SHA db96c1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0de80f4 - Browse repository at this point
Copy the full SHA 0de80f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4fc4b5 - Browse repository at this point
Copy the full SHA b4fc4b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53baa7a - Browse repository at this point
Copy the full SHA 53baa7aView commit details -
Add test to ensure that concurrent message loops have at least one wo…
…rkers. (#16074) The current count is determined from std::thread::hardware_concurrency which can return zero. Even in such cases, the implementation may not return a loop with no workers. There are numerous components that depend on having non-zero workers in the queue.
Configuration menu - View commit details
-
Copy full SHA for 532fdc4 - Browse repository at this point
Copy the full SHA 532fdc4View commit details -
Always make gpu thread different from platform thread regardless of p…
…latform view (#16068)
Chris Yang authoredJan 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 0889e97 - Browse repository at this point
Copy the full SHA 0889e97View commit details -
Revert "Disable setting a library tag handler." (#16157)
This reverts commit ef3aa01. This address the use case of an internal customer. In a subsequent patch, I will add a test for this functionality. Instead of removing support for the same from tonic (along with the stuff surrounding filesystem access and package map handling), I’ll rework the same to use FML to avoid code duplication and maintainability.
Configuration menu - View commit details
-
Copy full SHA for 5a1439c - Browse repository at this point
Copy the full SHA 5a1439cView commit details -
Roll fuchsia/sdk/core/mac-amd64 from gNitp... to 5fMtM... (#16153)
Roll fuchsia/sdk/core/mac-amd64 from gNitp... to 5fMtM... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for a851d1e - Browse repository at this point
Copy the full SHA a851d1eView commit details -
Revert "Always make gpu thread different from platform thread regardl…
Chris Yang authoredJan 28, 2020 Configuration menu - View commit details
-
Copy full SHA for ec32966 - Browse repository at this point
Copy the full SHA ec32966View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c4229bfbbae4...ec32966e030a