This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Gets the DPI for all awareness mode and older Windows versions #15951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had a quick skim through but need to do a more careful review. One alarm-bell is that you appear to no longer be enabling non-client scaling which means you aren’t leveraging PerMonitor V2 on up-level machines which is a regression to what’s checked in. Is that a deliberate decision? |
clarkezone
reviewed
Jan 24, 2020
|
|
||
| if (!AssignProcAddress(user32_module_, "SetProcessDpiAwarenessContext", | ||
| set_process_dpi_awareness_context_)) { | ||
| return; |
There was a problem hiding this comment.
SetProcessDpiAwarenessContext is the most recent version of the API.. any reason why you chose not to use this if available?
Contributor
Author
There was a problem hiding this comment.
I just removed it since it's not being used anywhere, and we would want the dpi awareness to be set by the runner app, in the manifest anyway. Is there any reason to keep it?
Contributor
Author
|
Yeah, I left a comment in the description, but should've pointed it out in the code. I removed it since it can only be called for the creation of the top-level window, which is created in the runner. As far as I can tell, that wall wasn't really doing anything. Do I understand that correctly? |
|
Yes, good point, I was reading this in isolation and not considering the runner side of the fence. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 28, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 28, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 28, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 29, 2020
flutter/engine@c4229bf...ec32966 git log c4229bf..ec32966 --first-parent --oneline 2020-01-28 ychris@google.com Revert "Always make gpu thread different from platform thread regardless of platform view (#16068)" (flutter/engine#16161) 2020-01-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from gNitp... to 5fMtM... (flutter/engine#16153) 2020-01-28 chinmaygarde@google.com Revert "Disable setting a library tag handler." (flutter/engine#16157) 2020-01-28 ychris@google.com Always make gpu thread different from platform thread regardless of platform view (flutter/engine#16068) 2020-01-28 chinmaygarde@google.com Add test to ensure that concurrent message loops have at least one workers. (flutter/engine#16074) 2020-01-28 dnfield@google.com Revert breaking PRs (flutter/engine#16148) 2020-01-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 8Ns10... to 2rLoq... (flutter/engine#15971) 2020-01-28 franciscojma86@gmail.com Gets the DPI for all awareness mode and older Windows versions (flutter/engine#15951) 2020-01-28 chinmaygarde@google.com Hold a mutex when updating all CanPostTaskToAllNativeThreads::Captures members. (flutter/engine#16085) 2020-01-28 chinmaygarde@google.com Disable setting a library tag handler. (flutter/engine#16086) 2020-01-28 garyq@google.com Web PargraphStyle TextHeightBehavior integration (flutter/engine#16075) 2020-01-28 chinmaygarde@google.com Fix flake by making thread ID tracking in CanPostTaskToAllNativeThreads thread safe. (flutter/engine#16081) 2020-01-28 chinmaygarde@google.com Remove buggy assertion in EmbedderTest::CanPostTaskToAllNativeThreads. (flutter/engine#16071) 2020-01-27 chinmaygarde@google.com Remove tonic/platform. (flutter/engine#16062) 2020-01-27 chinmaygarde@gmail.com Allow embedders to schedule a callback on all engine managed threads. (flutter/engine#15980) 2020-01-27 garyq@google.com Engine/LibTxt/dart:ui impl of TextHeightBehavior (flutter/engine#15087) 2020-01-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia f1b2b42613cb..9c1d30dd163e (8 commits) (flutter/engine#16060) 2020-01-27 chinmaygarde@google.com Remove stale recipe changelog. (flutter/engine#15985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
flutter#15951)" This reverts commit d0bb4cd.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #12735.
Looks for the most modern API
GetDpiForWindowfirst, but falls back to older APIs if not available. If none of the APIs are available, default to a 96 DPI.Removed existing "
SetDpi*" APIs since the DPI awareness should be set by the runner app. Also removedEnableNonClientDpiScalingsince it should be called when the top-level window is created, which happens in the runner app.Tested: Changed the runner's manifest to all awareness modes, and tried all possible APIs. Haven't tested in non-Windows 10 machines.
Related to google/flutter-desktop-embedding#572