-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: 4dc8662
head repository: flutter/engine
compare: ae2dbef
- 14 commits
- 39 files changed
- 7 contributors
Commits on Aug 20, 2020
-
Clean up scenario app scripts (#20641)
I just made a pass on the scenario scripts so that they can be more easily run from the scenario directory, set the ANDROID_HOME correctly, and generally fixed lint errors. Also compile_android_aot.sh didn't appear to work, and I think I fixed it (it builds now).
Configuration menu - View commit details
-
Copy full SHA for d1e9017 - Browse repository at this point
Copy the full SHA d1e9017View commit details -
Roll Skia from 17c5b70 to e1e2408 (20 revisions) (#20656)
Manual land of roll - two bots on luci-engine are red due to flakes. https://skia.googlesource.com/skia.git/+log/17c5b7024297..e1e240804211 2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ff3c275665f9 to e45f0c4dce5a (503 revisions) 2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from b54c82ed3948 to eff9ef0f2212 (2 revisions) 2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 699bcde to 5dff607 (19 revisions) 2020-08-20 mtklein@google.com Revert "Add utilities to SkGeometry for quad and cubic rotation angles" 2020-08-20 mtklein@google.com Revert "remove sksl interpreter guards" 2020-08-20 ethannicholas@google.com Revert "Added support for the 'inline' hint on SkSL functions" 2020-08-20 ethannicholas@google.com Revert "SkSL CPP and H backends no longer emitted in non-dev builds" 2020-08-20 ethannicholas@google.com Revert "SkSL now supports uniform array types" 2020-08-19 csmartdalton@google.com Move GrWangsFormula::nextlog2 to sk_float_nextlog2 2020-08-19 johnstiles@google.com Remove final vestiges of sk_InColor. 2020-08-19 ethannicholas@google.com SkSL now supports uniform array types 2020-08-19 csmartdalton@google.com Add utilities to SkGeometry for quad and cubic rotation angles 2020-08-19 mtklein@google.com update placeholder approx op count 2020-08-19 johnstiles@google.com Remove sk_InColor from unit tests. 2020-08-19 adlai@google.com Remove GrContext variant of SkImageGenerator::isValid 2020-08-19 johnstiles@google.com Fix simplification of switch statements with casts. 2020-08-19 reed@google.com pass 'nested' bool to approximateOpCount 2020-08-19 mtklein@google.com clean up SK_LATE_DITHER 2020-08-19 ethannicholas@google.com Added support for the 'inline' hint on SkSL functions 2020-08-19 mtklein@google.com remove sksl interpreter guards If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 1c2637d - Browse repository at this point
Copy the full SHA 1c2637dView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcd51b8 - Browse repository at this point
Copy the full SHA dcd51b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87be540 - Browse repository at this point
Copy the full SHA 87be540View commit details -
Use references for C++ MethodResult and EventSink (#20651)
The response APIs for method channels and event channels used pointers for optional parameters; this kept the API surface simple, but meant that they couldn't take rvalues. As a result, returning success values or error details often took an extra line, declaring a variable for the result just to have something to pass the address of. This converts them to using references, with function overloading to allow for optional parameters, so that values can be inlined. For now the pointer versions are still present, so that conversion can be done before it becomes a breaking change; they will be removed soon. Part of flutter/flutter#63975
Configuration menu - View commit details
-
Copy full SHA for 60b8d00 - Browse repository at this point
Copy the full SHA 60b8d00View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe596f8 - Browse repository at this point
Copy the full SHA fe596f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ed30df - Browse repository at this point
Copy the full SHA 2ed30dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38a3029 - Browse repository at this point
Copy the full SHA 38a3029View commit details -
Add null checks for CanvasElement attributes (#20580)
Changes in processing compatibility info in dart:html requires these getters to be null-checked.
Configuration menu - View commit details
-
Copy full SHA for 68b5337 - Browse repository at this point
Copy the full SHA 68b5337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9336f5d - Browse repository at this point
Copy the full SHA 9336f5dView commit details -
[windows] Mostly eliminate the state structs (#20662)
The Windows embedding was based on the GLFW embedding, which grew organically from a singe-file implementation that used structs to manage all of the important state. It is in the process of being converted to a cleaner object-based architecture, but currently it is a hybrid of objects and structs that have redundant data, making it very prone to errors of forgetting to update pointers in multiple locations. This reduces the remaining structs to only a single pointer to the larger object that manages the responsibilities that handle is associated with, so that there is no need to wire things together in multiple places. For now they continue to exist as projections of the larger objects, but that will be eliminated over time by having an object structure that better reflects the API structure. Fixes flutter/flutter#64250
Configuration menu - View commit details
-
Copy full SHA for 498dbc6 - Browse repository at this point
Copy the full SHA 498dbc6View commit details
Commits on Aug 21, 2020
-
Enable ios platform view by default (#20671)
Chris Yang authoredAug 21, 2020 Configuration menu - View commit details
-
Copy full SHA for b603506 - Browse repository at this point
Copy the full SHA b603506View commit details -
Fix the format script so that it works with deleted files. (#20679)
When I rewrote the format script, I forgot to filter out deleted files from the list of files that it looks at. This filters the file list to exclude deleted files
Configuration menu - View commit details
-
Copy full SHA for ea971c5 - Browse repository at this point
Copy the full SHA ea971c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae2dbef - Browse repository at this point
Copy the full SHA ae2dbefView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4dc8662...ae2dbef