Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4dc8662
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ae2dbef
Choose a head ref
  • 14 commits
  • 39 files changed
  • 7 contributors

Commits on Aug 20, 2020

  1. Clean up scenario app scripts (#20641)

    I just made a pass on the scenario scripts so that they can be more easily run from the scenario directory, set the ANDROID_HOME correctly, and generally fixed lint errors.
    
    Also compile_android_aot.sh didn't appear to work, and I think I fixed it (it builds now).
    gspencergoog authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    d1e9017 View commit details
    Browse the repository at this point in the history
  2. Roll Skia from 17c5b70 to e1e2408 (20 revisions) (#20656)

    Manual land of roll - two bots on luci-engine are red due to flakes.
    
    https://skia.googlesource.com/skia.git/+log/17c5b7024297..e1e240804211
    
    2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ff3c275665f9 to e45f0c4dce5a (503 revisions)
    2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from b54c82ed3948 to eff9ef0f2212 (2 revisions)
    2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 699bcde to 5dff607 (19 revisions)
    2020-08-20 mtklein@google.com Revert "Add utilities to SkGeometry for quad and cubic rotation angles"
    2020-08-20 mtklein@google.com Revert "remove sksl interpreter guards"
    2020-08-20 ethannicholas@google.com Revert "Added support for the 'inline' hint on SkSL functions"
    2020-08-20 ethannicholas@google.com Revert "SkSL CPP and H backends no longer emitted in non-dev builds"
    2020-08-20 ethannicholas@google.com Revert "SkSL now supports uniform array types"
    2020-08-19 csmartdalton@google.com Move GrWangsFormula::nextlog2 to sk_float_nextlog2
    2020-08-19 johnstiles@google.com Remove final vestiges of sk_InColor.
    2020-08-19 ethannicholas@google.com SkSL now supports uniform array types
    2020-08-19 csmartdalton@google.com Add utilities to SkGeometry for quad and cubic rotation angles
    2020-08-19 mtklein@google.com update placeholder approx op count
    2020-08-19 johnstiles@google.com Remove sk_InColor from unit tests.
    2020-08-19 adlai@google.com Remove GrContext variant of SkImageGenerator::isValid
    2020-08-19 johnstiles@google.com Fix simplification of switch statements with casts.
    2020-08-19 reed@google.com pass 'nested' bool to approximateOpCount
    2020-08-19 mtklein@google.com clean up SK_LATE_DITHER
    2020-08-19 ethannicholas@google.com Added support for the 'inline' hint on SkSL functions
    2020-08-19 mtklein@google.com remove sksl interpreter guards
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC stani@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
    skia-flutter-autoroll authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    1c2637d View commit details
    Browse the repository at this point in the history
  3. Revert "account for inline placeholders in longest line calculation (#…

    …20370)" (#20669)
    
    This reverts commit 9893a29.
    
    Landing on red to fix the build.
    zanderso authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    dcd51b8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    87be540 View commit details
    Browse the repository at this point in the history
  5. Use references for C++ MethodResult and EventSink (#20651)

    The response APIs for method channels and event channels used pointers
    for optional parameters; this kept the API surface simple, but meant
    that they couldn't take rvalues. As a result, returning success values
    or error details often took an extra line, declaring a variable for the
    result just to have something to pass the address of.
    
    This converts them to using references, with function overloading to
    allow for optional parameters, so that values can be inlined.
    
    For now the pointer versions are still present, so that conversion can
    be done before it becomes a breaking change; they will be removed soon.
    
    Part of flutter/flutter#63975
    stuartmorgan-g authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    60b8d00 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fe596f8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2ed30df View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    38a3029 View commit details
    Browse the repository at this point in the history
  9. Add null checks for CanvasElement attributes (#20580)

    Changes in processing compatibility info in dart:html requires
    these getters to be null-checked.
    srujzs authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    68b5337 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9336f5d View commit details
    Browse the repository at this point in the history
  11. [windows] Mostly eliminate the state structs (#20662)

    The Windows embedding was based on the GLFW embedding, which grew
    organically from a singe-file implementation that used structs to manage
    all of the important state. It is in the process of being converted to a
    cleaner object-based architecture, but currently it is a hybrid of
    objects and structs that have redundant data, making it very prone to
    errors of forgetting to update pointers in multiple locations.
    
    This reduces the remaining structs to only a single pointer to the
    larger object that manages the responsibilities that handle is
    associated with, so that there is no need to wire things together in
    multiple places.
    
    For now they continue to exist as projections of the larger objects, but
    that will be eliminated over time by having an object structure that
    better reflects the API structure.
    
    Fixes flutter/flutter#64250
    stuartmorgan-g authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    498dbc6 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Enable ios platform view by default (#20671)

    Chris Yang authored Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b603506 View commit details
    Browse the repository at this point in the history
  2. Fix the format script so that it works with deleted files. (#20679)

    When I rewrote the format script, I forgot to filter out deleted files from the list of files that it looks at. This filters the file list to exclude deleted files
    gspencergoog authored Aug 21, 2020
    Configuration menu
    Copy the full SHA
    ea971c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae2dbef View commit details
    Browse the repository at this point in the history
Loading