Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Paragraph.longest_line_ to account for trailing inline placeholders#20370

Merged
LongCatIsLooong merged 1 commit intoflutter:masterfrom
LongCatIsLooong:longest-line-inline-placeholders
Aug 11, 2020
Merged

Paragraph.longest_line_ to account for trailing inline placeholders#20370
LongCatIsLooong merged 1 commit intoflutter:masterfrom
LongCatIsLooong:longest-line-inline-placeholders

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Aug 10, 2020 •
edited
Loading

Description

Inline placeholders need to report their real widths instead of the width of objReplacementChar during the longest_line_ calculation.

Related Issues

Fixes flutter/flutter#62551

Tests

I added the following tests:

  • InlinePlaceholderLongestLine

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@auto-assign auto-assign bot requested a review from flar August 10, 2020 09:38
@LongCatIsLooong LongCatIsLooong removed the request for review from flar August 10, 2020 09:40
justinmc
justinmc approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LongCatIsLooong LongCatIsLooong merged commit 9893a29 into flutter:master Aug 11, 2020
@LongCatIsLooong LongCatIsLooong deleted the longest-line-inline-placeholders branch August 11, 2020 23:23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 12, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2020
@engine-flutter-autoroll
9893a29 account for inline placeholders in longest line calculation (f…
1e1ef7f 
…lutter/engine#20370)
zanderso added a commit that referenced this pull request Aug 20, 2020
@zanderso
Revert "account for inline placeholders in longest line calculation (#…
1d7ba67 
…20370)"

This reverts commit 9893a29.
@zanderso zanderso mentioned this pull request Aug 20, 2020
Merged
zanderso added a commit that referenced this pull request Aug 20, 2020
@zanderso
Revert "account for inline placeholders in longest line calculation (#…
dcd51b8 
…20370)" (#20669)

This reverts commit 9893a29.

Landing on red to fix the build.
LongCatIsLooong added a commit that referenced this pull request Aug 20, 2020
@LongCatIsLooong
Revert "Revert "account for inline placeholders in longest line calcu…
07b3273 
…lation (#20370)" (#20669)"

This reverts commit dcd51b8.
LongCatIsLooong added a commit to LongCatIsLooong/engine that referenced this pull request Aug 20, 2020
@LongCatIsLooong
Reland "account for inline placeholders in longest line calculation (f…
165468a 
…lutter#20370)" reverted in (flutter#20669)

This reverts commit dcd51b8.
LongCatIsLooong added a commit to LongCatIsLooong/engine that referenced this pull request Aug 21, 2020
@LongCatIsLooong
Reland "account for inline placeholders in longest line calculation (f…
29e202b 
…lutter#20370)" reverted in (flutter#20669)

This reverts commit dcd51b8.
LongCatIsLooong added a commit to LongCatIsLooong/engine that referenced this pull request Aug 21, 2020
@LongCatIsLooong
Reland "account for inline placeholders in longest line calculation (f…
74c1d2e 
…lutter#20370)" reverted in (flutter#20669)

This reverts commit dcd51b8.
LongCatIsLooong added a commit to LongCatIsLooong/engine that referenced this pull request Aug 21, 2020
@LongCatIsLooong
Reland "account for inline placeholders in longest line calculation (f…
79ab94a 
…lutter#20370)" reverted in (flutter#20669)

This reverts commit dcd51b8.
fluttergithubbot pushed a commit that referenced this pull request Aug 21, 2020
@LongCatIsLooong
Reland "account for inline placeholders in longest line calculation (#…
d6a0b96 
…20370)" reverted in (#20669) (#20678)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GaryQian GaryQian Awaiting requested review from GaryQian

1 more reviewer

@justinmc justinmc justinmc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When adding in-line WidgetSpans, Richtext width is measured incorrectly

3 participants

@LongCatIsLooong @justinmc @googlebot