feat: add trtllm all-reduce (non-MoE)#1096
Merged
yzh119 merged 40 commits intoflashinfer-ai:mainfrom Jun 2, 2025
Merged
Conversation
9 tasks
2 tasks
Contributor
|
Thanks for supporting this! I wonder what are the major performance benefits compared to NCCL and if there are benchmark numbers? |
yzh119
reviewed
Jun 2, 2025
|
|
||
| # NOTE(Yingyi): The customAllReduce and allReduceFusion require different buffer size | ||
| # since allreduceFusion kernels are an improved implementation | ||
| # todo(review): align the ipc buffer size to tllm implementation |
Collaborator
There was a problem hiding this comment.
I can confirm the values are aligned.
yzh119
reviewed
Jun 2, 2025
|
|
||
|
|
||
| # todo(review): align the ipc buffer size to tllm implementation | ||
| BarrierFlagCount = 256 |
Collaborator
There was a problem hiding this comment.
Better to confirm with trtllm team.
yzh119
approved these changes
Jun 2, 2025
Collaborator
yzh119
left a comment
There was a problem hiding this comment.
Overall LGTM, let's move on to the following comm ops (moe).
5 tasks
5 tasks
yyihuang
added a commit
that referenced
this pull request
Jun 4, 2025
…#1111) <!-- .github/pull_request_template.md --> ## 📌 Description Lamport buffer should be initialized to neg_zero only once after creating new workspace. No need to re-init between each all-reduce. ## 🔍 Related Issues related PRs: #1096 ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [x] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. -->
5 tasks
joker-eph
reviewed
Aug 5, 2025
| #define FLASHINFER_LOGGING_H_ | ||
|
|
||
| #include <spdlog/sinks/stdout_color_sinks.h> | ||
| #include <spdlog/spdlog.h> |
Collaborator
There was a problem hiding this comment.
Seems like you introduced a new dependency here? Is this documented anywhere? (this breaks the build on my machine, and pip install spdlog didn't fix it).
Collaborator
There was a problem hiding this comment.
Seems like a submodule was later added which may solves this.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
We add trt-llm custom all-reduce to flashinfer comm module.
🔍 Related Issues
We split this PR into multiple.
#1061
MoE kernels are also in progress.
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes