fix: initialize lamport buffer only once after creating new workspace#1111
Merged
yyihuang merged 7 commits intoflashinfer-ai:mainfrom Jun 4, 2025
Merged
fix: initialize lamport buffer only once after creating new workspace#1111yyihuang merged 7 commits intoflashinfer-ai:mainfrom
yyihuang merged 7 commits intoflashinfer-ai:mainfrom
Conversation
yzh119
approved these changes
Jun 3, 2025
Collaborator
yzh119
left a comment
There was a problem hiding this comment.
LGTM, the tolerance for bf16 seems look too high to me, we will investigate it later.
yzh119
reviewed
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Lamport buffer should be initialized to neg_zero only once after creating new workspace. No need to re-init between each all-reduce.
🔍 Related Issues
related PRs: #1096
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.). Note: replace assertion to printed error message.Reviewer Notes