feat: move AR fusion kernels from trtllm#1061
Closed
yyihuang wants to merge 36 commits intoflashinfer-ai:mainfrom
Closed
feat: move AR fusion kernels from trtllm#1061yyihuang wants to merge 36 commits intoflashinfer-ai:mainfrom
yyihuang wants to merge 36 commits intoflashinfer-ai:mainfrom
Conversation
5 tasks
…to trt_ar_fusion
…to trt_ar_fusion
…into trt_ar_fusion
…into trt_ar_fusion
…into trt_ar_fusion
2 tasks
5 tasks
Collaborator
|
Closed for now because it introduce deep trtllm dependency and hard to maintain.
|
yzh119
added a commit
that referenced
this pull request
Jun 2, 2025
<!-- .github/pull_request_template.md --> ## 📌 Description We add trt-llm custom all-reduce to flashinfer comm module. ## 🔍 Related Issues We split this PR into multiple. #1061 MoE kernels are also in progress. ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> --------- Co-authored-by: Zihao Ye <expye@outlook.com>
5 tasks
yzh119
added a commit
that referenced
this pull request
Jun 17, 2025
<!-- .github/pull_request_template.md --> ## 📌 Description We try to add moe_all_reduce_fusion kernels from trt-llm. ## 🔍 Related Issues We split this PR into multiple ones. #1061 And all_reduce_fusion will be the next. ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [x] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. --> --------- Co-authored-by: Zihao Ye <expye@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move All-reduce fusion kernels from trtllm to flashinfer
Requirements:
Changes:
To be discussed:
next todo: