Skip to content

TextInput: Added new docs for PasswordRules Prop#1615

Merged
nearestnabors merged 1 commit intofacebook:masterfrom
espipj:Docs-TextInput
Feb 10, 2020
Merged

TextInput: Added new docs for PasswordRules Prop#1615
nearestnabors merged 1 commit intofacebook:masterfrom
espipj:Docs-TextInput

Conversation

@espipj
Copy link
Copy Markdown
Contributor

@espipj espipj commented Feb 9, 2020

This prop which was added on here wasn't documented in the docs nor in the API. Related with #1579

@react-native-bot
Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit a4639ec

https://deploy-preview-1615--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@espipj espipj requested a review from nearestnabors February 9, 2020 14:31
@Naturalclar
Copy link
Copy Markdown
Contributor

there was a typo in the passwordRules prop, which will be fixed in this PR facebook/react-native#27999.
The document should also reflect the change

@espipj
Copy link
Copy Markdown
Contributor Author

espipj commented Feb 10, 2020

Hey @Naturalclar it seems that your PR is pointing to react-native core repo but this PR is making changes in the docs website itself. I'll update the prop name though, thanks

Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks so much!

@nearestnabors nearestnabors merged commit 9dbe637 into facebook:master Feb 10, 2020
kaioduarte pushed a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants