fix: prop name for passwordRules#27999
Closed
Naturalclar wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
Member
|
Thanks for adding the documentation too |
facebook-github-bot
approved these changes
Feb 8, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @Naturalclar in 3f5c42f. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: There was a typo in passwordRules prop for TextInput. ref: https://github.com/facebook/react-native/blob/master/ReactCommon/fabric/components/textinput/iostextinput/propsConversions.h#L106-L110 https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/RCTSinglelineTextInputViewConfig.js#L126 ## Changelog [iOS] [Fixed] - Fix prop name of passwordRules in TextInput Pull Request resolved: facebook#27999 Test Plan: run `flow` type check with TextInput that has `passwordRules` in the prop. Differential Revision: D19805819 Pulled By: TheSavior fbshipit-source-id: a59729c466eb3f47675c7f1472bec269d6c3ed5d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was a typo in passwordRules prop for TextInput.
ref:
https://github.com/facebook/react-native/blob/master/ReactCommon/fabric/components/textinput/iostextinput/propsConversions.h#L106-L110
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/RCTSinglelineTextInputViewConfig.js#L126
Changelog
[iOS] [Fixed] - Fix prop name of passwordRules in TextInput
Test Plan
run
flowtype check with TextInput that haspasswordRulesin the prop.