add passwordRules for textContentType newPassword#25407
Closed
pvinis wants to merge 1 commit intofacebook:masterfrom
Closed
add passwordRules for textContentType newPassword#25407pvinis wants to merge 1 commit intofacebook:masterfrom
passwordRules for textContentType newPassword#25407pvinis wants to merge 1 commit intofacebook:masterfrom
Conversation
Contributor
Author
🤔 |
facebook-github-bot
approved these changes
Jun 27, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @pvinis in dff3588. When will my fix make it into a release? | Upcoming Releases |
espipj
added a commit
to espipj/react-native
that referenced
this pull request
Feb 8, 2020
Most of it taken from PR facebook#25407
espipj
added a commit
to espipj/react-native-website
that referenced
this pull request
Feb 8, 2020
Most of this was taken from here facebook/react-native#25407
This was referenced Feb 9, 2020
nearestnabors
pushed a commit
to facebook/react-native-website
that referenced
this pull request
Feb 10, 2020
Most of this was taken from here facebook/react-native#25407
kaioduarte
pushed a commit
to kaioduarte/react-native-website
that referenced
this pull request
Feb 24, 2020
Most of this was taken from here facebook/react-native#25407
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: On `textContentType` `newPassword` on ios, there is another property called `passwordRules` on ios 12 that can give hints to the os to generate a password with specific requirements like [here](https://developer.apple.com/password-rules/). This is useful for apps that have a "register" screen with `emailAddress`/`username` and a `newPassword` fields, to let ios make a password that will satisfy the requirements and not one that might be not accepted after the user presses "register". ## Changelog [iOS] [Added] - PasswordRules for new password textContentType input fields Pull Request resolved: facebook#25407 Test Plan: This is a bit harder, but to test you need to make an app that has associated domains with an apple-app-site-association file on that domain, enable iCloud Keychain on the test device, and then iOS will suggest a password, otherwise you will just get a warning on Xcode saying "Couldn't suggest password because of: blabla". Differential Revision: D16028684 Pulled By: cpojer fbshipit-source-id: d22426e07f1db45d1f79f5dad81f1465a9701f0b
JackWillie
added a commit
to JackWillie/react-native-website
that referenced
this pull request
Nov 27, 2022
Most of this was taken from here facebook/react-native#25407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
textContentTypenewPasswordon ios, there is another property calledpasswordRuleson ios 12 that can give hints to the os to generate a password with specific requirements like here.This is useful for apps that have a "register" screen with
emailAddress/usernameand anewPasswordfields, to let ios make a password that will satisfy the requirements and not one that might be not accepted after the user presses "register".Changelog
[iOS] [Added] - PasswordRules for new password textContentType input fields
Test Plan
This is a bit harder, but to test you need to make an app that has associated domains with an apple-app-site-association file on that domain, enable iCloud Keychain on the test device, and then iOS will suggest a password, otherwise you will just get a warning on Xcode saying "Couldn't suggest password because of: blabla".