fix: remove extra json convert check#5501
Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom Oct 24, 2025
Merged
Conversation
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>
|
Contributor
Author
|
/ok-to-test sha=02d4fbb02ce2db3a193775d27bb5796b2799f96a |
moolen
approved these changes
Oct 24, 2025
Contributor
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
schwarlex
pushed a commit
to la-demos/vcluster-workshop-prep
that referenced
this pull request
Feb 11, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | patch | `0.20.3` -> `0.20.4` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.20.4`](https://github.com/external-secrets/external-secrets/releases/tag/v0.20.4) [Compare Source](external-secrets/external-secrets@v0.20.3...v0.20.4) Image: `ghcr.io/external-secrets/external-secrets:v0.20.4` Image: `ghcr.io/external-secrets/external-secrets:v0.20.4-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.20.4-ubi-boringssl` <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### General - fix: re-enable secretserver e2e tests by [@​moolen](https://github.com/moolen) in [#​5442](external-secrets/external-secrets#5442) - chore: update dependencies by [@​eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in [#​5462](external-secrets/external-secrets#5462) - chore: release helm chart for v0.20.3 by [@​Skarlso](https://github.com/Skarlso) in [#​5467](external-secrets/external-secrets#5467) - docs: remove jwt token authentication option from STSSessionToken generator by [@​liununu](https://github.com/liununu) in [#​5468](external-secrets/external-secrets#5468) - feat: re-implement e2e managed tests by [@​moolen](https://github.com/moolen) in [#​5444](external-secrets/external-secrets#5444) - docs: Update Segura DSM Branding by [@​chellin-segura](https://github.com/chellin-segura) in [#​5469](external-secrets/external-secrets#5469) - ref: simplify and document transform rewrite method by [@​riccardomc](https://github.com/riccardomc) in [#​5450](external-secrets/external-secrets#5450) - fix: put back the expires into the github generator by [@​Skarlso](https://github.com/Skarlso) in [#​5472](external-secrets/external-secrets#5472) - chore(charts): remove unused values from chart by [@​rkferreira](https://github.com/rkferreira) in [#​5334](external-secrets/external-secrets#5334) - feat(generators): add hex generator by [@​unique-jakub](https://github.com/unique-jakub) in [#​5314](external-secrets/external-secrets#5314) - fix: use GetClientCertificate in Vault Auth by [@​shaxbee](https://github.com/shaxbee) in [#​5441](external-secrets/external-secrets#5441) - feat(aws): add defining a resource policy via metadata for secretsmanager by [@​Skarlso](https://github.com/Skarlso) in [#​5399](external-secrets/external-secrets#5399) - fix: Webhook provider PushSecret not working by [@​Skarlso](https://github.com/Skarlso) in [#​5445](external-secrets/external-secrets#5445) - fix: remove the finalizer on namespace deletion by [@​Skarlso](https://github.com/Skarlso) in [#​5473](external-secrets/external-secrets#5473) - chore: update dependencies by [@​eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in [#​5487](external-secrets/external-secrets#5487) - fix: missing config-file for github action scanning by [@​Skarlso](https://github.com/Skarlso) in [#​5376](external-secrets/external-secrets#5376) - chore(build): Update ubi Docker builds to UBI9 by [@​IdanAdar](https://github.com/IdanAdar) in [#​5465](external-secrets/external-secrets#5465) - fix: typo in GitHub provider documentation by [@​gecube](https://github.com/gecube) in [#​5493](external-secrets/external-secrets#5493) - fix(oracle): prevent TCP connections leakage by [@​adutchak](https://github.com/adutchak) in [#​5491](external-secrets/external-secrets#5491) - docs(controller-options): typo in controller-options by [@​aslafy-z](https://github.com/aslafy-z) in [#​5496](external-secrets/external-secrets#5496) - chore(linter): fix linter issue in `api` and `cmd` package by [@​Lumexralph](https://github.com/Lumexralph) in [#​5413](external-secrets/external-secrets#5413) - fix: remove extra json convert check by [@​Skarlso](https://github.com/Skarlso) in [#​5501](external-secrets/external-secrets#5501) ##### Dependencies - chore(deps): bump actions/dependency-review-action from 4.8.0 to 4.8.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5454](external-secrets/external-secrets#5454) - chore(deps): bump ubi8/ubi from `534c2c0` to `2f698e1` by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5452](external-secrets/external-secrets#5452) - chore(deps): bump golang from 1.25.1 to 1.25.2 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5456](external-secrets/external-secrets#5456) - chore(deps): bump alpine from `4bcff63` to `4b7ce07` by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5451](external-secrets/external-secrets#5451) - chore(deps): bump github/codeql-action from 3.30.6 to 4.30.8 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5455](external-secrets/external-secrets#5455) - chore(deps): bump alpine from 3.22.1 to 3.22.2 in /e2e by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5457](external-secrets/external-secrets#5457) - chore(deps): bump golang from 1.25.1-bookworm to 1.25.2-bookworm in /e2e by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5460](external-secrets/external-secrets#5460) - chore(deps): bump click from 8.1.8 to 8.3.0 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5458](external-secrets/external-secrets#5458) - chore(deps): bump platformdirs from 4.4.0 to 4.5.0 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5459](external-secrets/external-secrets#5459) - chore(deps): bump idna from 3.10 to 3.11 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5461](external-secrets/external-secrets#5461) - chore(deps): bump softprops/action-gh-release from 2.3.4 to 2.4.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5453](external-secrets/external-secrets#5453) - chore(deps): bump github/codeql-action from 4.30.8 to 4.30.9 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5481](external-secrets/external-secrets#5481) - chore(deps): bump sigstore/cosign-installer from 3.10.0 to 4.0.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5480](external-secrets/external-secrets#5480) - chore(deps): bump anchore/sbom-action from 0.20.6 to 0.20.8 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5483](external-secrets/external-secrets#5483) - chore(deps): bump mkdocs-material from 9.6.21 to 9.6.22 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5485](external-secrets/external-secrets#5485) - chore(deps): bump charset-normalizer from 3.4.3 to 3.4.4 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5486](external-secrets/external-secrets#5486) - chore(deps): bump apache/skywalking-eyes from 0.7.0 to 0.8.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5484](external-secrets/external-secrets#5484) - chore(deps): bump aws-actions/configure-aws-credentials from [`06083b7`](external-secrets/external-secrets@06083b7) to [`5dc01db`](external-secrets/external-secrets@5dc01db) by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5482](external-secrets/external-secrets#5482) #### New Contributors - [@​liununu](https://github.com/liununu) made their first contribution in [#​5468](external-secrets/external-secrets#5468) - [@​chellin-segura](https://github.com/chellin-segura) made their first contribution in [#​5469](external-secrets/external-secrets#5469) - [@​unique-jakub](https://github.com/unique-jakub) made their first contribution in [#​5314](external-secrets/external-secrets#5314) - [@​adutchak](https://github.com/adutchak) made their first contribution in [#​5491](external-secrets/external-secrets#5491) **Full Changelog**: <external-secrets/external-secrets@v0.20.3...v0.20.4> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTkuMyIsInVwZGF0ZWRJblZlciI6IjQxLjE1OS4zIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
The refactor put in an extra if check that was causing problems.
Related Issue
Fixes #5492
Proposed Changes
How do you like to solve the issue and why?
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable