Skip to content

fix: remove the finalizer on namespace deletion#5473

Merged
Skarlso merged 6 commits intoexternal-secrets:mainfrom
Skarlso:namespace-finalizer
Oct 20, 2025
Merged

fix: remove the finalizer on namespace deletion#5473
Skarlso merged 6 commits intoexternal-secrets:mainfrom
Skarlso:namespace-finalizer

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 16, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Hopefully Fixes #5426

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@Skarlso
fix: remove the finalizer on namespace deletion
918cf94 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. size/xs labels Oct 16, 2025
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 16, 2025

/ok-to-test sha=918cf9470b95f5b871a2ff7b25c97e2c9676ffa7

@Skarlso Skarlso moved this to In Review in External Secrets Oct 16, 2025
@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 16, 2025

[Bot] - ❌ e2e for 918cf9470b95f5b871a2ff7b25c97e2c9676ffa7 failed

@Skarlso
stop ignoring a conflict error
701d998 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=701d9985cea3cd040793842430c6de21cb12fe44

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for 701d9985cea3cd040793842430c6de21cb12fe44 passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=701d9985cea3cd040793842430c6de21cb12fe44

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for 701d9985cea3cd040793842430c6de21cb12fe44 passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=701d9985cea3cd040793842430c6de21cb12fe44

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for 701d9985cea3cd040793842430c6de21cb12fe44 passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=701d9985cea3cd040793842430c6de21cb12fe44

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for 701d9985cea3cd040793842430c6de21cb12fe44 passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=ae0490f37ab8d667d852674240eeaef7f38d660a

evrardjp
evrardjp reviewed Oct 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good on principle. Conflict could be safely ignored if we consider the ns has been targeted for delete anyway. Let's hope this method will not be used outside delete ns in the future.

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ❌ e2e for ae0490f37ab8d667d852674240eeaef7f38d660a failed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

Ah this failure might actually be unrelated.

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=ae0490f37ab8d667d852674240eeaef7f38d660a

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for ae0490f37ab8d667d852674240eeaef7f38d660a passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=ae0490f37ab8d667d852674240eeaef7f38d660a

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for ae0490f37ab8d667d852674240eeaef7f38d660a passed

@gusfcarvalho
Copy link
Copy Markdown
Member

gusfcarvalho commented Oct 17, 2025

/ok-to-test sha=ae0490f37ab8d667d852674240eeaef7f38d660a

gusfcarvalho
gusfcarvalho previously approved these changes Oct 17, 2025
View reviewed changes
@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ❌ e2e for ae0490f37ab8d667d852674240eeaef7f38d660a failed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

Nooooooo :D

@evrardjp
Copy link
Copy Markdown
Contributor

evrardjp commented Oct 17, 2025

I read the pain so loudly it made my walls move.

@Skarlso
add after suite of removing all cluster external secrets
f3d0868 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the namespace-finalizer branch from bf6e97a to f3d0868 Compare October 17, 2025 19:37
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=f3d0868e5e282fb834262426750014253379f126

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for f3d0868e5e282fb834262426750014253379f126 passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=f3d0868e5e282fb834262426750014253379f126

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for f3d0868e5e282fb834262426750014253379f126 passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=f3d0868e5e282fb834262426750014253379f126

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for f3d0868e5e282fb834262426750014253379f126 passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 17, 2025

/ok-to-test sha=f3d0868e5e282fb834262426750014253379f126

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 17, 2025

[Bot] - ✅ e2e for f3d0868e5e282fb834262426750014253379f126 passed

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 18, 2025

/ok-to-test sha=f3d0868e5e282fb834262426750014253379f126

@eso-service-account-app
Copy link
Copy Markdown
Contributor

eso-service-account-app bot commented Oct 18, 2025

[Bot] - ✅ e2e for f3d0868e5e282fb834262426750014253379f126 passed

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Skarlso Skarlso merged commit 42c46d9 into external-secrets:main Oct 20, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in External Secrets Oct 20, 2025
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
@Skarlso @SamuelMolling
fix: remove the finalizer on namespace deletion (external-secrets#5473)
b819cbb 
* fix: remove the finalizer on namespace deletion

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

* stop ignoring a conflict error

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

* add after suite of removing all cluster external secrets

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
@clubanderson clubanderson mentioned this pull request Mar 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

@gusfcarvalho gusfcarvalho gusfcarvalho left review comments

@moolen moolen Awaiting requested review from moolen

@IdanAdar IdanAdar Awaiting requested review from IdanAdar

+1 more reviewer

@evrardjp evrardjp evrardjp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/bug Categorizes issue or PR as related to a bug. size/s size/xs

Projects

External Secrets
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Namespace finalizer not getting cleaned up causing hanging namespace deleting

4 participants

@Skarlso @gusfcarvalho @evrardjp @jakobmoellerdev