feat(aws): add defining a resource policy via metadata for secretsmanager#5399
Merged
Skarlso merged 6 commits intoexternal-secrets:mainfrom Oct 17, 2025
Merged
Conversation
…ager Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
5692c09 to
e339f60
Compare
Comment on lines
+889
to
+892
| if currentPolicy == policyJSON { | ||
| // nothing to do | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
this is a bytewise comparison for a json - isn't this going to sometimes diverge in order and we update when we don't need to? Do we / users care about this i.e. in terms of API rate limits?
Contributor
Author
There was a problem hiding this comment.
You're right. I should encode and map compare this instead. Thanks for the comment!
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
|
gusfcarvalho
approved these changes
Oct 17, 2025
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
…ager (external-secrets#5399) * feat(aws): add defining a resource policy via metadata for secretsmanager Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> * added stable comparison of the policies Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
What is the problem you're trying to solve?
Related Issue
Fixes #5395
Proposed Changes
How do you like to solve the issue and why?
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable