This repository was archived by the owner on Aug 2, 2021. It is now read-only.
pss: Use distance metric for test success#1672
Merged
nolash merged 1 commit intoethersphere:masterfrom Aug 20, 2019
Merged
Conversation
janos
reviewed
Aug 15, 2019
Member
janos
left a comment
There was a problem hiding this comment.
Changes look good to me. This PR is labeled still "in progress". Will there be more changes? Could you rebase on master to fix the linting error?
4244a0b to
348c604
Compare
zelig
approved these changes
Aug 16, 2019
Member
zelig
left a comment
There was a problem hiding this comment.
although prox send is promising more I think, namely to be sent to all NNs of all PO-closest node(s)
Contributor
Author
yeah this is just the guarantee not the possible collateral effects :) |
janos
approved these changes
Aug 20, 2019
chadsr
added a commit
to chadsr/swarm
that referenced
this pull request
Sep 23, 2019
* 'master' of github.com:ethersphere/swarm: chunk, storage: chunk.Store multiple chunk Put (ethersphere#1681) storage: fix pyramid chunker and hasherstore possible deadlocks (ethersphere#1679) pss: Use distance to determine single guaranteed recipient (ethersphere#1672) storage: fix possible hasherstore deadlock on waitC channel (ethersphere#1674) network: Add adaptive capabilities message (ethersphere#1619) p2p/protocols, p2p/testing; conditional propagation of context (ethersphere#1648) api/http: remove unnecessary conversion (ethersphere#1673) storage: fix LazyChunkReader.join potential deadlock (ethersphere#1670) HTTP API support for pinning contents (ethersphere#1658) pot: Add Distance methods with tests (ethersphere#1621) README.md: Update Vendored Dependencies section (ethersphere#1667) network, p2p, vendor: move vendored p2p/testing under swarm (ethersphere#1647) build, vendor: use go modules for vendoring (ethersphere#1532)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the introduction of the xor distance metric in the pot. It changes the success criteria of the
TestProxNetworktest inpssto use this distance metric.Is also removes the superfluous Handshake-related code in the test service constructor.