This repository was archived by the owner on Aug 2, 2021. It is now read-only.
HTTP API support for pinning contents#1658
Merged
zelig merged 6 commits intoethersphere:masterfrom Aug 14, 2019
fairDataSociety:feat/pinapi
Merged
HTTP API support for pinning contents#1658zelig merged 6 commits intoethersphere:masterfrom fairDataSociety:feat/pinapi
zelig merged 6 commits intoethersphere:masterfrom
fairDataSociety:feat/pinapi
Conversation
janos
reviewed
Aug 8, 2019
2 tasks
acud
reviewed
Aug 13, 2019
acud
reviewed
Aug 13, 2019
Contributor
acud
left a comment
There was a problem hiding this comment.
Just a couple of comments about method and type names in pin.go
acud
approved these changes
Aug 14, 2019
janos
approved these changes
Aug 14, 2019
zelig
approved these changes
Aug 14, 2019
Member
zelig
left a comment
There was a problem hiding this comment.
approve with minor suggestions to rename a few things
| return u.Scheme == "bzz-hash" | ||
| } | ||
|
|
||
| func (u *URI) Pin() bool { |
| isRaw bool | ||
| fileSize uint64 | ||
| pinCounter uint64 | ||
| // PinInfo is the struct that stores the information about pinned files |
Member
There was a problem hiding this comment.
should this just be Info. You know, no pkg prefix in names.
or call it Pin? maybe
| type PinInfo struct { | ||
| Address storage.Address | ||
| IsRaw bool | ||
| FileSize uint64 |
| Address storage.Address | ||
| IsRaw bool | ||
| FileSize uint64 | ||
| PinCounter uint64 |
Member
There was a problem hiding this comment.
would it not be more intuitive to call this Chunks?
chadsr
added a commit
to chadsr/swarm
that referenced
this pull request
Sep 23, 2019
* 'master' of github.com:ethersphere/swarm: chunk, storage: chunk.Store multiple chunk Put (ethersphere#1681) storage: fix pyramid chunker and hasherstore possible deadlocks (ethersphere#1679) pss: Use distance to determine single guaranteed recipient (ethersphere#1672) storage: fix possible hasherstore deadlock on waitC channel (ethersphere#1674) network: Add adaptive capabilities message (ethersphere#1619) p2p/protocols, p2p/testing; conditional propagation of context (ethersphere#1648) api/http: remove unnecessary conversion (ethersphere#1673) storage: fix LazyChunkReader.join potential deadlock (ethersphere#1670) HTTP API support for pinning contents (ethersphere#1658) pot: Add Distance methods with tests (ethersphere#1621) README.md: Update Vendored Dependencies section (ethersphere#1667) network, p2p, vendor: move vendored p2p/testing under swarm (ethersphere#1647) build, vendor: use go modules for vendoring (ethersphere#1532)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three HTTP API related to pinning is added
bin-pin:/?IsRaw=true to pin a raw file
bin-pin:/ to pin a collection