This repository was archived by the owner on Aug 2, 2021. It is now read-only.
p2p/protocols, p2p/testing; conditional propagation of context#1648
Merged
p2p/protocols, p2p/testing; conditional propagation of context#1648
Conversation
bafb94c to
2045ee2
Compare
786796d to
3bbdca3
Compare
Member
Author
thanks. |
2045ee2 to
b8b6b9a
Compare
skylenet
reviewed
Aug 14, 2019
p2p/protocols/protocol.go
Outdated
| types map[uint64]reflect.Type | ||
|
|
||
| // if the protocol allows for extending the p2p msg to propagate context | ||
| // even if set to true context will propagate only if the remote peer supports it |
Contributor
There was a problem hiding this comment.
The comment looks to be right if the property would be called EnableContext . I would suggest to adjust the comment or rename DisableContext to EnableContext
b8b6b9a to
c0de2b7
Compare
janos
reviewed
Aug 14, 2019
Member
janos
left a comment
There was a problem hiding this comment.
This implementation is very nice. I do not see that previous one had explicit tests, maybe we could add some later.
skylenet
approved these changes
Aug 15, 2019
acud
approved these changes
Aug 16, 2019
chadsr
added a commit
to chadsr/swarm
that referenced
this pull request
Sep 23, 2019
* 'master' of github.com:ethersphere/swarm: chunk, storage: chunk.Store multiple chunk Put (ethersphere#1681) storage: fix pyramid chunker and hasherstore possible deadlocks (ethersphere#1679) pss: Use distance to determine single guaranteed recipient (ethersphere#1672) storage: fix possible hasherstore deadlock on waitC channel (ethersphere#1674) network: Add adaptive capabilities message (ethersphere#1619) p2p/protocols, p2p/testing; conditional propagation of context (ethersphere#1648) api/http: remove unnecessary conversion (ethersphere#1673) storage: fix LazyChunkReader.join potential deadlock (ethersphere#1670) HTTP API support for pinning contents (ethersphere#1658) pot: Add Distance methods with tests (ethersphere#1621) README.md: Update Vendored Dependencies section (ethersphere#1667) network, p2p, vendor: move vendored p2p/testing under swarm (ethersphere#1647) build, vendor: use go modules for vendoring (ethersphere#1532)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the code related to context propagation within
p2p/protocols.The propagation of context is made conditional on a new
protocols.SpecfieldDisableContextin addition totracing.Enabled. This allows for disabling context propagation for specific protocols only.Fixes #1575