Docs cleanup and truffle usage by ben-chain · Pull Request #9 · ethereum-optimism/optimism

ben-chain · 2020-02-18T19:02:45Z

Description

Addresses YAS31 and YAS167 to fix some documentation formatting and add updated explanation for how to use Truffle.

Metadata

Fixes

Fixes YAS-31
Fixes YAS-167

Contributing Agreement

I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

willmeister

Looks like some unresolved conflicts are in there. Other than that looks good!

willmeister · 2020-02-18T19:21:41Z

packages/docs/src/core/src/spec/transpilation-details.rst

+<<<<<<< HEAD
+    - ``ADD, MUL, SUB, DIV, SDIV, MOD, SMOD, ADDMOD, MULMOD, EXP, SIGNEXTEND, LT, GT, SLT, SGT, EQ, ISZERO, AND, OR, XOR, NOT, BYT, SHL, SHR, SAAR, SHA3``.
+- \"Pure\" code execution operations: 
+   - ``PUSH1....PUSH32, DUP1...DUP16, SWAP1...SWAP16, POP, LOG0...LOG4, STOP, REVERT, RETURN, PC, GAS, JUMPDEST*``.  \* NOTE: `See section <https://github.com/op-optimism/optimistic-rollup/wiki/JUMP-Transpilation>`_ which involves ``JUMPDEST`` s.
+=======
   - ``ADD, MUL, SUB, DIV, SDIV, MOD, SMOD, ADDMOD, MULMOD, EXP, SIGNEXTEND, LT, GT, SLT, SGT, EQ, ISZERO, AND, OR, XOR, NOT, BYT, SHL, SHR, SAAR, SHA3``.
 - "Pure" code execution operations: 
   - ``PUSH1....PUSH32, DUP1...DUP16, SWAP1...SWAP16, POP, LOG0...LOG4, STOP, REVERT, RETURN, PC, GAS, JUMPDEST*``.  \* NOTE: `See section <https://github.com/op-optimism/optimistic-rollup/wiki/JUMP-Transpilation>`_ which involves ``JUMPDEST``s.
+>>>>>>> newrepo/master


This looks like an unresolved conflict. Choose one or the other and get rid of the metadata (<<<<<<< HEAD, ========, >>>>>>>).

willmeister · 2020-02-18T19:21:55Z

packages/docs/src/core/src/spec/transpilation-details.rst

+<<<<<<< HEAD
+=======


This looks like an unresolved conflict. Choose one or the other and get rid of the metadata (<<<<<<< HEAD, ========, >>>>>>>).

willmeister · 2020-02-18T19:22:02Z

packages/docs/src/core/src/spec/transpilation-details.rst

      - 2
    * - ``DELEGATECALL``
      - 2
+>>>>>>> newrepo/master


This looks like an unresolved conflict. Choose one or the other and get rid of the metadata (<<<<<<< HEAD, ========, >>>>>>>).

Add tests for message passing contracts

…ntracts-patch-1 Update README.md

Add explicit deadline to delegated attestation/revocation requests

88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50) 1146a08b5 localnet reorg fix (ethereum-optimism#76) 87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64) 9073baeaf localnet (#37) 1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51) 210aabe7a Update popm.go, fix typo (#40) a5e689493 make: automate copyright headers (#31) 1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33) 1be4df2a3 Use 'errors.Is' to compare errors (#32) 3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36) c5b0fea01 electrumx: add connection reuse and pooling (#26) cfc1293e9 Update README.md (#29) 8896259f0 retry mine keystone on failure (#18) a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27) 6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28) ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16) ac3b7eacb docker: update golang image to v1.22.1 (#25) d6b0ac8af returning response errors if they exist from bfg -> popm (#24) d450b787a Network test start height + no panic (#22) b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19) bfd3b1dc0 make: add -local flag to goimports (#9) e0e8964fc Move internal error into protocol package (#10) 7875a897c l2 keystone mining fixes (#3) git-subtree-dir: heminetwork git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10

* feat: add pc with abi * feat: add big pi store * refactor: minor rename * featL add built in pcs for preimage stores * refactor: generalize pi registry pc * fix: register pc pc on init * fix: pi pc source url * build: registry pcs abis * fix: account for built-in pcs * chore: remove commented out loc * fix: pc registry types * test: pc registry * refactor: minor change in built-in pcs * test: preimage registry * refactor: store big preimage size in big pi acc

Develop

* add docker file * makefile and minor fix --------- Co-authored-by: Vitalis Salis <vitsalis@gmail.com>

* update * support op conductor * update readme * update readme * docs(test): fix comments * test(conductor): optimize stop leader script * chore(test): tidy up test scripts * chore(op-geth): use dev branch of op-geth * update * update op-geth

feat(book): Supported targets

Gas consumption when executing registerLayer2Candidate function - When using ton.approveAndCall : 4939017 - When using ton.approve && wton.safeTransferFrom : 4909178 Using ton.approve && wton.safeTransferFrom uses 29839 less gas, so modify it to use ton.approve && wton.safeTransferFrom.

feat(book): Supported targets

Add onlyDelegateCall enforcement to upgradeSuperchain, upgrade, and migrate functions (#17). Include msg.sender in deploy salt to prevent cross-caller CREATE2 collisions (#17). Add duplicate instruction key detection in upgrade validation (#9). Validate startingRespectedGameType against enabled game configs (#10). Add code-existence check in loadBytes (#18). Add tests covering all audit fix behaviors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add onlyDelegateCall enforcement to upgradeSuperchain, upgrade, and migrate functions (#17). Include msg.sender in deploy salt to prevent cross-caller CREATE2 collisions (#17). Add duplicate instruction key detection in upgrade validation (#9). Validate startingRespectedGameType against enabled game configs (#10). Add code-existence check in loadBytes (#18). Add setUp guard to VerifyOPCM.runSingle (#4). Remove unused _findChar function (#5). Pass real AddressManager in migrator proxy deploy args (#11). Add tests covering all audit fix behaviors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…19272) * contracts: implement audit code fixes and add tests Add onlyDelegateCall enforcement to upgradeSuperchain, upgrade, and migrate functions (#17). Include msg.sender in deploy salt to prevent cross-caller CREATE2 collisions (#17). Add duplicate instruction key detection in upgrade validation (#9). Validate startingRespectedGameType against enabled game configs (#10). Add code-existence check in loadBytes (#18). Add setUp guard to VerifyOPCM.runSingle (#4). Remove unused _findChar function (#5). Pass real AddressManager in migrator proxy deploy args (#11). Add tests covering all audit fix behaviors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * contracts: regenerate semver-lock.json for OPContractsManagerV2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * contracts: bump OPContractsManagerV2 version to 7.0.10 Semver-diff requires a patch version bump when bytecode changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

willmeister and others added 4 commits February 15, 2020 08:47

Updating docs formatting

c56c194

improve formatting

5807eb5

update truffle usage command

068dc51

merge master:

b5406f3

ben-chain requested a review from willmeister February 18, 2020 19:02

willmeister approved these changes Feb 18, 2020

View reviewed changes

add missing merge resolution

f951c32

ben-chain merged commit 7b02e21 into master Feb 19, 2020

ben-chain deleted the feat/new-truffle-docs branch March 4, 2020 20:18

snario pushed a commit that referenced this pull request Apr 14, 2021

Merge pull request #9 from ethereum-optimism/feat/message-passing-tests

9c4eb7f

Add tests for message passing contracts

protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022

Merge pull request ethereum-optimism#9 from ethereum-optimism/smartco…

0d3e8dc

…ntracts-patch-1 Update README.md

refcell pushed a commit that referenced this pull request Sep 6, 2023

Merge pull request #9 from lbeder/fix18a

647d32d

Add explicit deadline to delegated attestation/revocation requests

mds1 mentioned this pull request Jun 14, 2024

[Tracker] Release: Upgrade #10 #10592

Closed

blockchaindevsh pushed a commit to blockchaindevsh/optimism that referenced this pull request Jun 24, 2024

Merge pull request ethereum-optimism#9 from ethstorage/develop

8b60814

Develop

bap2pecs referenced this pull request in babylonlabs-io/optimism Jul 31, 2024

Add docker file (#9)

cbd47c2

* add docker file * makefile and minor fix --------- Co-authored-by: Vitalis Salis <vitsalis@gmail.com>

blockchaindevsh pushed a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025

fix missing arg (ethereum-optimism#9)

48d461b

theochap pushed a commit that referenced this pull request Dec 10, 2025

Merge pull request #9 from anton-rs/cl/book-vm-support

97af0a5

feat(book): Supported targets

theochap pushed a commit that referenced this pull request Jan 14, 2026

Merge pull request #9 from anton-rs/cl/book-vm-support

334fd06

feat(book): Supported targets

smartcontracts mentioned this pull request Feb 22, 2026

contracts: implement onlyDelegateCall and add tests for audit fixes #19272

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docs cleanup and truffle usage#9

Docs cleanup and truffle usage#9
ben-chain merged 5 commits intomasterfrom
feat/new-truffle-docs

ben-chain commented Feb 18, 2020 •

edited by willmeister

Loading

Uh oh!

willmeister left a comment

Uh oh!

willmeister Feb 18, 2020

Uh oh!

willmeister Feb 18, 2020

Uh oh!

willmeister Feb 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		<<<<<<< HEAD
		=======

Conversation

ben-chain commented Feb 18, 2020 • edited by willmeister Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Metadata

Fixes

Contributing Agreement

Uh oh!

willmeister left a comment

Choose a reason for hiding this comment

Uh oh!

willmeister Feb 18, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Feb 18, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Feb 18, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ben-chain commented Feb 18, 2020 •

edited by willmeister

Loading