Add support for custom solc versions by masonforest · Pull Request #11 · ethereum-optimism/optimism

masonforest · 2020-02-19T21:47:04Z

Description

If the required version of solc isn't currently in use solc will download the required version of itself. Normally you can pass "version" in the the truffle config to trigger this behavior but our truffle version field is already filled with a path to our custom solc compiler. Instead we pass the environment variable SOLC_VERSION which triggers it.

Truffle expects compile to be synchronous so we can't do anything asynchronous in that function. To get around this we use execSync which executes synchronously.

Contributing Agreement

I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

If the required version of solc isn't currently in use solc will [1](download the required version of itself). Normally you can pass "version" in the the truffle config to trigger this behavior but our truffle version field is already filled with a path to our custom solc compiler. Instead we pass the enviroment variable `SOLC_VERSION` which triggers it. Truffle expects `compile` to be synchronous so we can't do anything asynchonous in that function. To get around this we use `execSync` which executes synchonously. [1]: https://github.com/ethereum/solc-js/blob/5c1280ca2c73dfba58bad21849b16eb1fa5618e5/README.md#using-a-legacy-version

karlfloersch · 2020-02-19T21:58:25Z

packages/solc-transpiler/src/compiler.ts

+    (async () => {
+      await process.stdout.write(await getSolcVersion("${versionString}"));
+    })();
+    `


Why do we have to use inline executed code btw? Just curious lol seems like a wild solution & I'm sure it has to do with truffle craziness

yeah, it's wackyness!

Since Truffle expects compile to be a synchronous function we can't do anything that's asynchronous in that function. The only way to make a web request "synchronously" in node is to fire up a whole other node process with execSync 🙃

https://stackoverflow.com/a/28394895

willmeister

Awesome approach! Left a few comments to think about, but whether you choose to run with them or ship this, I approve!

packages/solc-transpiler/src/compiler.ts

* pkg: Add DTL * fix: use correct tsconfig when building Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

…se-block-oracle Update spec to use block oracle terminology

Fix: set missing difficulty in block header

Add extra input length validation in multiRevoke and multiAttest functions

Develop

* feat: introduce OptimismSuperchainERC20 * fix: contract fixes * feat: add snapshots and semver * test: add supports interface tests * test: add invariant test * feat: add parameters to the RelayERC20 event * fix: typo * fix: from param description * fix: event signature and interface pragma * feat: add initializer * feat: use unstructured storage and OZ v5 * feat: update superchain erc20 interfaces * fix: adapt storage to ERC7201 * test: add initializable OZ v5 test * fix: invariant docs * fix: ERC165 implementation * test: improve superc20 invariant (#11) * fix: gas snapshot --------- Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>

* chore: configure medusa with basic supERC20 self-bridging (#19) - used --foundry-compile-all to ensure the test contract under `test/properties` is compiled (otherwise it is not compiled and medusa crashes when it can't find it's compiled representation) - set src,test,script to test/properties/medusa to not waste time compiling contracts that are not required for the medusa campaign - used an atomic bridge, which doesnt allow for testing of several of the proposed invariants fix: delete dead code test: give the fuzzer a head start docs: fix properties order test: document & implement assertions 22, 23 and 24 fix: fixes from self-review test: guide the fuzzer a little bit less previously: initial mint, bound on transfer amount: 146625 calls in 200s now: no initial mint, no bound on transfer amount: 176835 calls in 200s it doesn't seem to slow the fuzzer down fix: fixes after lovely feedback by disco docs: merge both documents and categorized properties by their milestone fix: fixes from parti's review fix: feedback from disco fix: feedback from doc refactor: separate state transitions from pure properties docs: update tested properties refactor: move all assertions into properties contract fix: move function without assertions back into handler test: only use assertion mode fix: improve justfile recipie for medusa * feat: halmos symbolic tests (#21) * feat: introduce OptimismSuperchainERC20 * fix: contract fixes * feat: add snapshots and semver * test: add supports interface tests * test: add invariant test * feat: add parameters to the RelayERC20 event * fix: typo * fix: from param description * fix: event signature and interface pragma * feat: add initializer * feat: use unstructured storage and OZ v5 * feat: update superchain erc20 interfaces * fix: adapt storage to ERC7201 * test: add initializable OZ v5 test * fix: invariant docs * fix: ERC165 implementation * test: improve superc20 invariant (#11) * fix: gas snapshot * chore: configure medusa with basic supERC20 self-bridging - used --foundry-compile-all to ensure the test contract under `test/properties` is compiled (otherwise it is not compiled and medusa crashes when it can't find it's compiled representation) - set src,test,script to test/properties/medusa to not waste time compiling contracts that are not required for the medusa campaign - used an atomic bridge, which doesnt allow for testing of several of the proposed invariants * fix: delete dead code * test: give the fuzzer a head start * feat: create suite for sybolic tests with halmos * test: setup and 3 properties with symbolic tests * chore: remove todo comment * docs: fix properties order * test: document & implement assertions 22, 23 and 24 * fix: fixes from self-review * test: guide the fuzzer a little bit less previously: initial mint, bound on transfer amount: 146625 calls in 200s now: no initial mint, no bound on transfer amount: 176835 calls in 200s it doesn't seem to slow the fuzzer down * feat: add property for burn * refactor: remove symbolic address on mint property * refactor: order the tests based on the property id * feat: checkpoint * chore: set xdomain sender on failing test * chore: enhance mocks * Revert "Merge branch 'chore/setup-medusa' into feat/halmos-symbolic-tests" This reverts commit 945d6b6, reversing changes made to 5dcb3a8. * refactor: remove symbolic addresses to make all of the test work * chore: remove console logs * feat: add properties file * chore: polish * refactor: enhance test on property 7 using direct try catch (now works) * fix: review comments * refactor: add symbolic addresses on test functions * feat: create halmos toml * chore: polish test contract and mock * chore: update property * refactor: move symbolic folder into properties one * feat: create advanced tests helper contract * refactor: enhance tests using symbolic addresses instead of concrete ones * chore: remove 0 property natspec * feat: add halmos profile and just script * chore: rename symbolic folder to halmos * feat: add halmos commands to justfile * chore: reorder assertions on one test * refactor: complete test property seven * chore: mark properties as completed * chore: add halmos-cheatcodes dependency * chore: rename advancedtest->halmosbase * chore: minimize mocked messenger * chore: delete empty halmos file * chore: revert changes to medusa.json * docs: update changes to PROPERTIES.md from base branch * test: sendERC20 destination fix * chore: natspec fixes --------- Co-authored-by: agusduha <agusnduha@gmail.com> Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: teddy <teddy@defi.sucks> * test: remaining protocol properties (#26) * test: cross-user fuzzed bridges + actor setup * test: fuzz properties 8 and 9 * test: properties 7 and 25 * fix: implement doc's feedback * test: superc20 tob properties (#27) * chore: add crytic/properties dependency * test: extend protocol properties so it also covers ToB erc20 properties * chore: small linter fixes * docs: update property list * test: handlers for remaining superc20 state transitions * fix: disable ToB properties we are not using and guide the fuzzer a bit more * fix: disable another ToB property not implemented by solady * chore: remove zero-initializations * fix: feedback from disco * chore: separate fuzz campaign tests in guided vs unguided * test: dont revert on successful unguided relay * test: add fuzzed calls to burn and mint * docs: document the separation of fuzz test functions * chore: move the properties file to its own directory * chore: consistently use fuzz_ and property_ + camelcase * chore: fix typo * chore: camelcase for handlers as well * fix: revert change that broke halmos campaign compile :D * test: fuzz non atomic bridging (#31) * test: changed mocked messenger ABI for message sending but kept assertions the same * docs: add new properties 26&27 * test: queue cross-chain messages and test related properties * test: relay random messages from queue and check associated invariants * chore: rename bridge->senderc20 method for consistency with relayerc20 * test: not-yet-deployed supertokens can get funds sent to them * chore: medusa runs forever by default doable since it also handles SIGINTs gracefully * chore: document the reason behind relay zero and send zero inconsistencies * fix: feedback from doc * fix: walk around possible medusa issue I'm getting an 'unknown opcode 0x4e' in ProtocolAtomic constructor when calling the MockL2ToL2CrossDomainMessenger for the first time * test: unguided handler for sendERC20 * fix: feedback from disco * chore: remove halmos testsuite * chore: foundry migration (#40) * chore: track assertion failures this is so foundry's invariant contract can check that an assertion returned false in the handler, while still allowing `fail_on_revert = false` so we can still take full advantage of medusa's fuzzer & coverage reports * fix: explicitly skip duplicate supertoken deployments * chore: remove duplicated PROPERTIES.md file * chore: expose data to foundry's external invariant checker * test: run medusa fuzzing campaign from within foundry * fix: eagerly check for duplicate deployments * fix: feedback from doc * chore: shoehorn medusa campaign into foundry dir structure * chore: remove PROPERTIES.md file * chore: delete medusa config * docs: limited support for subdirectories in test/invariant * chore: rename contracts to be more sneaky about medusa * docs: rewrite invariant docs in a way compliant with autogen scripts * chore: fixes from rebase * fix: cleanup superc20 invariants (#46) * chore: revert modifications from medusa campaign * docs: extra docs on why ForTest contract is required * doc: add list of all supertoken properties * chore: run forge fmt * ci: allow for testfiles to be deleted * fix: run doc autogen script after rebase --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: agusduha <agusnduha@gmail.com> Co-authored-by: 0xng <ng@defi.sucks>

…11776) * chore: configure medusa with basic supERC20 self-bridging (ethereum-optimism#19) - used --foundry-compile-all to ensure the test contract under `test/properties` is compiled (otherwise it is not compiled and medusa crashes when it can't find it's compiled representation) - set src,test,script to test/properties/medusa to not waste time compiling contracts that are not required for the medusa campaign - used an atomic bridge, which doesnt allow for testing of several of the proposed invariants fix: delete dead code test: give the fuzzer a head start docs: fix properties order test: document & implement assertions 22, 23 and 24 fix: fixes from self-review test: guide the fuzzer a little bit less previously: initial mint, bound on transfer amount: 146625 calls in 200s now: no initial mint, no bound on transfer amount: 176835 calls in 200s it doesn't seem to slow the fuzzer down fix: fixes after lovely feedback by disco docs: merge both documents and categorized properties by their milestone fix: fixes from parti's review fix: feedback from disco fix: feedback from doc refactor: separate state transitions from pure properties docs: update tested properties refactor: move all assertions into properties contract fix: move function without assertions back into handler test: only use assertion mode fix: improve justfile recipie for medusa * feat: halmos symbolic tests (ethereum-optimism#21) * feat: introduce OptimismSuperchainERC20 * fix: contract fixes * feat: add snapshots and semver * test: add supports interface tests * test: add invariant test * feat: add parameters to the RelayERC20 event * fix: typo * fix: from param description * fix: event signature and interface pragma * feat: add initializer * feat: use unstructured storage and OZ v5 * feat: update superchain erc20 interfaces * fix: adapt storage to ERC7201 * test: add initializable OZ v5 test * fix: invariant docs * fix: ERC165 implementation * test: improve superc20 invariant (ethereum-optimism#11) * fix: gas snapshot * chore: configure medusa with basic supERC20 self-bridging - used --foundry-compile-all to ensure the test contract under `test/properties` is compiled (otherwise it is not compiled and medusa crashes when it can't find it's compiled representation) - set src,test,script to test/properties/medusa to not waste time compiling contracts that are not required for the medusa campaign - used an atomic bridge, which doesnt allow for testing of several of the proposed invariants * fix: delete dead code * test: give the fuzzer a head start * feat: create suite for sybolic tests with halmos * test: setup and 3 properties with symbolic tests * chore: remove todo comment * docs: fix properties order * test: document & implement assertions 22, 23 and 24 * fix: fixes from self-review * test: guide the fuzzer a little bit less previously: initial mint, bound on transfer amount: 146625 calls in 200s now: no initial mint, no bound on transfer amount: 176835 calls in 200s it doesn't seem to slow the fuzzer down * feat: add property for burn * refactor: remove symbolic address on mint property * refactor: order the tests based on the property id * feat: checkpoint * chore: set xdomain sender on failing test * chore: enhance mocks * Revert "Merge branch 'chore/setup-medusa' into feat/halmos-symbolic-tests" This reverts commit 945d6b6, reversing changes made to 5dcb3a8. * refactor: remove symbolic addresses to make all of the test work * chore: remove console logs * feat: add properties file * chore: polish * refactor: enhance test on property 7 using direct try catch (now works) * fix: review comments * refactor: add symbolic addresses on test functions * feat: create halmos toml * chore: polish test contract and mock * chore: update property * refactor: move symbolic folder into properties one * feat: create advanced tests helper contract * refactor: enhance tests using symbolic addresses instead of concrete ones * chore: remove 0 property natspec * feat: add halmos profile and just script * chore: rename symbolic folder to halmos * feat: add halmos commands to justfile * chore: reorder assertions on one test * refactor: complete test property seven * chore: mark properties as completed * chore: add halmos-cheatcodes dependency * chore: rename advancedtest->halmosbase * chore: minimize mocked messenger * chore: delete empty halmos file * chore: revert changes to medusa.json * docs: update changes to PROPERTIES.md from base branch * test: sendERC20 destination fix * chore: natspec fixes --------- Co-authored-by: agusduha <agusnduha@gmail.com> Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: teddy <teddy@defi.sucks> * test: remaining protocol properties (ethereum-optimism#26) * test: cross-user fuzzed bridges + actor setup * test: fuzz properties 8 and 9 * test: properties 7 and 25 * fix: implement doc's feedback * test: superc20 tob properties (ethereum-optimism#27) * chore: add crytic/properties dependency * test: extend protocol properties so it also covers ToB erc20 properties * chore: small linter fixes * docs: update property list * test: handlers for remaining superc20 state transitions * fix: disable ToB properties we are not using and guide the fuzzer a bit more * fix: disable another ToB property not implemented by solady * chore: remove zero-initializations * fix: feedback from disco * chore: separate fuzz campaign tests in guided vs unguided * test: dont revert on successful unguided relay * test: add fuzzed calls to burn and mint * docs: document the separation of fuzz test functions * chore: move the properties file to its own directory * chore: consistently use fuzz_ and property_ + camelcase * chore: fix typo * chore: camelcase for handlers as well * fix: revert change that broke halmos campaign compile :D * test: fuzz non atomic bridging (ethereum-optimism#31) * test: changed mocked messenger ABI for message sending but kept assertions the same * docs: add new properties 26&27 * test: queue cross-chain messages and test related properties * test: relay random messages from queue and check associated invariants * chore: rename bridge->senderc20 method for consistency with relayerc20 * test: not-yet-deployed supertokens can get funds sent to them * chore: medusa runs forever by default doable since it also handles SIGINTs gracefully * chore: document the reason behind relay zero and send zero inconsistencies * fix: feedback from doc * fix: walk around possible medusa issue I'm getting an 'unknown opcode 0x4e' in ProtocolAtomic constructor when calling the MockL2ToL2CrossDomainMessenger for the first time * test: unguided handler for sendERC20 * fix: feedback from disco * chore: remove halmos testsuite * chore: foundry migration (ethereum-optimism#40) * chore: track assertion failures this is so foundry's invariant contract can check that an assertion returned false in the handler, while still allowing `fail_on_revert = false` so we can still take full advantage of medusa's fuzzer & coverage reports * fix: explicitly skip duplicate supertoken deployments * chore: remove duplicated PROPERTIES.md file * chore: expose data to foundry's external invariant checker * test: run medusa fuzzing campaign from within foundry * fix: eagerly check for duplicate deployments * fix: feedback from doc * chore: shoehorn medusa campaign into foundry dir structure * chore: remove PROPERTIES.md file * chore: delete medusa config * docs: limited support for subdirectories in test/invariant * chore: rename contracts to be more sneaky about medusa * docs: rewrite invariant docs in a way compliant with autogen scripts * chore: fixes from rebase * fix: cleanup superc20 invariants (ethereum-optimism#46) * chore: revert modifications from medusa campaign * docs: extra docs on why ForTest contract is required * doc: add list of all supertoken properties * chore: run forge fmt * ci: allow for testfiles to be deleted * fix: run doc autogen script after rebase --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: agusduha <agusnduha@gmail.com> Co-authored-by: 0xng <ng@defi.sucks>

✨ Updates

- Use revert instead of require - Don’t initialize zero values - Replacing Modifiers with Functions - Streamline return values - Use storage pointer - Variable packing

- Change storage structure - Delete unnecessary code

- Use revert instead of require - Make Solidity values constant where possible - Don’t initialize zero values - Replacing Modifiers with Functions

error InvalidCoinageError(); error OnlyLayer2ManagerError();

- Use revert instead of require - Replacing Modifiers with Functions

✨ Updates

chore: rename crates

Add onlyDelegateCall enforcement to upgradeSuperchain, upgrade, and migrate functions (#17). Include msg.sender in deploy salt to prevent cross-caller CREATE2 collisions (#17). Add duplicate instruction key detection in upgrade validation (#9). Validate startingRespectedGameType against enabled game configs (#10). Add code-existence check in loadBytes (#18). Add setUp guard to VerifyOPCM.runSingle (#4). Remove unused _findChar function (#5). Pass real AddressManager in migrator proxy deploy args (#11). Add tests covering all audit fix behaviors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…19272) * contracts: implement audit code fixes and add tests Add onlyDelegateCall enforcement to upgradeSuperchain, upgrade, and migrate functions (#17). Include msg.sender in deploy salt to prevent cross-caller CREATE2 collisions (#17). Add duplicate instruction key detection in upgrade validation (#9). Validate startingRespectedGameType against enabled game configs (#10). Add code-existence check in loadBytes (#18). Add setUp guard to VerifyOPCM.runSingle (#4). Remove unused _findChar function (#5). Pass real AddressManager in migrator proxy deploy args (#11). Add tests covering all audit fix behaviors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * contracts: regenerate semver-lock.json for OPContractsManagerV2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * contracts: bump OPContractsManagerV2 version to 7.0.10 Semver-diff requires a patch version bump when bytecode changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

karlfloersch reviewed Feb 19, 2020

View reviewed changes

willmeister approved these changes Feb 19, 2020

View reviewed changes

packages/solc-transpiler/src/compiler.ts Outdated Show resolved Hide resolved

packages/solc-transpiler/src/compiler.ts Show resolved Hide resolved

masonforest added 2 commits February 20, 2020 08:30

Address PR feedback

f3bff10

Format comment

ca22312

masonforest merged commit bbca409 into master Feb 20, 2020

masonforest deleted the YAS-183/HardenTheOvm/ResearchSolidityTesting branch March 23, 2020 13:22

gakonst added a commit that referenced this pull request Apr 12, 2021

pkg: Add DTL (#11)

8f5982d

* pkg: Add DTL * fix: use correct tsconfig when building Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021

pkg: Add DTL (#11)

2267370

* pkg: Add DTL * fix: use correct tsconfig when building Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022

Merge pull request ethereum-optimism#11 from ethereum-optimism/feat/u…

13d14f2

…se-block-oracle Update spec to use block oracle terminology

protolambda pushed a commit that referenced this pull request Jun 16, 2023

Merge pull request #11 from han0110/fix/missing-difficulty

8c7e622

Fix: set missing difficulty in block header

refcell pushed a commit that referenced this pull request Sep 6, 2023

Merge pull request #11 from lbeder/fix20

ee9a4a0

Add extra input length validation in multiRevoke and multiAttest functions

therealbytes added a commit to therealbytes/optimism that referenced this pull request May 17, 2024

refactor: rename concrete/wasm/bin and tinygo/std (ethereum-optimism#11)

afadf59

blockchaindevsh pushed a commit to blockchaindevsh/optimism that referenced this pull request Jun 24, 2024

Merge pull request ethereum-optimism#11 from ethstorage/develop

01089c5

Develop

bap2pecs referenced this pull request in babylonlabs-io/optimism Jul 31, 2024

Add commit randomness (#11)

c7d9a28

blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025

update fork section (ethereum-optimism#11)

43bed26

cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025

fix: set sequencer port by checking leader (ethereum-optimism#11)

b07ad65

theochap pushed a commit that referenced this pull request Dec 10, 2025

Merge pull request #11 from anton-rs/cl/cannon

8cc4481

✨ Updates

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

feat: extract the used gas log from the receipt ethereum-optimism#11

c82b815

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

refactor: �Modifications due to code merging ethereum-optimism#11

c29c821

- Change storage structure - Delete unnecessary code

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

refactor: refactor the OperatorFactory ethereum-optimism#11

9f1d90a

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

refactor: add errors ethereum-optimism#11

57b89f3

error InvalidCoinageError(); error OnlyLayer2ManagerError();

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

refactor: to reduce the used gas ethereum-optimism#11

830eb13

- Use revert instead of require - Replacing Modifiers with Functions

theochap pushed a commit that referenced this pull request Jan 14, 2026

Merge pull request #11 from anton-rs/cl/cannon

1b0b580

✨ Updates

theochap pushed a commit that referenced this pull request Jan 15, 2026

Merge pull request #11 from alloy-rs/matt/rename-crates

641fcd6

chore: rename crates

theochap pushed a commit that referenced this pull request Jan 21, 2026

Merge pull request #11 from alloy-rs/matt/rename-crates

9ab09df

chore: rename crates

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for custom solc versions#11

Add support for custom solc versions#11
masonforest merged 3 commits intomasterfrom
YAS-183/HardenTheOvm/ResearchSolidityTesting

masonforest commented Feb 19, 2020

Uh oh!

karlfloersch Feb 19, 2020 •

edited

Loading

Uh oh!

masonforest Feb 19, 2020

Uh oh!

willmeister left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

masonforest commented Feb 19, 2020

Description

Contributing Agreement

Uh oh!

karlfloersch Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

masonforest Feb 19, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

karlfloersch Feb 19, 2020 •

edited

Loading