feat: introduce OptimismSuperchainERC20#11256
Merged
tynes merged 22 commits intoethereum-optimism:developfrom Aug 13, 2024
Merged
feat: introduce OptimismSuperchainERC20#11256tynes merged 22 commits intoethereum-optimism:developfrom
tynes merged 22 commits intoethereum-optimism:developfrom
Conversation
tynes
reviewed
Jul 26, 2024
tynes
reviewed
Jul 26, 2024
tynes
reviewed
Jul 26, 2024
tynes
reviewed
Jul 26, 2024
Contributor
|
This is tied to the design of the factory described here: ethereum-optimism/design-docs#50 |
0xng
reviewed
Aug 1, 2024
tynes
reviewed
Aug 5, 2024
tynes
reviewed
Aug 5, 2024
tynes
reviewed
Aug 6, 2024
tynes
reviewed
Aug 6, 2024
Contributor
|
This generally looks good to me, would be ideal to have a test covering #11256 (comment) |
tynes
approved these changes
Aug 13, 2024
Contributor
|
Amazing work on this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #11244.
Tests
We added a single invariant test for now. We will leave the implementation of the rest further down the line. We created a ticket for this: #11255
Additional context
The contract uses solady. It's important to keep in mind solady has the following note: https://github.com/Vectorized/solady/blob/main/src/tokens/ERC20.sol#L9