Merged
Conversation
…p the sleep if it should immediately re-run
karlfloersch
approved these changes
Oct 5, 2020
Contributor
karlfloersch
left a comment
There was a problem hiding this comment.
This looks good! I'm unsure exactly what the removed recursion did, but it does seem on a surface level to be unneeded. Was this for restarting a failed service automatically?
| `Error sleeping in ScheduledTask! Continuing execution.`, | ||
| e | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
Sorry have been slow to review this but I've been trying to figure out what the change actually does 😅
Where does rerun take place now? Or is it just that this didn't need to be here generally?
Author
There was a problem hiding this comment.
The changed code is within a while(this.running) loop. So just jumping over the sleep makes it re-run immediately. The only material change is not churning through promises and instead continuing to loop within the same function.
karlfloersch
added a commit
that referenced
this pull request
Oct 7, 2020
This reverts commit dd9dd31.
tynes
pushed a commit
that referenced
this pull request
Oct 7, 2020
1 task
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* Final gas optimizations for CTC * delete and re-init * Fix issue with tests failing * Use encoding/decoding from core-utils * dev: Use eth-optimism/core-utils where applicable (#281) * Use core-utils where applicable * Further reduce utils * Update ovmCREATEEOA.spec.ts Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * remove unused import * Revert "remove unused import" This reverts commit 1df87926e7a3ca8ebdf7448ad5f0395fe7766ff7. * actually fix imports * A few more comments * address PR feedback - add comments, renaming vars * Optimization: Conditional Monotonicity Checking (#307) * trying it * cleanup * remove duplicate comment * fix docstring * fix var name * missing period Co-authored-by: Ben Jones <ben@pseudonym.party> Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com>
agusduha
pushed a commit
that referenced
this pull request
Mar 20, 2025
* fix: merge issues * fix: natspec * fix: test * fix: nit
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* chore(docs): label cleanup * fixes * fix: left-align kona derive badges
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Small PR cleaning up the test utilities in `op-alloy-registry`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now ScheduledTask, on which all microservices are based, does recursive calls when it doesn't need to. This fixes that.
Contributing Agreement