Merged
Conversation
This reverts commit dd9dd31.
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* fix: Make ovmSETNONCE monotonic * Use ovmINCREMENTNONCE instead * Fix build errors * fix remaining build errors * last commit was a lie
mslipper
pushed a commit
that referenced
this pull request
May 15, 2022
feat: add standalone BSS service
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
* chore: moved files to daemon package to avoid having more than one file as main package * chore: split create key into another func to generate mnemonic and create key with mnemonic * chore: modify to reuse home flag in another cli * chore: add generated data dir to config in eots init * feat: add key creation for eotsd cli * chore: add create btc key to eotsd doc * feat: add sign-schnorr command to etosd CLI * chore: add doc on eotsd sign-schnorr * chore: addressed comments on md for descriptions and eotsd keys example * chore: address comments on add keys command * fix: misspell provider -> provide * chore: address pr comments, mostly descriptions * chore: modified funcs to allow sign directly from private key * chore: add usage description to key-name flag * chore: remove update of keyring-backend in config * chore: add comment to keep mnemonic safe and example on how to use it * chore: moved create EOTS key to step 3, and EOTS start to step 4 * chore: update initKeyring to accept keyring-backend as parameter * chore: update NewLocalEOTSManager to accept keyring-backend as parameter * fix: update to use keyring from flag instead of config * chore: pass keyring backend to manager as param * chore: update sign-schnorr example * chore: update description of Sign Schnorr sig * chore: set section 3 to Keys Management and add subsections as key creation, key recovery and signing * feat: add option to look private key from btc-pk or key-name, if both options are provided, use the btc-pk * fix: lint * chore: add description of btc-pk to sign-schnorr command * chore: addressed comments in eots.md * chore: removed unused comment * chore: move SignSchnorrSigFromPrivKey to private * chore: move EOTSPrivKeyFromRecord to private * feat: add command to verify schnorr signature * chore: add print of success * chore: addressed comments of cli descriptions * fix: add defer to close db backend * chore: add test for sign and sign verify * chore: add old stdout back * fix: lint add err checks * chore: add check for different cases in sign schnorr from btc pk and key name
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* fix: publish trusted-sync to gchr * fix: nits * Update .github/workflows/publish.yaml --------- Co-authored-by: clabby <ben@clab.by>
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description When using [`thiserror::Error`][error] with `#[error(..)]` attributes, a `Display` impl [is generated for the error](https://github.com/dtolnay/thiserror?tab=readme-ov-file#details). This PR removes all hand-rolled Display impls for errors, using `thiserror::Error` with `#[error]` attributes on variants. [error]: https://docs.rs/thiserror/latest/thiserror/derive.Error.html
emhane
pushed a commit
that referenced
this pull request
Feb 3, 2026
Add support for `debug_executionWitness` API. This hasn't been tested, but I'll be able to test it soon once the backfill job completes. This code is mostly copied from here and adapted to work with our state provider: https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695 Fixes #190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #307
@tynes has been debugging most of today to figure out what was causing his tests to begin failing and it seems to have been something in this commit.
Let's add this back in ASAP but to unblock @tynes let's revert for now