Conversation
Contributor
|
Can you also remove optimistic game semantics from the various github actions? https://github.com/ethereum-optimism/optimism-monorepo/blob/622e95bd5c275cee11015d5e2f5348c9b3c60963/.github/workflows/npm_publish.yml#L47-L52 and https://github.com/ethereum-optimism/optimism-monorepo/blob/622e95bd5c275cee11015d5e2f5348c9b3c60963/.github/workflows/build-test-lint.yml#L72-L77 |
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* Final gas optimizations for CTC * delete and re-init * Fix issue with tests failing * Use encoding/decoding from core-utils * dev: Use eth-optimism/core-utils where applicable (#281) * Use core-utils where applicable * Further reduce utils * Update ovmCREATEEOA.spec.ts Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * remove unused import * Revert "remove unused import" This reverts commit 1df87926e7a3ca8ebdf7448ad5f0395fe7766ff7. * actually fix imports * A few more comments * address PR feedback - add comments, renaming vars * Optimization: Conditional Monotonicity Checking (#307) * trying it * cleanup * remove duplicate comment * fix docstring * fix var name * missing period Co-authored-by: Ben Jones <ben@pseudonym.party> Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com>
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
Inphi
pushed a commit
that referenced
this pull request
Aug 16, 2024
Updates DelayedWETH to use call instead of transfer because transfer only sends along 2300 gas which will cause the transfer to fail if the owner contract uses lots of gas in the fallback function. Adds tests that demonstrate that the function now works appropriately under any reasonable amount of gas usage. In theory this means the recovery function can be reentered but this isn't an issue because the function is authenticated and is recovering all of the ETH in the contract anyway.
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Aug 20, 2024
…#228) Updates DelayedWETH to use call instead of transfer because transfer only sends along 2300 gas which will cause the transfer to fail if the owner contract uses lots of gas in the fallback function. Adds tests that demonstrate that the function now works appropriately under any reasonable amount of gas usage. In theory this means the recovery function can be reentered but this isn't an issue because the function is authenticated and is recovering all of the ETH in the contract anyway.
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* feat(client): Add `current_output_root` to block executor Adds a function to the block executor that allows for generating the current output root, based on the parent timestamp and current trie. * feat(client): Account + Account storage hinting in `TrieDB` Introcues the `TrieDBHinter` trait, which outlines an interface for sending hints to the host for trie account proofs and storage slot proofs. This enables `kona-host` to use `eth_getProof` rather than the very limited `debug_dbGet` for fetching account proofs during L2 execution.
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Adds small docs for `op-alloy-rpc-types`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OGS package has largely been deprecated and is replicated in another repo, so we can go ahead and remove from the monorepo. This PR does that!
Contributing Agreement