Conversation
Skip some tests that flake in CI. It is safe to skip these because this code will not be changed and we will be deprecating this codebase soon.
…ests l2geth: skip flaky accountcmd tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
… changeset (#2389) Co-authored-by: Maurelian <maurelian@protonmail.ch>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* deps: bump to typescript@4.6.2 This bumps the typescript dep so that only one needs to be installed and updates to the latest version of typescript * Update tsconfigs Co-authored-by: Matthew Slipper <me@matthewslipper.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Teleportr was getting released on GitHub, but not pushed to Docker Hub. The indexer's canary builds were pushing `batch-submitter-service` images, which was incorrect. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
- Requires all threads to be resolved - Adds/removes a `conflict` label when there are merge conflicts/when they are cleared. - Adds a comment and removes the `on-merge-train` label when a queued merge fails. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Not sure why Mergify didn't pick this up in CI.
ci: Fix bad condition
The tests include: - `TestBoundedForkedSync62` - `TestBoundedForkedSync63Full` - `TestBoundedForkedSync63Fast` - `TestBoundedForkedSync64Full` - `TestBoundedForkedSync64Fast` - `TestBoundedForkedSync64Light` None of these tests cover code that we use in production. These tests were flaky upstream and eventually fixed. No major changes to this codebase are planned before deprecating it. Co-authored-by: Matthew Slipper <me@matthewslipper.com>
This should speed up builds as more common base images are built and also opens up the possibility of using generics in the code. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* go-builder: bump versions Use `golang:1.18.0-alpine3.15` and `golangci-lint@1.45.2`. This will allow linting of code that uses generics * ci: add go-builder + js-builder to ci publish Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 0c4d4e0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mslipper
approved these changes
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge develop into master