{go,js}-builder: bump versions, add to ci#2405
Merged
mergify[bot] merged 4 commits intodevelopfrom Apr 4, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 1180943 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mslipper
approved these changes
Apr 4, 2022
Use `golang:1.18.0-alpine3.15` and `golangci-lint@1.45.2`. This will allow linting of code that uses generics
This comment was marked as outdated.
This comment was marked as outdated.
smartcontracts
approved these changes
Apr 4, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
adriang-90
pushed a commit
to adriang-90/optimism
that referenced
this pull request
Apr 6, 2022
* go-builder: bump versions Use `golang:1.18.0-alpine3.15` and `golangci-lint@1.45.2`. This will allow linting of code that uses generics * ci: add go-builder + js-builder to ci publish Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
* go-builder: bump versions Use `golang:1.18.0-alpine3.15` and `golangci-lint@1.45.2`. This will allow linting of code that uses generics * ci: add go-builder + js-builder to ci publish Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
## Description This PR lays the groundwork of the implementation of the `op-conductor`. It introduces skeleton code to support most of the `admin` api methods. Meaningful changes: - Creates admin api RPC server/client. Hook it to the `RPCActor`, the `SequencerActor` and the `NodeActor` - Rename `NetworkRpc` to `P2pRpc` - Make it possible to start/stop the sequencer inside the `SequencerActor`. Does a small refactor of the actor's internal logic. ## Follow-ups - Plug the op-conductor into the CLI interface - Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
golang:1.18.0-alpine3.15and
golangci-lint@1.45.2. Thiswill allow linting of code that
uses generics