Skip to content

ci: Add action to close stale PRs#2388

Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
mslipper:feat/stale-prs
Apr 4, 2022
Merged

ci: Add action to close stale PRs#2388
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
mslipper:feat/stale-prs

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2022

⚠️ No Changeset found

Latest commit: 72d431e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from tuxcanfly and tynes March 31, 2022 20:22
@smartcontracts
Copy link
Copy Markdown
Contributor

I personally think this should be applied to only PRs and not issues. Some issues really are just old but still relevant and don't have much movement because they're being solved on longer timescales.

@mslipper
Copy link
Copy Markdown
Contributor Author

mslipper commented Apr 3, 2022

Fair enough. I exempted issues from being marked as stale. Also made it possible to tag PRs as exempt-stale to prevent them from being marked as stale.

@mslipper mslipper changed the title ci: Add action to close stale PRs and issues ci: Add action to close stale PRs Apr 3, 2022
Copy link
Copy Markdown
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 4, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit edde4de into ethereum-optimism:develop Apr 4, 2022
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap added a commit that referenced this pull request Dec 10, 2025
…#2388)

## Description

This PR refactors the core logic of the engine task handler. In
particular, it moves duplicate code from the build and the insert unsafe
tasks to the forkchoice task.

Changes:
- Add an associated `Output` type for the `EngineTaskExt` trait which
allows the implementors of this trait to be composed. In particular, the
`ForkchoiceTask` may returns the payload id that was inserted in the EL,
which can be used by the `BuildTask` to consolidate the payload into the
engine state.
- Allows the `ForkchoiceTask` to directly insert newly built payload
attributes into the EL (by adding an `Option<OpAttributeWithParent>`
argument to the `ForkchoiceTask`). This allows to refactors both calls
to the `FCU` inside the `BuildTask` using the `ForkchoiceTask` and
avoids manually handling the forkchoice updates
- Moves the `PayloadStatus` verification logic to the `ForkchoiceTask`
to avoid having to perform the same logic in both the `BuildTask` and
the `InsertUnsafeTask`, which allows to fix the sequencer kickstart
issue described in #2372

Close #2372 

## Potential follow-ups

- Remove the clones inside the engine tasks
- Refactor the `new_payload` logic into an engine task to remove
duplicate code in the `InsertUnsafe` and `Build`Tasks
theochap added a commit that referenced this pull request Dec 10, 2025
…nchronize task. move block building logic to build task (#2524)

## Description

Attempt at cleaning-up the engine and restoring the behavior from
pre-refactor https://github.com/op-rs/kona/pull/2388/files.
In particular:
- Split up the forkchoice task into separated build and synchronize
logic. The synchronize logic is now closer to the pre #2388 state
- Restore the build FCU method in the build task. Ensure that the
side-effects match the pre-#2388 state
- Audit the other tasks and ensure the composition (if any), follow the
side-effects from #2388
- Remove the `Forkchoice` task from the `EngineTask`s.
theochap added a commit that referenced this pull request Dec 10, 2025
…nchronize task. move block building logic to build task (op-rs/kona#2524)

## Description

Attempt at cleaning-up the engine and restoring the behavior from
pre-refactor https://github.com/op-rs/kona/pull/2388/files.
In particular:
- Split up the forkchoice task into separated build and synchronize
logic. The synchronize logic is now closer to the pre op-rs/kona#2388 state
- Restore the build FCU method in the build task. Ensure that the
side-effects match the pre-#2388 state
- Audit the other tasks and ensure the composition (if any), follow the
side-effects from op-rs/kona#2388
- Remove the `Forkchoice` task from the `EngineTask`s.
theochap added a commit that referenced this pull request Jan 14, 2026
…nchronize task. move block building logic to build task (op-rs/kona#2524)

## Description

Attempt at cleaning-up the engine and restoring the behavior from
pre-refactor https://github.com/op-rs/kona/pull/2388/files.
In particular:
- Split up the forkchoice task into separated build and synchronize
logic. The synchronize logic is now closer to the pre #2388 state
- Restore the build FCU method in the build task. Ensure that the
side-effects match the pre-#2388 state
- Audit the other tasks and ensure the composition (if any), follow the
side-effects from #2388
- Remove the `Forkchoice` task from the `EngineTask`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants