ci: Add action to close stale PRs#2388
ci: Add action to close stale PRs#2388mergify[bot] merged 2 commits intoethereum-optimism:developfrom
Conversation
|
|
I personally think this should be applied to only PRs and not issues. Some issues really are just old but still relevant and don't have much movement because they're being solved on longer timescales. |
|
Fair enough. I exempted issues from being marked as stale. Also made it possible to tag PRs as |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…#2388) ## Description This PR refactors the core logic of the engine task handler. In particular, it moves duplicate code from the build and the insert unsafe tasks to the forkchoice task. Changes: - Add an associated `Output` type for the `EngineTaskExt` trait which allows the implementors of this trait to be composed. In particular, the `ForkchoiceTask` may returns the payload id that was inserted in the EL, which can be used by the `BuildTask` to consolidate the payload into the engine state. - Allows the `ForkchoiceTask` to directly insert newly built payload attributes into the EL (by adding an `Option<OpAttributeWithParent>` argument to the `ForkchoiceTask`). This allows to refactors both calls to the `FCU` inside the `BuildTask` using the `ForkchoiceTask` and avoids manually handling the forkchoice updates - Moves the `PayloadStatus` verification logic to the `ForkchoiceTask` to avoid having to perform the same logic in both the `BuildTask` and the `InsertUnsafeTask`, which allows to fix the sequencer kickstart issue described in #2372 Close #2372 ## Potential follow-ups - Remove the clones inside the engine tasks - Refactor the `new_payload` logic into an engine task to remove duplicate code in the `InsertUnsafe` and `Build`Tasks
…nchronize task. move block building logic to build task (#2524) ## Description Attempt at cleaning-up the engine and restoring the behavior from pre-refactor https://github.com/op-rs/kona/pull/2388/files. In particular: - Split up the forkchoice task into separated build and synchronize logic. The synchronize logic is now closer to the pre #2388 state - Restore the build FCU method in the build task. Ensure that the side-effects match the pre-#2388 state - Audit the other tasks and ensure the composition (if any), follow the side-effects from #2388 - Remove the `Forkchoice` task from the `EngineTask`s.
…nchronize task. move block building logic to build task (op-rs/kona#2524) ## Description Attempt at cleaning-up the engine and restoring the behavior from pre-refactor https://github.com/op-rs/kona/pull/2388/files. In particular: - Split up the forkchoice task into separated build and synchronize logic. The synchronize logic is now closer to the pre op-rs/kona#2388 state - Restore the build FCU method in the build task. Ensure that the side-effects match the pre-#2388 state - Audit the other tasks and ensure the composition (if any), follow the side-effects from op-rs/kona#2388 - Remove the `Forkchoice` task from the `EngineTask`s.
…nchronize task. move block building logic to build task (op-rs/kona#2524) ## Description Attempt at cleaning-up the engine and restoring the behavior from pre-refactor https://github.com/op-rs/kona/pull/2388/files. In particular: - Split up the forkchoice task into separated build and synchronize logic. The synchronize logic is now closer to the pre #2388 state - Restore the build FCU method in the build task. Ensure that the side-effects match the pre-#2388 state - Audit the other tasks and ensure the composition (if any), follow the side-effects from #2388 - Remove the `Forkchoice` task from the `EngineTask`s.
No description provided.