Skip to content

l2geth: skip unused tests#2408

Merged
mergify[bot] merged 2 commits intodevelopfrom
fix/skip-tests
Apr 4, 2022
Merged

l2geth: skip unused tests#2408
mergify[bot] merged 2 commits intodevelopfrom
fix/skip-tests

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Apr 4, 2022

Description

The tests include:

  • TestBoundedForkedSync62
  • TestBoundedForkedSync63Full
  • TestBoundedForkedSync63Fast
  • TestBoundedForkedSync64Full
  • TestBoundedForkedSync64Fast
  • TestBoundedForkedSync64Light

None of these tests cover code that we use in production.
These tests were flaky upstream and eventually fixed.
No major changes to this codebase are planned before
deprecating it.

The tests include:
- `TestBoundedForkedSync62`
- `TestBoundedForkedSync63Full`
- `TestBoundedForkedSync63Fast`
- `TestBoundedForkedSync64Full`
- `TestBoundedForkedSync64Fast`
- `TestBoundedForkedSync64Light`

None of these tests cover code that we use in production.
These tests were flaky upstream and eventually fixed.
No major changes to this codebase are planned before
deprecating it.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 4, 2022

🦋 Changeset detected

Latest commit: c14ae1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly April 4, 2022 18:45
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 4, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 45582fc into develop Apr 4, 2022
@mergify mergify bot deleted the fix/skip-tests branch April 4, 2022 19:09
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 4, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

adriang-90 pushed a commit to adriang-90/optimism that referenced this pull request Apr 6, 2022
The tests include:
- `TestBoundedForkedSync62`
- `TestBoundedForkedSync63Full`
- `TestBoundedForkedSync63Fast`
- `TestBoundedForkedSync64Full`
- `TestBoundedForkedSync64Fast`
- `TestBoundedForkedSync64Light`

None of these tests cover code that we use in production.
These tests were flaky upstream and eventually fixed.
No major changes to this codebase are planned before
deprecating it.

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
The tests include:
- `TestBoundedForkedSync62`
- `TestBoundedForkedSync63Full`
- `TestBoundedForkedSync63Fast`
- `TestBoundedForkedSync64Full`
- `TestBoundedForkedSync64Fast`
- `TestBoundedForkedSync64Light`

None of these tests cover code that we use in production.
These tests were flaky upstream and eventually fixed.
No major changes to this codebase are planned before
deprecating it.

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
fix broken url

Signed-off-by: geekvest <cuimoman@sohu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cannon Area: cannon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants