Skip to content

[Do not merge] CircleCI test#2331

Closed
mslipper wants to merge 86 commits intodevelopfrom
feat/circleci-2
Closed

[Do not merge] CircleCI test#2331
mslipper wants to merge 86 commits intodevelopfrom
feat/circleci-2

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

@mslipper mslipper commented Mar 15, 2022

  • --wip-- [skip ci]
  • --wip-- [skip ci]
  • --wip-- [skip ci]
  • --wip-- [skip ci]

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 15, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 49f331e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #2331 (52987f5) into develop (4bfddfb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2331   +/-   ##
========================================
  Coverage    80.14%   80.14%           
========================================
  Files           77       77           
  Lines         2458     2458           
  Branches       450      450           
========================================
  Hits          1970     1970           
  Misses         488      488
Flag Coverage Δ
contracts 99.29% <ø> (ø)
core-utils 86.77% <ø> (ø)
data-transport-layer 49.72% <ø> (ø)
sdk 55.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfddfb...52987f5. Read the comment docs.

@mslipper mslipper closed this Mar 18, 2022
@mslipper mslipper deleted the feat/circleci-2 branch April 19, 2022 08:21
theochap pushed a commit that referenced this pull request Dec 10, 2025
@itschaindev @dhyaniarun1993
fix (supervisor/core): correctly interpreting derivationUpdate and …
9398dbb 
…`derivationOriginUpdate` (#2331)

Closes #2086 

The PR:
- Introduces new table `BlockTraversal` to store all L1 blocks, even if
there are no L2 blocks derived from it.
- Add respective trait methods.
- Modified `latest_derived_block_pair` to send the latest derived block
from `DerivedBlocks` and latest source block from `BlockTraversal`.
- Exclusively dealing with `derivationUpdate` and
`derivationOriginUpdate` i.e. updating latest derived on
`derivationUpdate` and updating latest source on
`derivationOriginUpdate`.
- The e2e test `TestFinalizedHeadAdvancing` passes now. 

TODO: (in another PR)
- Remove `current_l1` and its usage. No longer required.
- ~~For now, `check_node_consistency()` is commented in this PR. #2330
takes care of that.~~

~~Currently in draft: Tests are missing.~~

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-ops Area: ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mslipper @codecov-commenter